Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 06 Nov 2018 11:15:13 -0800 (PST)
Message-Id: <20181106.111513.858603892736758550.davem@davemloft.net>
To:     suraj1998@gmail.com
Cc:     edumazet@google.com, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: net: ipv4: tcp_westwood: fixed warnings and
 checks
From:   David Miller <davem@davemloft.net>
In-Reply-To: <1541425985-31869-1-git-send-email-suraj1998@gmail.com>
References: <1541425985-31869-1-git-send-email-suraj1998@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Suraj Singh <suraj1998@gmail.com>
Date: Mon,  5 Nov 2018 19:23:05 +0530

> Fixed warnings and checks for TCP Westwood
> 
> Signed-off-by: Suraj Singh <suraj1998@gmail.com>

I asked you yesterday why "staging: " appears in your subject line
and you have failed to respond and explain.

There are also functional issues with your patch:

> -		tp->snd_cwnd = tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
> +		tp->snd_cwnd = tcp_westwood_bw_rttmin(sk);
> +		tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);

This is bogus, now tcp_westwood_bw_rttmin(sk) will potentially be called
two times instead of once.

The existing code is fine, please do not modify it.