Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181022222614.41016-1-mikewu@google.com> <20181106232130.33932-1-mikewu@google.com>
In-Reply-To: <20181106232130.33932-1-mikewu@google.com>
From:   Ke Wu <mikewu@google.com>
Date:   Tue, 6 Nov 2018 15:23:19 -0800
Message-ID: <CANRnR9QkiiNNxSBzLUeFHw--xPGVEd5E0RfqNTgj4ji8LmVz7g@mail.gmail.com>
Subject: Re: [PATCH v2] modsign: use all trusted keys to verify module signature
To:     jeyu@kernel.org, dhowells@redhat.com
Cc:     linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thanks for the comment! I switched to use
VERIFY_USE_SECONDARY_KEYRING, please take a look.

On Tue, Nov 6, 2018 at 3:21 PM Ke Wu <mikewu@google.com> wrote:
>
> Make mod_verify_sig to use all trusted keys. This allows keys in
> secondary_trusted_keys to be used to verify PKCS#7 signature on a
> kernel module.
>
> Signed-off-by: Ke Wu <mikewu@google.com>
> ---
> Changelog since v1:
> - Use VERIFY_USE_SECONDARY_KEYRING rather than (void *)1UL
>
>  kernel/module_signing.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/module_signing.c b/kernel/module_signing.c
> index f2075ce8e4b3..6b9a926fd86b 100644
> --- a/kernel/module_signing.c
> +++ b/kernel/module_signing.c
> @@ -83,6 +83,7 @@ int mod_verify_sig(const void *mod, struct load_info *info)
>         }
>
>         return verify_pkcs7_signature(mod, modlen, mod + modlen, sig_len,
> -                                     NULL, VERIFYING_MODULE_SIGNATURE,
> +                                     VERIFY_USE_SECONDARY_KEYRING,
> +                                     VERIFYING_MODULE_SIGNATURE,
>                                       NULL, NULL);
>  }
> --
> 2.19.1.930.g4563a0d9d0-goog
>


-- 
Ke Wu | Software Engineer | mikewu@google.com | Google Inc.