Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2918145imu; Wed, 7 Nov 2018 01:38:27 -0800 (PST) X-Google-Smtp-Source: AJdET5cgWGIvVTRTaxuUXQriVs7OMQPh474WUZQ3lYbmF5glH9TcvvLiZANbv00gS7sX204b4mWr X-Received: by 2002:a63:ae01:: with SMTP id q1mr960371pgf.402.1541583507059; Wed, 07 Nov 2018 01:38:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541583507; cv=none; d=google.com; s=arc-20160816; b=S45DNRrZ0JumGrtccvTXlCUBCOTc+zN7MAggRLzx264e2+w6f2muTOFA04CXo9HTVi ki4MAgCC1sMFq6s6YrDzNkFsdGLe7bQVjm/KUbvAxUbLdEyMHItV3JDreLcDLhy9CW7K 42gVZRE6sdAdy8JSnh4WDlPl9u7pfqF2DI5hOW890kExAQjr5cbAVN96JeCgPnionw6V Mv8+uvkYAc8mq4MmwGgltE8qp2Kv39cILOfTam2s7h/5vm0gzd/2fKnjU/ymTmsJ9XtT ay2hgixhgPzsw2E2DcSwEgISA3MxwCmyLf8tZuJdvfSqLOAiY3g1KjsjtEElRfQLUSR2 WiDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=7Qg2K5UFKCyPWm0FKNjN5FXBD5ZhHFZJEpVwYDpaxkQ=; b=x7GoIgabG2HirGnMuBbflu3Ho2oJNnI522X8KWoYmjWSLLK34lTmVJyy1vTwnAWyPY cDtWXSn2ppFeI4ccXI6YyYR76xWsAy0Qn+AXTXFOQFRfBegQzinVbKE0dZhrkx+LnYBm Jq1PXCJfR7y+XumoiYSi+k+8sBdHoMToxXzlmHhGwGWjHXsKnb4Gtk5FXQXmnK7WsSzh GNb6IhT/CmaTZHug/HINl6J4G2TghuDzVelCLfJ+m15KROXVNWRjtlpsNULxWiPIgEt0 N+seF9I2jl+6eA+J6WDJS0rwLe1Q8JWt/bRx9bjuvQuK67E3+v6lfFsdpdtgb0ryQDbM 32JQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kdab.com header.s=dkim header.b=gUF9WNXZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=kdab.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n78-v6si50788pfi.171.2018.11.07.01.38.11; Wed, 07 Nov 2018 01:38:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kdab.com header.s=dkim header.b=gUF9WNXZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=kdab.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730516AbeKGTGn (ORCPT + 99 others); Wed, 7 Nov 2018 14:06:43 -0500 Received: from mail.kdab.com ([176.9.126.58]:50178 "EHLO mail.kdab.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726097AbeKGTGn (ORCPT ); Wed, 7 Nov 2018 14:06:43 -0500 Authentication-Results: mail.kdab.com (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=kdab.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kdab.com; h= content-transfer-encoding:mime-version:message-id:date:date :subject:subject:from:from; s=dkim; t=1541583428; x=1542447429; bh=7Qg2K5UFKCyPWm0FKNjN5FXBD5ZhHFZJEpVwYDpaxkQ=; b=gUF9WNXZnTlT cyuqj+r52VDZMS2NAHqHue7y6HZo51fIoqVm52y4E0DxIqG2GM/4OVfLW9prVbAA sKXZFzX09M+iTtQPi99fVzgcKs1s745GtTyxfRCaPMOrNt+WmKAZlsV7FMsb44kI EFJHEIuNyRCuYvVKuP9SR8vV/ggRf8M= X-Virus-Scanned: amavisd-new at kdab.com From: Milian Wolff To: acme@kernel.org, jolsa@kernel.org Cc: Linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Milian Wolff Subject: [PATCH] perf script: add newline after uregs output Date: Wed, 7 Nov 2018 10:37:05 +0100 Message-Id: <20181107093705.16346-1-milian.wolff@kdab.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This change makes it much easier to easily distinguish between consecutive samples by keeping the empty line between them, like we see when we do not enable uregs output. Before: ``` cpp-inlining 28298 [-01] 54837.342780: 3068085 cycles:pp: 7ffff7c96709 __hypot_finite+0xa9 (/usr/lib/libm-2.28.so) ... ABI:2 AX:0x0 BX:0x40f56cf6 CX:0x294a3ae7 ... cpp-inlining 28298 [-01] 54837.344493: 2881929 cycles:pp: 7ffff7c96696 __hypot_finite+0x36 (/usr/lib/libm-2.28.so) ... ABI:2 AX:0x40d440c7 BX:0x40d440c7 CX:0x4d45e5da ... ``` After: ``` cpp-inlining 28298 [-01] 54837.342780: 3068085 cycles:pp: 7ffff7c96709 __hypot_finite+0xa9 (/usr/lib/libm-2.28.so) ... ABI:2 AX:0x0 BX:0x40f56cf6 CX:0x294a3ae7 ... cpp-inlining 28298 [-01] 54837.344493: 2881929 cycles:pp: 7ffff7c96696 __hypot_finite+0x36 (/usr/lib/libm-2.28.so) ... ABI:2 AX:0x40d440c7 BX:0x40d440c7 CX:0x4d45e5da ... ``` Signed-off-by: Milian Wolff Cc: Arnaldo Carvalho de Melo --- tools/perf/builtin-script.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c index b5bc85bd0bbe..daf73832743e 100644 --- a/tools/perf/builtin-script.c +++ b/tools/perf/builtin-script.c @@ -603,6 +603,8 @@ static int perf_sample__fprintf_uregs(struct perf_sam= ple *sample, printed +=3D fprintf(fp, "%5s:0x%"PRIx64" ", perf_reg_name(r), val); } =20 + fprintf(fp, "\n"); + return printed; } =20 --=20 2.19.1