Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2] slimbus: ngd: QCOM_QMI_HELPERS has to be selected
To:     Greg KH <gregkh@linuxfoundation.org>,
        Niklas Cassel <niklas.cassel@linaro.org>
Cc:     linux-kernel@vger.kernel.org
References: <20181015183218.GA16900@kroah.com>
 <20181015194441.10475-1-niklas.cassel@linaro.org>
 <20181107135911.GA23393@kroah.com>
From:   Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Message-ID: <f6e9ae15-b52b-b8c5-3d16-3b67b8977c38@linaro.org>
Date:   Wed, 7 Nov 2018 14:15:33 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20181107135911.GA23393@kroah.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 07/11/18 13:59, Greg KH wrote:
> Really?  I do this and then I get this build error on x86:
> 
> drivers/slimbus/qcom-ngd-ctrl.c: In function ‘of_qcom_slim_ngd_register’:
> drivers/slimbus/qcom-ngd-ctrl.c:1333:63: warning: dereferencing ‘void *’ pointer
>    data = of_match_node(qcom_slim_ngd_dt_match, parent->of_node)->data;
>                                                                 ^~
> drivers/slimbus/qcom-ngd-ctrl.c:1333:63: error: request for member ‘data’ in something not a structure or union
> 
> 
> So I can't take this, something else must be wrong here...
That is fine!
Yes, there seems to be one more issue here, on non DT platforms 
of_match_node is set to be NULL, which is why we are seeing this error I 
guess!

I will fix this up, do some test and send both the fixes together.

thanks,
srini