Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 7 Nov 2018 15:37:13 +0100
From:   Peter Zijlstra <peterz@infradead.org>
To:     Patrick Bellasi <patrick.bellasi@arm.com>
Cc:     linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
        Ingo Molnar <mingo@redhat.com>, Tejun Heo <tj@kernel.org>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Paul Turner <pjt@google.com>,
        Quentin Perret <quentin.perret@arm.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Morten Rasmussen <morten.rasmussen@arm.com>,
        Juri Lelli <juri.lelli@redhat.com>,
        Todd Kjos <tkjos@google.com>,
        Joel Fernandes <joelaf@google.com>,
        Steve Muckle <smuckle@google.com>,
        Suren Baghdasaryan <surenb@google.com>
Subject: Re: [PATCH v5 03/15] sched/core: uclamp: map TASK's clamp values
 into CPU's clamp groups
Message-ID: <20181107143713.GS9781@hirez.programming.kicks-ass.net>
References: <20181029183311.29175-1-patrick.bellasi@arm.com>
 <20181029183311.29175-4-patrick.bellasi@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181029183311.29175-4-patrick.bellasi@arm.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Oct 29, 2018 at 06:32:57PM +0000, Patrick Bellasi wrote:
> +static int __setscheduler_uclamp(struct task_struct *p,
> +				 const struct sched_attr *attr)
> +{
> +	unsigned int lower_bound = p->uclamp[UCLAMP_MIN].value;
> +	unsigned int upper_bound = p->uclamp[UCLAMP_MAX].value;
> +	int result = 0;
> +
> +	if (attr->sched_flags & SCHED_FLAG_UTIL_CLAMP_MIN)
> +		lower_bound = attr->sched_util_min;
> +
> +	if (attr->sched_flags & SCHED_FLAG_UTIL_CLAMP_MAX)
> +		upper_bound = attr->sched_util_max;
> +
> +	if (lower_bound > upper_bound ||
> +	    upper_bound > SCHED_CAPACITY_SCALE)
>  		return -EINVAL;
>  
> +	mutex_lock(&uclamp_mutex);
>  
> +	/* Update each required clamp group */
> +	if (attr->sched_flags & SCHED_FLAG_UTIL_CLAMP_MIN) {
> +		uclamp_group_get(&p->uclamp[UCLAMP_MIN],
> +				 UCLAMP_MIN, lower_bound);
> +	}
> +	if (attr->sched_flags & SCHED_FLAG_UTIL_CLAMP_MAX) {
> +		uclamp_group_get(&p->uclamp[UCLAMP_MAX],
> +				 UCLAMP_MAX, upper_bound);
> +	}
> +
> +	mutex_unlock(&uclamp_mutex);
> +
> +	return result;
> +}

I'm missing where we error due to lack of groups.