Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 7 Nov 2018 15:37:51 +0100
From:   Jessica Yu <jeyu@kernel.org>
To:     Ke Wu <mikewu@google.com>
Cc:     dhowells@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] modsign: use all trusted keys to verify module
 signature
Message-ID: <20181107143750.GA26862@linux-8ccs>
References: <20181022222614.41016-1-mikewu@google.com>
 <20181106232130.33932-1-mikewu@google.com>
 <CANRnR9QkiiNNxSBzLUeFHw--xPGVEd5E0RfqNTgj4ji8LmVz7g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <CANRnR9QkiiNNxSBzLUeFHw--xPGVEd5E0RfqNTgj4ji8LmVz7g@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

+++ Ke Wu [06/11/18 15:23 -0800]:
>Thanks for the comment! I switched to use
>VERIFY_USE_SECONDARY_KEYRING, please take a look.

Patch has been queued on modules-next. Thanks!

Jessica

>On Tue, Nov 6, 2018 at 3:21 PM Ke Wu <mikewu@google.com> wrote:
>>
>> Make mod_verify_sig to use all trusted keys. This allows keys in
>> secondary_trusted_keys to be used to verify PKCS#7 signature on a
>> kernel module.
>>
>> Signed-off-by: Ke Wu <mikewu@google.com>
>> ---
>> Changelog since v1:
>> - Use VERIFY_USE_SECONDARY_KEYRING rather than (void *)1UL
>>
>>  kernel/module_signing.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/kernel/module_signing.c b/kernel/module_signing.c
>> index f2075ce8e4b3..6b9a926fd86b 100644
>> --- a/kernel/module_signing.c
>> +++ b/kernel/module_signing.c
>> @@ -83,6 +83,7 @@ int mod_verify_sig(const void *mod, struct load_info *info)
>>         }
>>
>>         return verify_pkcs7_signature(mod, modlen, mod + modlen, sig_len,
>> -                                     NULL, VERIFYING_MODULE_SIGNATURE,
>> +                                     VERIFY_USE_SECONDARY_KEYRING,
>> +                                     VERIFYING_MODULE_SIGNATURE,
>>                                       NULL, NULL);
>>  }
>> --
>> 2.19.1.930.g4563a0d9d0-goog
>>
>
>
>-- 
>Ke Wu | Software Engineer | mikewu@google.com | Google Inc.