Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3296190imu; Wed, 7 Nov 2018 08:09:37 -0800 (PST) X-Google-Smtp-Source: AJdET5fHmzZVjuByJMqai80jm1IL7cAXhUtqytBwZPH9I2BBf8A1HiPBzqMnT7ZIxg6SYOpo2hBT X-Received: by 2002:a62:5615:: with SMTP id k21-v6mr793205pfb.190.1541606977394; Wed, 07 Nov 2018 08:09:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541606977; cv=none; d=google.com; s=arc-20160816; b=K88oYqWQ362S3h4L6lMQpypOA1I3OWfcPWq/52ZIOc+abIwagvHqntQbAl1SCcb58i dNAhRaQlOhLeoALQh1J9WBveYVKljngT9HI0G75PLwH0W8+tnuLsVR8oL7wgPAQgPG5O aXIy4/VLngSD6qeNR7WDmQQJhATvxsBe1WoNmWoT33CNM/q4bekGYRmaWAKgajnS4XSR MhJXnVtspJfyn9/8SvcVlSx6Al1a0BBRsQaCnqLTdZB/25yJWJyzOir+oi49VjGmQsp4 RJHTIRjBSWkTB1rDIdyTGiHFW0X2XhIF/smhMWSdO7SYc5fGMQlLOVjgmnXWopq/71Dh Y8YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature; bh=7AE4OJ7IwM64nMxZd3So8NMXiXZM3kqZ8yoD3EgR4AQ=; b=i5F9iS8+faVPKruADWatFSWcAkcREafrkOs76W8AYLWN3o3rjuboF5mD8F7RAy4hwW YcRtEA2dH+9JPGYEmjgy+0X/K1HwUWTwkwHizT8PkpxyN7rKViG15akX3ROHCMPOSyLD V1mc6kYxuLP9qzcdydJgwA40XQXqh13tiftDT+708z8gQW1Y95BvCNDX33rcbrnILc7S zC7emfNCSScuF3+vy6XDL2CRLi1mMYHlcgXBPdyoa9IRiZryWgcWegzQ26U6dgOS/ipG 6rDR3QuthYCTTEMGXLjNFOo4w3oYoYv5XgnrekSVitLhb8hD3f/lpTmNaoEorUQhKyuM vZFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@thunk.org header.s=ef5046eb header.b=m8FjoKgN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z8-v6si931090pgc.286.2018.11.07.08.09.22; Wed, 07 Nov 2018 08:09:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@thunk.org header.s=ef5046eb header.b=m8FjoKgN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731137AbeKHBj2 (ORCPT + 99 others); Wed, 7 Nov 2018 20:39:28 -0500 Received: from imap.thunk.org ([74.207.234.97]:49392 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727561AbeKHBj2 (ORCPT ); Wed, 7 Nov 2018 20:39:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org; s=ef5046eb; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7AE4OJ7IwM64nMxZd3So8NMXiXZM3kqZ8yoD3EgR4AQ=; b=m8FjoKgNBF0RXrkRc+MotJwfzQ NsQDQV6ZbJ4W/T98BWNHG781diwOo6FI4R+qHuxFX07PZSebJ5jFlhtwpl3fp0/Ihc6Jd4G3Ls34N kis4Q5v8eStMD9pacjCgHWcP5rEeteafzEbMlDXxISeoPQHoK4IYpWviUwo4fsOxxicQ=; Received: from root (helo=callcc.thunk.org) by imap.thunk.org with local-esmtp (Exim 4.89) (envelope-from ) id 1gKQNX-0000WK-Ps; Wed, 07 Nov 2018 16:08:27 +0000 Received: by callcc.thunk.org (Postfix, from userid 15806) id E60FF7A7D14; Wed, 7 Nov 2018 11:08:26 -0500 (EST) Date: Wed, 7 Nov 2018 11:08:26 -0500 From: "Theodore Y. Ts'o" To: Vasily Averin Cc: linux-ext4@vger.kernel.org, Andreas Dilger , linux-kernel@vger.kernel.org, Tiger Yang Subject: Re: [PATCH 5/7] ext4: bs.bh cleanup before re-using in ext4_xattr_block_find() Message-ID: <20181107160826.GF9919@thunk.org> Mail-Followup-To: "Theodore Y. Ts'o" , Vasily Averin , linux-ext4@vger.kernel.org, Andreas Dilger , linux-kernel@vger.kernel.org, Tiger Yang References: <1a83ea26-a159-490a-1e07-e7c8f187672a@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1a83ea26-a159-490a-1e07-e7c8f187672a@virtuozzo.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 31, 2018 at 10:12:52PM +0300, Vasily Averin wrote: > bs.bh was taken in previous ext4_xattr_block_find() call, > it should be released before re-using > > Fixes 7e01c8e5420b ("ext3/4: fix uninitialized bs in ...") # 2.6.26 > cc: Tiger Yang > > Signed-off-by: Vasily Averin Thanks, applied. I used the commit description: ext4: release bs.bh before re-using in ext4_xattr_block_find() - Ted