Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3386859imu; Wed, 7 Nov 2018 09:31:42 -0800 (PST) X-Google-Smtp-Source: AJdET5eQDEZsCZrm6bxcJoWO26FpnOnODZAh/8HmGJioSgkv8nvMtQJoQ5mFXdW88vWkhCylcze1 X-Received: by 2002:a17:902:6948:: with SMTP id k8-v6mr1125343plt.22.1541611902054; Wed, 07 Nov 2018 09:31:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541611902; cv=none; d=google.com; s=arc-20160816; b=M0CepAkd6isXQuLT9hW+IgDVdw2nVpSQ2h7/O5KXePH9O+a50KKXFgZXfhYcVZaSnU fuYECynEt++ojtB1kN28pApiFPGzb/3Jzfj5foMulBc1LsXxfLMbWMPm2Z4EGb/Fttxg wiFsRn5CqTuJm5zl/TSX+EbrI5fLrOibR70aAg8k3F9V9pKg4My0HpgpqRD5WiAoauVi zHbA7ISFCmfqefvUcdOiQbtJKhUQdy10frUl2iP2MhXXBHmooL9pWXzvu55+w1JXQCTq hhvn3vzSOwskgwt7sBCEQ+3haaCEFXsFfdNQgMSAodkr/kWpdYW2ow0hpoN7d1eQCIoL XXXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:subject:from; bh=kKq+fSgTFQdTr0GvQC7Qt40uLJdz7F6rpuRDZxEwlPk=; b=a6ROdpPInw3yhqIbeMhZF9rR/rfncPMYt860weqg6ZMH+DA04fyk/OguxOTLCIPTTj 7OhjKA4hgZKPfJsHowfqfCMc4q9GlEpe+GS2sof0cmSNwEvglmapibvamxqq9H3Im3bd o04uSgdXJnF2rgwAtC/X20Q1ZlX7rbbw9VMqueJ3rWNsjY6ECt8KcRbx67/5l9wWbaJU FP4cYZdnR3ATBMlbIO48cnHBAMwynhPTrv8UjoC5TQuT7B6ZGsuHsFuEH2aNaEqRhPqB xNsby2BHEHW98Ygde5Gj2L5NQA9NRtN+txnsWDDF61Jffu/eq1/kQRMBVHW6MzVYuQVw MK/w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e129si1092068pgc.333.2018.11.07.09.31.26; Wed, 07 Nov 2018 09:31:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728131AbeKHDBm (ORCPT + 99 others); Wed, 7 Nov 2018 22:01:42 -0500 Received: from relay.sw.ru ([185.231.240.75]:37756 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727859AbeKHDBm (ORCPT ); Wed, 7 Nov 2018 22:01:42 -0500 Received: from [172.16.24.21] by relay.sw.ru with esmtp (Exim 4.90_1) (envelope-from ) id 1gKRek-0003kL-Ij; Wed, 07 Nov 2018 20:30:18 +0300 From: Vasily Averin Subject: [PATCH v2] ext4: lost brelse in __ext4_read_dirblock() To: linux-ext4@vger.kernel.org, Theodore Ts'o , Andreas Dilger Cc: linux-kernel@vger.kernel.org References: <6e5c9e17-5916-7296-35a0-cc0600a79f27@virtuozzo.com> Message-ID: Date: Wed, 7 Nov 2018 20:30:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <6e5c9e17-5916-7296-35a0-cc0600a79f27@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes dc6982ff4db1 ("ext4: refactor code to read directory blocks ...") Cc: stable@kernel.org # 3.9 Signed-off-by: Vasily Averin --- fs/ext4/namei.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index d388cce72db2..6a6b90363ef1 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -126,6 +126,7 @@ static struct buffer_head *__ext4_read_dirblock(struct inode *inode, if (!is_dx_block && type == INDEX) { ext4_error_inode(inode, func, line, block, "directory leaf block found instead of index block"); + brelse(bh); return ERR_PTR(-EFSCORRUPTED); } if (!ext4_has_metadata_csum(inode->i_sb) || -- 2.17.1