Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3403303imu; Wed, 7 Nov 2018 09:47:22 -0800 (PST) X-Google-Smtp-Source: AJdET5fSY9D6eyL/izbT2Iciry7R2ZUDQ+uNH1xGX5XLxyFmt0xtlk+f7aDpM1oOww100QEMK3OD X-Received: by 2002:a17:902:8d94:: with SMTP id v20-v6mr1155515plo.109.1541612842692; Wed, 07 Nov 2018 09:47:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541612842; cv=none; d=google.com; s=arc-20160816; b=ap4xpgxQp6Gb7ZYX0fHoSyuFItoJoWGUP4adFUd9j8srP4wurXIqmqXUlkE128r5/U lNWkPHKbVyHtDCSjJTxUd//ZolvVXEPNECeMHLXOUFzF1K8Fd7zA+MttO03z5h8TqOMZ MIBkog+UGHqFzme1pfUWan1jIpkz5VPY5q/Or2DRZ4AcaI6LEvjMrkgyU3cLRfuhCEIR n0D7alUiqeMvuvTtZ8oGZjsUQCc7RfYSAY+MdqPOT0cH5jy2LJ2q2EGYk5bNNw/c2cN5 tbW2iBR5YfTl7cfA9OtBtSYMVLjEiS3XWM70it38CJsuvCQCDix9GRhKXNNq2xB2lP7Y FP4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=LOKLPVL/KsT8t3RMSP3F8SnKPuBYykBW3BXpx0B7TBk=; b=UyBYdT5qXl1lM6rr8rFxZE7H5MjaKARfEcTqbJaP3dHWUWH0Q71GPyaz0kl+vHKm4s 4eyAkgr+5U2qJ27COkyC+jPkNgabdZ8KTg9zMEpa7xc7q/BzU1lPdT5qItXZTzjh1+L4 D1Hk8s+AKa1gmGCiVr4987Sh99r8VVaM1WSNM4CCBkkIbgLmyhdBvzUm8+YrrAQsUb6A FWkYEMWnvrG8w2ZQcDFE8fcz7ayGAYR29fNUlX1Rw5NvAyvgMiWzooqdNahKjs9H2vaf 4LXslicuBZWpTCrFfGNxvAQetX6vLdkH866KJOlZlY/naKvw7/YjS+i3R1Qt5FwbAffK GIqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="aCxDCj/Z"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 65-v6si1217081pfl.220.2018.11.07.09.47.05; Wed, 07 Nov 2018 09:47:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="aCxDCj/Z"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731439AbeKHDSL (ORCPT + 99 others); Wed, 7 Nov 2018 22:18:11 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:39590 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728085AbeKHDSL (ORCPT ); Wed, 7 Nov 2018 22:18:11 -0500 Received: by mail-pf1-f195.google.com with SMTP id n11-v6so8006611pfb.6; Wed, 07 Nov 2018 09:46:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LOKLPVL/KsT8t3RMSP3F8SnKPuBYykBW3BXpx0B7TBk=; b=aCxDCj/ZVIuuue4FlryrytMrDD0EdMT/YvVSappfIxQtBGieOhDw8WCTN4GE3GIzFE 2URThU0PNOlGj2dA6/R0rJ1iwBN+xYmKDPpU9ZdT4I+kczrcm1PhoINeqzN83sUJQpTh oPq0fbneVwMMLnJd/TVQK4cZ3/j4k9LKNdCxr8VLZirxv9cfTKJ2iUtHvBBwbCZSXltB lQq+EeWwF2d9xmRgAXQC/Ziat/98DyTaQKvekErsbmH/n0n5ZPH6bI3dWJD7W2FEfbHh WYNfKw+l1tiCNs63eUmT65Ls9KLW8FTx88XVajKM24pplB1M9kR7i8BTMDJxCLYoodFY dr1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LOKLPVL/KsT8t3RMSP3F8SnKPuBYykBW3BXpx0B7TBk=; b=l2kuxLv/TtYIoja7DBW1qj7dHRHrbMRfSqkWlkMcD9jrJSdm9uNgXmktW9o8+XXcBN zYZ1m4r5EVK9Nj1nF17f8ZmeJO7Wo4x4UaF1gdta9cS8VAUwLcDN/NhPg8bZC4APYqL1 Z+d9JW8v9kALVhneFY6xF3swASSqf2lB8Mfv9xRuSHaJZ7EjpaL3Q/yn0Q0fZNrJmAIA k7UnHWNvQmD50ryx1Ms+G+tt8tnsFeXzeVj1Kt/WqetZbESjisnGuiLHbize+sTuWCw3 OR93bsiiYA5v5cZAkQ2MBJQzjpYRNeKOGJ1t9xvlzWYJCk9FVeSwgR8uaAy8jOvYvYnQ RVjA== X-Gm-Message-State: AGRZ1gKPs3eygKo5OIPxtarKRkPs5afPaWMOr0dKiAtzi5DF9wV089A9 7VJc2SJgwCw9SmHd9gT0SPcCydmy X-Received: by 2002:a62:7f8c:: with SMTP id a134-v6mr1186753pfd.22.1541612804598; Wed, 07 Nov 2018 09:46:44 -0800 (PST) Received: from [192.168.1.70] (c-24-6-192-50.hsd1.ca.comcast.net. [24.6.192.50]) by smtp.gmail.com with ESMTPSA id x123-v6sm1370196pfb.124.2018.11.07.09.46.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Nov 2018 09:46:43 -0800 (PST) Subject: Re: [RFC v2 00/14] kunit: introduce KUnit, the Linux kernel unit testing framework To: Brendan Higgins , shuah@kernel.org Cc: Greg KH , Kees Cook , mcgrof@kernel.org, Joel Stanley , mpe@ellerman.id.au, joe@perches.com, brakmo@fb.com, rostedt@goodmis.org, Tim.Bird@sony.com, khilman@baylibre.com, Julia Lawall , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Linux Kernel Mailing List , jdike@addtoit.com, richard@nod.at, linux-um@lists.infradead.org, Daniel Vetter , dri-devel@lists.freedesktop.org, Rob Herring , dan.j.williams@intel.com, linux-nvdimm@lists.01.org, kieran.bingham@ideasonboard.com References: <20181023235750.103146-1-brendanhiggins@google.com> From: Frank Rowand Message-ID: <04f677b1-bc44-f004-cf2a-51b47baf0965@gmail.com> Date: Wed, 7 Nov 2018 09:46:41 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/6/18 5:17 PM, Brendan Higgins wrote: > On Fri, Nov 2, 2018 at 11:23 AM Shuah Khan wrote: >> >> Hi Brendan, > >> Framework looks good. I think it would be helpful to include a real test > > Great to hear! > >> in the patch series to get a feel for how effective it is. > > Alright, will do. Rob suggested converting > https://elixir.bootlin.com/linux/v4.19/source/drivers/of/unittest.c to > KUnit, so that might offer a good comparison. drivers/of/unittest.c might be a bit bigger and more complex test than you want to start with. -Frank < snip >