Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <df9cdf1753ec7e6e20c12aa096b98453.squirrel@twosheds.infradead.org>
In-Reply-To: <20181107173303.slnb3i2d6ufaonp7@zorba>
References: <20181106214928.40020-1-nkela@cisco.com>
    <921b0f78cf67d7307a0555e1fd6f2c2976310adc.camel@infradead.org>
    <1e4c066d1896e2a0b8b146253d34d05cc4f9ab36.camel@infinera.com>
    <8b08e8b992093453bb2b9caff8cff08c.squirrel@twosheds.infradead.org>
    <20181107173303.slnb3i2d6ufaonp7@zorba>
Date:   Wed, 7 Nov 2018 17:58:53 -0000
Subject: Re: [PATCH] jffs2: implement mount option to configure endianness
From:   "David Woodhouse" <dwmw2@infradead.org>
To:     "Daniel Walker" <danielwa@cisco.com>
Cc:     "David Woodhouse" <dwmw2@infradead.org>,
        "Joakim Tjernlund" <joakim.tjernlund@infinera.com>,
        "nkela@cisco.com" <nkela@cisco.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        "xe-linux-external@cisco.com" <xe-linux-external@cisco.com>
User-Agent: SquirrelMail/1.4.22-21.fc27
MIME-Version: 1.0
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: 8bit
Importance: Normal
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On Wed, Nov 07, 2018 at 04:12:14PM -0000, David Woodhouse wrote:
>>
>> > Yes, this may slow things down. I am not sure I agree with the impl.
>> > either.
>> > Could one not make cpu_to_je_X/jeX_to_cpu a function ptr which is set
>> to
>> > a func. with the correct endian?
>>
>> On x86 retpoline would make that quite slow.
>
> Is x86 the largest consumer of jffs2 ?

Certainly not. I'm not sure which architectures do have Spectre V2
mitigations which make indirect branches expensive now... perhaps there is
no intersection with the cases where we really care about JFFS2 being
CPU-bound?


-- 
dwmw2