Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp91938imu; Wed, 7 Nov 2018 13:32:22 -0800 (PST) X-Google-Smtp-Source: AJdET5dAll6g+8Dl7NvuqbbxrcOCLD0JHlgwGJpOK34sVWbNZxDrzcbAyrBdWUDt4sy5NquHp2zJ X-Received: by 2002:a62:a218:: with SMTP id m24-v6mr1885811pff.99.1541626342433; Wed, 07 Nov 2018 13:32:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541626342; cv=none; d=google.com; s=arc-20160816; b=D8jpwTXd4g5jAHVuQvTs1x++oPrXBJSowwIJ8N0Yyhh4AQJsXuBBIR86B7RnEcySqd 78Nc+epUxkcfIMgG/4x9gz2kRatKAH3O0f7biSXblvXSGbpoV+Um0AbQDnjd66RW029V wD4I6iAk8wCKGvTPso14wPRXlwcKGHRUJx+PLL+Ozh1HOUBv05mWqS6xXvD883zkalLN KcG+lzE0LaOURY1B2AjEorNvzeGczPQ9rY8D5O/etlgfvpL6Bzd2N/cj22x8nNKIzbf6 Ipc6ouMgZTp1Of1Za7F22IjwlLQaWDlEUYvsaM3XgnF3nu1waMnAw9zJpzisuGZIJfQ9 eIig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:references :in-reply-to:subject:cc:to:from:date:content-transfer-encoding :mime-version:dkim-signature:dkim-signature; bh=SQ8BaLWBfe0yPdMa8DnZlTLVfjtcgkBjFbHC6TCz0og=; b=sGMUTgfa0dqYyC4j+pDQXKiIelECRdPnuPnB2CxDXlfCDM7UtwlqOrRb6owiJz2gXS M7p83ltf+kYo6zIHUXK5Sz2Xr1vy+LIkACa6IKvfSRX0sYB9s3lmHVAf3kz9uYPz9/n6 m6/YZuoK7GfODemtqrnqoT6QNFrulCDbO1LnflYSIpzMmKRa17k7/gT89BUbc/MCen8j WICxY3FpC1ks48xlvwSpwGMRgtJXtheMdBkgae9hImnDvyWtreeZ43UWVijTuQO6P0iK R7cytQ//unPklDCGRRw850hv5xZRwb2Wij9Tb9Dm9uvIcn+tHbivB26DsC6NxzC23+sZ GSxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=e7LIzGrF; dkim=pass header.i=@codeaurora.org header.s=default header.b=e7LIzGrF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o3-v6si1884621pld.329.2018.11.07.13.32.06; Wed, 07 Nov 2018 13:32:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=e7LIzGrF; dkim=pass header.i=@codeaurora.org header.s=default header.b=e7LIzGrF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727412AbeKHHCi (ORCPT + 99 others); Thu, 8 Nov 2018 02:02:38 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:38152 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726659AbeKHHCh (ORCPT ); Thu, 8 Nov 2018 02:02:37 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id A27D8605FD; Wed, 7 Nov 2018 21:30:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1541626223; bh=g6kMeXY0nWbdJh1+3VC20Sr5/Z/iTf+1TilbkUlMq50=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=e7LIzGrFrcB7hioLeSaxZlp4g9k4doqfexVHQuW8oQ25BhTilBAF7IAenvDudICbg KJKfWg3ojglltmuqlli7KaBt9/zHV35UAlBeQh6jhTT8MshcH0wU8AXKdAvtQu3vqu ZMCG0bt1Nco0RnwO+0KtPB0jIqBXDgtahuwEV2Ic= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 3AD62601DA; Wed, 7 Nov 2018 21:30:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1541626223; bh=g6kMeXY0nWbdJh1+3VC20Sr5/Z/iTf+1TilbkUlMq50=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=e7LIzGrFrcB7hioLeSaxZlp4g9k4doqfexVHQuW8oQ25BhTilBAF7IAenvDudICbg KJKfWg3ojglltmuqlli7KaBt9/zHV35UAlBeQh6jhTT8MshcH0wU8AXKdAvtQu3vqu ZMCG0bt1Nco0RnwO+0KtPB0jIqBXDgtahuwEV2Ic= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 07 Nov 2018 13:30:23 -0800 From: Rajkumar Manoharan To: Brian Norris Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Yu Wang , Rakesh Pillai , Govind Singh , stable@vger.kernel.org, linux-wireless-owner@vger.kernel.org Subject: Re: [PATCH REGRESSION] Revert "ath10k: add quiet mode support for QCA6174/QCA9377" In-Reply-To: <20181107185643.240346-1-briannorris@chromium.org> References: <20181107185643.240346-1-briannorris@chromium.org> Message-ID: <7f2ef494f4a2aba1845a157da8fec449@codeaurora.org> X-Sender: rmanohar@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-11-07 10:56, Brian Norris wrote: > This reverts commit cfb353c0dc058bc1619cc226d3cbbda1f360bdd3. > > WCN3990 firmware does not yet implement this feature, and so it crashes > like this: > > fatal error received: err_qdi.c:456:EX:wlan_process:1:WLAN > RT:207a:PC=b001b4f0 > > This feature can be re-implemented with a proper service bitmap or > other > feature-discovery mechanism in the future. But it should not break > working boards. > Brian, The change "ath10k: add quiet mode support for QCA6174/QCA9377" was merged even before full WCN3990 device support was added in ath10k. How come it could be regression for WCN3990. I know both are sharing same WMI-TLV interface but reverting this will break QCA6174/QCA9377. no? I would prefer to handle this within WMI callback or upper layer. -Rajkumar