Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <CAOesGMi-vkYPDrL2drJ70zf3_xTMWrsfPoW68TkiRJCj8uWBLg@mail.gmail.com>
 <20181107144516.4587-1-aryabinin@virtuozzo.com> <20181107125517.b5677f03a9a1978a5d179c9a@linux-foundation.org>
In-Reply-To: <20181107125517.b5677f03a9a1978a5d179c9a@linux-foundation.org>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Wed, 7 Nov 2018 22:44:46 +0100
Message-ID: <CAK8P3a23=C7joXFNr6P-1ap7Fkpz=umTAtHBH++YJ5VNC7AzzQ@mail.gmail.com>
Subject: Re: [PATCH v2] ubsan: don't mark __ubsan_handle_builtin_unreachable
 as noreturn
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Andrey Ryabinin <aryabinin@virtuozzo.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Olof Johansson <olof@lixom.net>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Nov 7, 2018 at 9:55 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Wed,  7 Nov 2018 17:45:16 +0300 Andrey Ryabinin <aryabinin@virtuozzo.com> wrote:
>
> > From: Arnd Bergmann <arnd@arndb.de>

> > --- a/lib/ubsan.c
> > +++ b/lib/ubsan.c
> > @@ -427,8 +427,7 @@ void __ubsan_handle_shift_out_of_bounds(struct shift_out_of_bounds_data *data,
> >  EXPORT_SYMBOL(__ubsan_handle_shift_out_of_bounds);
> >
> >
> > -void __noreturn
> > -__ubsan_handle_builtin_unreachable(struct unreachable_data *data)
> > +void __ubsan_handle_builtin_unreachable(struct unreachable_data *data)
> >  {
> >       unsigned long flags;
>
> This code has been here since 2016 and presumably people will want to
> build older kernels with newer gcc's.  So I'll add cc:stable, OK?
>

Yes, sounds good. Thanks,

      arnd