Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp81859imu; Wed, 7 Nov 2018 21:14:52 -0800 (PST) X-Google-Smtp-Source: AJdET5dJ1dkFjb0TyVZq/QGVrQYtVieqpKJmC8upWWC8w52zOPr1qFKdXyelV6DwqH5Zk5M93Hgd X-Received: by 2002:aa7:80cd:: with SMTP id a13-v6mr3183305pfn.86.1541654092446; Wed, 07 Nov 2018 21:14:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541654092; cv=none; d=google.com; s=arc-20160816; b=UuAgDdSFG06uFbQ7Zv1jRP715DHMWH2uGHkgJVhRKsZpD+l82k0K337SRIEjc5nFeZ yvJTmuk6S56wEmbkBGQiws+kzZtRBXfTclHP2L870j+/YTlVUr+NVbEsN6n+e90aVGX1 rnncAvrKXLsL2B/2kQFH1ynM+WY7z7kWVet/ztxXNpbD7aA6wH0CqhDaXFwDOMf040IE iczM/x/ShkPaCeyRrLXT9kvKoNcgwheJSFBK5t8xGQ96lwJp/LpXxRkTRVIBW5PrCp+x o/VPq+WMwv8faEAfhG7obbLe7TelBLmI6szcdA4ZCVsrWdn4gCtUAEPZKUlZD7bkRvHk CA5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=ChRWLVc8ljv0whe/NJ3ht6j2NoLKg5tp0PAAYBgBLYs=; b=YxCwNHjRknE/tZO/jTzjTqXEcmeytr3IakjREusN8JVeJrusQMk4mTkCd1cRcTp6Nq BQTlhjLokeqxBcs69uvD/KIfL1e+GoRc7iK36ugz6/akPWrs+n5m/qQ3/nssg/ByAWpn lSEKgQNF/7tXhuKaps9BqbbevWv7kwUFuHi5HH6voHlXjzJ0e75oNhJH2btfNtDeDIxW xsYR1iRGuSqizK591xIhWCRCN9YRJujfm/0xxtzdTV2GdV9EQtozVMdVMfvHxopzzU3j IFxAz3XQe+GCGbc3O01VSyXYSlyhgOYVmN0rxgrdV9qLjmFFlkgXwANMI30h/EtUJZOq 3wFA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 63-v6si3079686pfe.182.2018.11.07.21.14.37; Wed, 07 Nov 2018 21:14:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729014AbeKHOoJ (ORCPT + 99 others); Thu, 8 Nov 2018 09:44:09 -0500 Received: from smtp2.provo.novell.com ([137.65.250.81]:45309 "EHLO smtp2.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728965AbeKHOoI (ORCPT ); Thu, 8 Nov 2018 09:44:08 -0500 Received: from linux-r8p5.suse.de (prv-ext-foundry1int.gns.novell.com [137.65.251.240]) by smtp2.provo.novell.com with ESMTP (TLS encrypted); Wed, 07 Nov 2018 22:10:20 -0700 From: Davidlohr Bueso To: akpm@linux-foundation.org Cc: jbaron@akamai.com, viro@zeniv.linux.org.uk, dave@stgolabs.net, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Davidlohr Bueso Subject: [PATCH 4/6] fs/epoll: robustify ep->mtx held checks Date: Wed, 7 Nov 2018 21:10:04 -0800 Message-Id: <20181108051006.18751-5-dave@stgolabs.net> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20181108051006.18751-1-dave@stgolabs.net> References: <20181108051006.18751-1-dave@stgolabs.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Insted of just commenting how important it is, lets make it more robust and add a lockdep_assert_held() call. Signed-off-by: Davidlohr Bueso --- fs/eventpoll.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/eventpoll.c b/fs/eventpoll.c index 347da3f4f5d3..6a0c2591e57e 100644 --- a/fs/eventpoll.c +++ b/fs/eventpoll.c @@ -1637,6 +1637,8 @@ static __poll_t ep_send_events_proc(struct eventpoll *ep, struct list_head *head * Items cannot vanish during the loop because ep_scan_ready_list() is * holding "mtx" during this call. */ + lockdep_assert_held(&ep->mtx); + list_for_each_entry_safe(epi, tmp, head, rdllink) { if (esed->res >= esed->maxevents) break; -- 2.16.4