Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp131866imu; Wed, 7 Nov 2018 22:28:21 -0800 (PST) X-Google-Smtp-Source: AJdET5drcoI1fwkhPbfGEykaQU4TeA7i41T9or+YrisxQNYY0l9MBMVQvcRy93rb3Kx35Ea7VwPa X-Received: by 2002:a62:500c:: with SMTP id e12-v6mr3448793pfb.30.1541658501150; Wed, 07 Nov 2018 22:28:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541658501; cv=none; d=google.com; s=arc-20160816; b=IT4zELDFdb+CKau4F0WA2iFEIeh+DavO5Lns1UGCJnwJ4IXE+ApBeJ7J8KnLwoptfL 0OmV8eypSpEsZEnj8dhnX24C7HNutZZMrEX8OkTXsVS1vbM8CuoMfUL0glO90u5DUglQ qLev9JwiNhmP7Yuqy2mVdNXGYsH5nVb9vNwIaMGnHxv8YcTpW3JNxENTAJ4SkOQ4BoHn pBmqVunl9nZZIDOpl7rdVzUBoOaRWe5oP0eFmmHIjw2F8RMhKeyJhkfnr3C3CA96Dowx ljtpVUaDOlRD4+SQZr1LD7YxOwlpkCqFhJ1UCQ5MgzWY9mgUj88LgpQ/W1xiTU1fKS/k qBHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=Fee30CerGgivVMDpidVLv4hkTlGRlYvzS20itoPYKs0=; b=IekKNwUsLeuTtuV6RtUmSdM0FDqQN0pRTNU35JBLOR1BbYt+xqI4RHTWKiwsxdSwQ7 L5zlcH9etnUbJcV+rHruqimjytpLOuVAWIuQwXSX0++B0FmL4HUOqudYsNS+hRcem0Un e5sg7euMEen+AX+XpPnaOgun36Xu8K651UtunBKTnwFBly/OWWGAOtBLWkWIyqYFQCY1 NiZQJju6QunmDyEqKhUnKwxH3UW+SAKphPEgOdzNMJFS+8LzfYby4hihNgVuz5txRGzG cJtQdtA5pFrS5F+mXBiKu4c6KvIIbxFdrd/uUc2ujCfagnCKgU1qC89rWmv5ZmBYU0J6 aYFA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b22-v6si3582153pff.192.2018.11.07.22.28.05; Wed, 07 Nov 2018 22:28:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726342AbeKHQBk (ORCPT + 99 others); Thu, 8 Nov 2018 11:01:40 -0500 Received: from mx2.suse.de ([195.135.220.15]:50524 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725972AbeKHQBk (ORCPT ); Thu, 8 Nov 2018 11:01:40 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id BE973AFD0; Thu, 8 Nov 2018 06:27:43 +0000 (UTC) Date: Wed, 7 Nov 2018 22:27:36 -0800 From: Davidlohr Bueso To: "chouryzhou(??????)" Cc: "gregkh@linuxfoundation.org" , "arve@android.com" , "tkjos@android.com" , "akpm@linux-foundation.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V2] binder: ipc namespace support for android binder Message-ID: <20181108062736.bbns35o6fnm4zsw4@linux-r8p5> References: <5FBCBE569E134E4CA167B91C0A77FD610198F6BB7D@EXMBX-SZMAIL022.tencent.com> <20181108062143.7web34burq62gefu@linux-r8p5> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20181108062143.7web34burq62gefu@linux-r8p5> User-Agent: NeoMutt/20180323 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 07 Nov 2018, Bueso wrote: >On Mon, 29 Oct 2018, chouryzhou(??????) wrote: > >>+// If init_ipc_ns is not defined elsewhere, >>+// we make a fake one here to put our variable. > >/* >* comments like this please >*/ Actually, just drop the comment altogether. Forward declaring does not merit it. Thanks, Davidlohr