Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp260009imu; Thu, 8 Nov 2018 01:11:29 -0800 (PST) X-Google-Smtp-Source: AJdET5fIm8a2MFiVWF6+fyuV8YqD2VrbiAojRFDE/CFhSsb/bk1TG9RJ8vvgRA32CafVhk8EDlud X-Received: by 2002:a17:902:c7:: with SMTP id a65-v6mr3845442pla.296.1541668289883; Thu, 08 Nov 2018 01:11:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541668289; cv=none; d=google.com; s=arc-20160816; b=xtFsPf+4zXiTqxOKCcIDPrf+jtNwbUVGp+ZY+VVzT4aJK1jvfRxwXZnav+SLWah0Sl YwJmGpaSq1sDZYDhVbows7uRPEIBHWPcdvv1h4ybtH2A61XhwtWPobta4cQhOgdJuWoQ tk+b+TJLhAR2AMbBi2hpSeUJ1fX87ktmNQOTYWUMLRBVvWIyh/9rN5hW029Lez4nUgDJ DZ6ioyYK6U3DjNPoxH2enlH3bjqwnAmrXC/bS/KnC+rzSfseJR/cf+tfSHILm6rGeDQE FByf99bX5YnDgxhXSCvFTCvXCjyXTGEvD7yYbHDQfeOm1QfpcJMZcD8HFjbEc4hHmgSv hVqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject; bh=PHieii8q1P1nc5hYHbhUpnN41MV1RDeGw4R1OAqZse0=; b=hqlYU3rxZMRHK+Rg6LpFMwMBFdhOE3qVWwpzuUSj9s5sqQMataJAv+HKgxIWxo9rGs JVTL8fb6sSA33e1jYqwzRXjQIZtcMPzcL62i2w5gwOqh6bLNs4uybzJN+iHWHoGBoCec /pxVA+rLjtd1/wPotUp9WvM6+/kmT8A12m9qE9d17T0UzM/cZp7HT0j+b/xmbXy7zpa+ 7SRqWPmPVSKzcablUQ7h7VZPjuOS4w0g0roMPgYiis3NIMQ4w22UsPO+akLdE5gYNk0E 3xE6JNuDhPP/Y9ib0l1WyW38FrCoV9wiwXREfD29AbSpvwLcV5IFO2VXaFvBs2SfXXmm CPYg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i11-v6si3252811pgk.29.2018.11.08.01.11.14; Thu, 08 Nov 2018 01:11:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726708AbeKHSpT (ORCPT + 99 others); Thu, 8 Nov 2018 13:45:19 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:54773 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726145AbeKHSpS (ORCPT ); Thu, 8 Nov 2018 13:45:18 -0500 Received: from 1.general.cking.uk.vpn ([10.172.193.212]) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1gKgKr-0004Ho-8n; Thu, 08 Nov 2018 09:10:45 +0000 Subject: Re: [PATCH][i3c-next] i3c: fix incorrect update to max_read_ds To: Boris Brezillon Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20181107204208.7411-1-colin.king@canonical.com> <20181108100924.2381e9f0@bbrezillon> From: Colin Ian King Openpgp: preference=signencrypt Autocrypt: addr=colin.king@canonical.com; prefer-encrypt=mutual; keydata= xsFNBE6TJCgBEACo6nMNvy06zNKj5tiwDsXXS+LhT+LwtEsy9EnraKYXAf2xwazcICSjX06e fanlyhB0figzQO0n/tP7BcfMVNG7n1+DC71mSyRK1ZERcG1523ajvdZOxbBCTvTitYOy3bjs +LXKqeVMhK3mRvdTjjmVpWnWqJ1LL+Hn12ysDVVfkbtuIm2NoaSEC8Ae8LSSyCMecd22d9Pn LR4UeFgrWEkQsqROq6ZDJT9pBLGe1ZS0pVGhkRyBP9GP65oPev39SmfAx9R92SYJygCy0pPv BMWKvEZS/7bpetPNx6l2xu9UvwoeEbpzUvH26PHO3DDAv0ynJugPCoxlGPVf3zcfGQxy3oty dNTWkP6Wh3Q85m+AlifgKZudjZLrO6c+fAw/jFu1UMjNuyhgShtFU7NvEzL3RqzFf9O1qM2m uj83IeFQ1FZ65QAiCdTa3npz1vHc7N4uEQBUxyXgXfCI+A5yDnjHwzU0Y3RYS52TA3nfa08y LGPLTf5wyAREkFYou20vh5vRvPASoXx6auVf1MuxokDShVhxLpryBnlKCobs4voxN54BUO7m zuERXN8kadsxGFzItAyfKYzEiJrpUB1yhm78AecDyiPlMjl99xXk0zs9lcKriaByVUv/NsyJ FQj/kmdxox3XHi9K29kopFszm1tFiDwCFr/xumbZcMY17Yi2bQARAQABzSJDb2xpbiBLaW5n IDxjb2xpbi5raW5nQHVidW50dS5jb20+wsF3BBMBCAAhBQJPCrjvAhsDBQsJCAcDBRUKCQgL BRYCAwEAAh4BAheAAAoJEGjCh9/GqAImjVsP/iA8hDQy7LlMYepND9tKJD2haNLmsBC+yuxX BybYprtSjwvMbx6CtmtiJ4nGfdBzbZv3xOJPr/n6wxrdfGHEFn0W8Au97Xvk087P7alCwBXz y1Hk1aTlhLOGunOLv6SWRYRUAHvWEoVlxPSo2UNJ6D01d9tc7IJU08MlAl+u048S6625G5SG tfOJpFyGqaWGazMpkYdbJuY9acNAQAl1GzZPDCyLrxaBJypqmp3W+rb7m9arNRMlygevFU6e UGrR7QiVuumTGebGF9D63H9LD0E/1EhOA4QWHq1/u7CXLr9qo1YyAUtYAICs0wyRbI6wWPyi 5IyOTiWCVP3qSxV4JR8qq8JhGEwxS5fEB76r+XGxcL7qqiQmVx3bkjlT6FnnanPcD7RsMOAg NcpeftVsqignFPA3XHaDeew4t99ef+wKwiiyU7jqduvSt8amLVip5dxN1TYKqWPauIHL3E2A KIKuqsZ9ftUJ3NXClAfI3EHPMYbok6b04nZSWmBttKHr8YkVF5b4jrabMLlVoCg+DGYffyDS YDwy9FPvJWkt6nffUXciearieSlHEt3f12CPp6OOR8yFZWlISYKdD9PDzXP9kJYTEWnr7dD3 feEZK+J9N5wpCU7HvfrA5HCOMJgf8Dcfscrj9H2Qp8vbErMP7jZ6OYapCOV5MZS6W57wlG2k zsFNBE6TJCgBEADF+hz+c0qF0R58DwiM8M/PopzFu5ietBpl0jUzglaKhMZKKW7lAr4pzeE4 PgJ4ZwQd0dSkx63hRqM963Fe35iXrreglpwZxgbbGluRJpoeoGWzuUpXE6Ze0A2nICFLk79a YHsFRwnKyol9M0AyZHCvBXi1HAdj17iXerCYN/ZILD5SO0dDiQl570/1Rp3d1z0l16DuCnK+ X3I7GT8Z9B3WAr6KCRiP0Grvopjxwkj4Z191mP/auf1qpWPXEAPLVAvu5oM7dlTIxX7dYa6f wlcm1uobZvmtXeDEuHJ3TkbFgRHrZwuh50GMLguG1QjhIPXlzE7/PBQszh5zGxPj8cR81txs 6K/0GGRnIrPhCIlOoTU8L+BenxZF31uutdScHw1EAgB6AsRdwdd8a9AR+XdhHGzQel8kGyBp 4MA7508ih0L9+MBPuCrSsccjwV9+mfsTszrbZosIhVpBaeHNrUMphwFe9HbGUwQeS6tOr+py bOtNUHeiJ5aU3Npo3eZkWVGePP2O4vr8rjVQ1xZMIWA18xUaLTvVSarV7/IqjLb0uMTz6Ng7 SceqjsgxO4J35pPOCG8gy85Tmd5NKe46K1xGsNG2zzfXQ6cNkofUyQFGVbLCtdfQyWV7+dgU nOnPhrTKpFfJ5lnWpLpze0LfyW03CpWx9x4yMlwcvIFw2hLaOQARAQABwsFfBBgBCAAJBQJO kyQoAhsMAAoJEGjCh9/GqAImeJYP/jdppMeb7AZnLGVXd8rN7CLBtfMOkXCWaOUhjMRAY7dV IMiF1iPZc6SgiiMSsdG7JJhMjMuLTxA0kX2Z6P0+6dZlO4bDOKMIv4nNGhgSj9NuSKJPRiyi XKKD/wNnPXVFdBZsoHnEXGyAFGnidu4KLUJIiSm4tHJdoMk0ZaJSmwt0dtytuC1IWH8eIaVo /Ah6FxCaznRzvGNFx+9Ofcc7+aMZ15dkg9XagOuiDZ1/r6VuEw9ovnkDT4H5BAsysxo/qykX 4XQ2RQSY/P3td9WNLeXLvt1aJNRcwcIEKgZ5AO3YQbEJt1dEfCU7TAKiRpsjnC/iQiQHGt2I vNci8oZmM3EQEi7yZqD07A6dpGTnRq9OQ7fGhj0SS99yZvooH3fBIHA2LRuvhfDAgTrpbU0w LvkAIo0T2b9SoRCV8FEpHvR2b86NbTU5WN4eqZQbAbnxC7tJp6kLx2Zn2uQMvfXRfnS9R1ja etvpk3h7F+r/RAAh+EvgsPUNaiRJRRLvf9bxTQZhmNrw79eIFNsRIktniLyomJf2+WPOUECz h1lfLqe9yiuUKv+m5uAalXdayhiPbp/JHs1EDRgSq3tiirOsKrh/KMpwz/22qGMRBjFwYBhf 6ozgujmPlO5DVFtzfwOydzNlXTky7t4VU8yTGXZTJprIO+Gs72Q1e+XVIoKl3MIx Message-ID: <38ffc3d2-4390-29df-203a-58fbe04fdc81@canonical.com> Date: Thu, 8 Nov 2018 09:10:44 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181108100924.2381e9f0@bbrezillon> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/11/2018 09:09, Boris Brezillon wrote: > On Wed, 7 Nov 2018 20:42:08 +0000 > Hi Colin, > > Colin King wrote: > >> From: Colin Ian King >> >> Currently max_read_ds is being updated twice, which is incorrect. >> The second assignment should be to max_write_ds instead. Fix this. >> >> Detected by CoverityScan, CID#1475379 ("Unused value") >> >> Fixes: 50cacdabeae1 ("i3c: Add core I3C infrastructure") >> Signed-off-by: Colin Ian King >> --- >> drivers/i3c/master.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c >> index 68d6553dbd75..0ea7bb045fad 100644 >> --- a/drivers/i3c/master.c >> +++ b/drivers/i3c/master.c >> @@ -1093,7 +1093,7 @@ static int i3c_master_getmxds_locked(struct i3c_master_controller *master, >> } >> >> info->max_read_ds = getmaxds->maxrd; >> - info->max_read_ds = getmaxds->maxwr; >> + info->max_write_ds = getmaxds->maxwr; > > Thanks for the fix. > > Since the I3C driver is not merged yet, would you mind if I squash your > changes in the commit introducing the bug? Sure, that's fine with me. Colin > > Regards, > > Boris >