Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp354574imu; Thu, 8 Nov 2018 03:07:26 -0800 (PST) X-Google-Smtp-Source: AJdET5fsr616umlnUBsvjG0ijsifOHrWGvNW0ZVIYXH8oTiFciFlw62KP4yMdLiGgFq4XC4ZGybk X-Received: by 2002:a65:64d5:: with SMTP id t21-v6mr3526278pgv.428.1541675246345; Thu, 08 Nov 2018 03:07:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541675246; cv=none; d=google.com; s=arc-20160816; b=MJDvRUXPMLX+6+a0boEhFw2VeBUvnJkG0FDDtFbn7k3q5udn4vo9A0pyxrebHXqo+5 A890hpkwdxPqeU//Ud8rOODRuODD8TwId1iykW/h1h1r1hebCHit9Vb05ePUVxQ6RFYL CQod7NdgGZ0jUFneWi7OU2NhJ/8uoshV3+O4/Imtn99iSQ5XGZd5EfwLtQEpTQn/H/WG IsY6n6dj9l/37XncyQq6nFA868RmoNSZeJkDpPbKzcflWsbFpASNxQ9/f2V6dPVBtjI9 cPNBkeHR1B16S1BtJNssypkAwb8Js563F7gA4nltmmlbmYj0qYeFH8mSFAQrnRM7ht6L jWKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=yQN16AXpg2b9lL0N1lNJmpMMdXV/0a0CIBZK3dVsC6A=; b=ekooQO7eGCl2rL4OkyP4/jLB11igydA2TK7jP56f+ykK46ASIiGjDDu0065IIdFNAI vxG7/0dZMgpCFHgUCBEQgWrTU2g25gVRerV33sflshSDy2QfXdXRdT48v7v6oQaPqjuj kiYiFsEaGpx9+CjSS6mv9qcW3t7BxkDRWYFOqqs0dCO2/UBeJvqQChS6edrPAUZVHU45 shKBCqhIlANtr0dMdFdPfGk3Iyp0PLKvLg7KjYd9QEvp7aYfMVXKIgvH3sb3s3VY24pq +xW0qqVFNvHf7XzofBFHrJCsSpgqnsSpkVfNvXloVEAg7ZXOwoDARQhL4rTTkh0HNSxX Zf1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=CcRwaZxF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p3-v6si3911358pff.272.2018.11.08.03.07.10; Thu, 08 Nov 2018 03:07:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=CcRwaZxF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727175AbeKHUln (ORCPT + 99 others); Thu, 8 Nov 2018 15:41:43 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:55978 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726721AbeKHUln (ORCPT ); Thu, 8 Nov 2018 15:41:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=yQN16AXpg2b9lL0N1lNJmpMMdXV/0a0CIBZK3dVsC6A=; b=CcRwaZxFym7E3FjbedCQFHgHAd oqli4lD2dbKHlPob4aESEs4Hbemg24orKQMYZjnSRjctF1fUALm5CkqfChIxEPKA0iytn6VXXkscD rVP9WGEAYrZ7NnZeYk3TPSZw51gWjyo0W8688qEHoZt1WZ1OChJCUuD7IILVe7Jf3nMjhZuQ2iJBd Xe288UWxi/hpsjmXTt7WmcbW1BC5uD0/lwnpSxrzoJIQSFcetmoBbLgB+4MvNFNVGTmfu054RTOkH 6G3UZdME/0jA1EwO/7ZmD9/Qr93uTBNeuWQPYgNHYuatqwjVWtbXITOQn4lsS+Eo144RzZregh8hA wpUdkb/w==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gKhh3-0005ZT-MJ; Thu, 08 Nov 2018 10:37:45 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id D2B832029F881; Thu, 8 Nov 2018 11:37:43 +0100 (CET) Date: Thu, 8 Nov 2018 11:37:43 +0100 From: Peter Zijlstra To: Yi Wang Cc: mingo@redhat.com, linux-kernel@vger.kernel.org, zhong.weidong@zte.com.cn Subject: Re: [PATCH] sched/fair: make some function static Message-ID: <20181108103743.GQ9761@hirez.programming.kicks-ass.net> References: <1541656452-3326-1-git-send-email-wang.yi59@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1541656452-3326-1-git-send-email-wang.yi59@zte.com.cn> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 08, 2018 at 01:54:12PM +0800, Yi Wang wrote: > Make some function static as they are not used outside of fair.c. > > This fixes the following warning when building with 'W=1': > > kernel/sched/fair.c:2439:6: warning: no previous prototype for ‘task_numa_work’ [-Wmissing-prototypes] > kernel/sched/fair.c:2584:6: warning: no previous prototype for ‘task_tick_numa’ [-Wmissing-prototypes] > kernel/sched/fair.c:3548:6: warning: no previous prototype for ‘sync_entity_load_avg’ [-Wmissing-prototypes] > kernel/sched/fair.c:3561:6: warning: no previous prototype for ‘remove_entity_load_avg’ [-Wmissing-prototypes] > > Signed-off-by: Yi Wang I'm not sure why; but when I apply I get: $ quilt push Applying patch patches/yi_wang-sched_fair-make_some_function_static.patch patching file kernel/sched/fair.c Hunk #1 FAILED at 2436. Hunk #2 FAILED at 2581. Hunk #3 FAILED at 3545. Hunk #4 FAILED at 3558. 4 out of 4 hunks FAILED -- rejects in file kernel/sched/fair.c Patch patches/yi_wang-sched_fair-make_some_function_static.patch does not apply (enforce with -f)D