Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp208178imu; Thu, 8 Nov 2018 07:13:59 -0800 (PST) X-Google-Smtp-Source: AJdET5dJN9nFJ037XVeF4eRKvQIugt8E/LKZBFEcS/rRCTe7CZmLRcCsuSFJdbewbmZ9FGzscq+0 X-Received: by 2002:a17:902:3a3:: with SMTP id d32-v6mr4949172pld.304.1541690039789; Thu, 08 Nov 2018 07:13:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541690039; cv=none; d=google.com; s=arc-20160816; b=tqj5L3WDFCc3SqO4NU3tNMFQsfAvo6cF6+yIIuRtaayqxzpnz0cKaF00ACmNG2Lfla jE15v9d21wEZIl8LHnra2WVfgZPkePYNu13G/XtKQZx74jd3DpsyWLFand9/Ut4nKjjN eaRrQPGGYdCfHGUYX7x39HCaGhpY1wVQTGEnu6Fnb06mFL1TL/bNJ6G+FaD3dg5VqLim OSYbJUDUZ9RAdXxSTWlFkVC8uab9tsMO6g0iy6sWd3A2Rr07IAqpIR6UP8/DMG+mLdbv C6vxx8maCePgMW+dnT/p1/A0oCB4FhanADYX9m7BkilN60WCc0dKSxgq5vCWAMz8E0bd AAxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=kehTcWrdKBRzre6NSRnKwNg5i/pV8p1rLXT1GQPQhEI=; b=MyOLyqAhPk2zZEihdczWM8LFq/NnMChpyi9y3cOdekckVxaexvPAoMdHMLTFO9yJo8 AWhsyHm/FHy6eoWdcZOmDswTuz4uUCapQWqdojFv4NQN0R9pjL9yUIkNdmw1enE/2KYR IzoruFlm6XsMQZR7Mpm+SNUj1JSe4eufgX1AayiiYOlC61gX50ZzBDQMIAhmeE2WaKMz gQpjMgZxI/ApMKaCi0nvFV/yTpxlKOLA4jCsiid10/5Ac2RxlFA/EV67uUk/B6YIVNfQ LtrvqxKEnnwVGL7EyJOpsxVwvVLbdmj428uWiMXjHX5gxd/uJ/w1lO5vAilUS9eO7d5a j87w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vRSl7DB7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c14-v6si3884249pgi.431.2018.11.08.07.13.43; Thu, 08 Nov 2018 07:13:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vRSl7DB7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726980AbeKIAtO (ORCPT + 99 others); Thu, 8 Nov 2018 19:49:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:56354 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726421AbeKIAtO (ORCPT ); Thu, 8 Nov 2018 19:49:14 -0500 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4850A2089F; Thu, 8 Nov 2018 15:13:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1541689996; bh=l0pH0CRRubrydYQY5QJqo5Im3s531cxPhyV+ZM/Li8Y=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=vRSl7DB7O7rgDXPeHHDDbOuFMWmPBrV1Bh4LwOBLrZiYFFB7edIwvqizAb0Ys92Hz d4p0ADqYeKKmSUlA2RZ2R/7IOIDEnDcypSfrTBLrsZC4FmCui6ZAQmEVeQ/JrIvHjB UE2K4H57v5JHuSwUDDiIyhPWhqmD3P0HgVulEnZY= Received: by mail-qk1-f175.google.com with SMTP id o125so27017173qkf.3; Thu, 08 Nov 2018 07:13:16 -0800 (PST) X-Gm-Message-State: AGRZ1gIwPxaAQBQIgpmpiTo3oPFzu+AsPZCVhrSe6QkuM2pGAW5oNaMO h7oswva4l2L2Heqohd5hkBZOrm4aTMZ9iD+apg== X-Received: by 2002:a37:9201:: with SMTP id u1-v6mr4200513qkd.29.1541689995369; Thu, 08 Nov 2018 07:13:15 -0800 (PST) MIME-Version: 1.0 References: <1541542052-10081-1-git-send-email-jacek.anaszewski@gmail.com> <1541542052-10081-4-git-send-email-jacek.anaszewski@gmail.com> In-Reply-To: <1541542052-10081-4-git-send-email-jacek.anaszewski@gmail.com> From: Rob Herring Date: Thu, 8 Nov 2018 09:13:03 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 03/24] leds: dt-bindings: Add LED_FUNCTION definitions To: Jacek Anaszewski Cc: Linux LED Subsystem , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Pavel Machek , Baolin Wang , Daniel Mack , Dan Murphy , Linus Walleij , Oleh Kravchenko , Sakari Ailus , Simon Shields , xiaotong.lu@spreadtrum.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 6, 2018 at 4:07 PM Jacek Anaszewski wrote: > > Add common LED function definitions for use in Device Tree. > The function names were extracted from existing dts files > after eliminating oddities. > > Signed-off-by: Jacek Anaszewski > Cc: Baolin Wang > Cc: Daniel Mack > Cc: Dan Murphy > Cc: Linus Walleij > Cc: Oleh Kravchenko > Cc: Sakari Ailus > Cc: Simon Shields > Cc: Xiaotong Lu > --- > include/dt-bindings/leds/functions.h | 101 +++++++++++++++++++++++++++++++++++ > 1 file changed, 101 insertions(+) > create mode 100644 include/dt-bindings/leds/functions.h > > diff --git a/include/dt-bindings/leds/functions.h b/include/dt-bindings/leds/functions.h > new file mode 100644 > index 0000000..3f94e09 > --- /dev/null > +++ b/include/dt-bindings/leds/functions.h > @@ -0,0 +1,101 @@ > +// SPDX-License-Identifier: GPL-2.0 > + > +#define LED_FUNCTION_2G "2g" > +#define LED_FUNCTION_ACTIVITY "activity" > +#define LED_FUNCTION_ADSL "adsl" > +#define LED_FUNCTION_ALARM "alarm" > +#define LED_FUNCTION_ALIVE "alive" > +#define LED_FUNCTION_ALL "all" > +#define LED_FUNCTION_APP "app" > +#define LED_FUNCTION_AUX "aux" > +#define LED_FUNCTION_BACKUP "backup" > +#define LED_FUNCTION_BACKLIGHT "backlight" > +#define LED_FUNCTION_BACKLIGHT_CLUSTER "backlight_cluster" I'd prefer we go further and only define 1 endorsed function name. Backlight, disk, network, fault/error all seem to have a few duplicates. I'm also thinking the functions make linux,default-trigger redundant in some cases. I'm not a huge fan of making these defines, but it does make it perfectly clear if folks use standard names or not. > +#define LED_FUNCTION_BEEP "beep" > +#define LED_FUNCTION_BLUETOOTH "bluetooth" > +#define LED_FUNCTION_BOOT "boot" > +#define LED_FUNCTION_BOTTOM "bottom" > +#define LED_FUNCTION_BRICK_STATUS "brick-status" > +#define LED_FUNCTION_CEL "cel" > +#define LED_FUNCTION_CEL_PWR "cel-pwr" > +#define LED_FUNCTION_CEL_RESET "cel-reset" > +#define LED_FUNCTION_CHRG "chrg" > +#define LED_FUNCTION_COM "com" > +#define LED_FUNCTION_COPY "copy" > +#define LED_FUNCTION_CPU "cpu" > +#define LED_FUNCTION_DEBUG "debug" > +#define LED_FUNCTION_DIA "dia" > +#define LED_FUNCTION_DISK "disk" > +#define LED_FUNCTION_DISPLAY_CLUSTER "display_cluster" > +#define LED_FUNCTION_DOWN "down" > +#define LED_FUNCTION_DSL "dsl" > +#define LED_FUNCTION_ENOCEAN "enocean" > +#define LED_FUNCTION_ENTER "enter" > +#define LED_FUNCTION_ERROR "error" > +#define LED_FUNCTION_ESATA "esata" > +#define LED_FUNCTION_ETHERNET_STATUS "ethernet-status" > +#define LED_FUNCTION_FAIL "fail" > +#define LED_FUNCTION_FAULT "fault" > +#define LED_FUNCTION_FLASH "flash" > +#define LED_FUNCTION_FRONT "front" > +#define LED_FUNCTION_FUNC "func" > +#define LED_FUNCTION_GPIO "gpio" > +#define LED_FUNCTION_GSM "gsm" > +#define LED_FUNCTION_HD "hd" > +#define LED_FUNCTION_HDD "hdd" > +#define LED_FUNCTION_HDDERR "hdderr" > +#define LED_FUNCTION_HEALTH "health" > +#define LED_FUNCTION_HEARTBEAT "heartbeat" > +#define LED_FUNCTION_HOME "home" > +#define LED_FUNCTION_INDICATOR "indicator" > +#define LED_FUNCTION_INET "inet" > +#define LED_FUNCTION_INFO "info" > +#define LED_FUNCTION_INTERNET "internet" > +#define LED_FUNCTION_KEYPAD "keypad" > +#define LED_FUNCTION_LAN "lan" > +#define LED_FUNCTION_LEFT "left" > +#define LED_FUNCTION_LIVE "live" > +#define LED_FUNCTION_MICROSD "microsd" > +#define LED_FUNCTION_MISC "misc" > +#define LED_FUNCTION_MMC "mmc" > +#define LED_FUNCTION_NAND "nand" > +#define LED_FUNCTION_NETWORK "network" > +#define LED_FUNCTION_ON "on" > +#define LED_FUNCTION_OS "os" > +#define LED_FUNCTION_PANEL "panel" > +#define LED_FUNCTION_PMU_STAT "pmu_stat" > +#define LED_FUNCTION_PROG "prog" > +#define LED_FUNCTION_PROGRAMMING "programming" > +#define LED_FUNCTION_PULSE "pulse" > +#define LED_FUNCTION_PWR "pwr" > +#define LED_FUNCTION_QSS "qss" > +#define LED_FUNCTION_REAR "rear" > +#define LED_FUNCTION_REBUILD "rebuild" > +#define LED_FUNCTION_RIGHT "right" > +#define LED_FUNCTION_ROUTER "router" > +#define LED_FUNCTION_RS "rs" > +#define LED_FUNCTION_RX "rx" > +#define LED_FUNCTION_SATA "sata" > +#define LED_FUNCTION_SD "sd" > +#define LED_FUNCTION_SLEEP "sleep" > +#define LED_FUNCTION_STANDBY "standby" > +#define LED_FUNCTION_STATUS "status" > +#define LED_FUNCTION_SW "sw" > +#define LED_FUNCTION_SWRDY "swrdy" > +#define LED_FUNCTION_SYSTEM "system" > +#define LED_FUNCTION_TEL "tel" > +#define LED_FUNCTION_TOP "top" > +#define LED_FUNCTION_TORCH "torch" > +#define LED_FUNCTION_TV "tv" > +#define LED_FUNCTION_TX "tx" > +#define LED_FUNCTION_UP "up" > +#define LED_FUNCTION_USB "usb" > +#define LED_FUNCTION_USB_COPY "usb_copy" > +#define LED_FUNCTION_USER "user" > +#define LED_FUNCTION_USR "usr" > +#define LED_FUNCTION_WAN "wan" > +#define LED_FUNCTION_WIFI "wifi" > +#define LED_FUNCTION_WIRELESS "wireless" > +#define LED_FUNCTION_WLAN "wlan" > +#define LED_FUNCTION_WMODE "wmode" > +#define LED_FUNCTION_WPS "wps" > -- > 2.1.4 >