Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp210498imu; Thu, 8 Nov 2018 07:15:53 -0800 (PST) X-Google-Smtp-Source: AJdET5eZUai8WyLxA/6gCHELOcTOsmtGVJNcTcIkhJQHeyG/M9IPB7uLtOwL7O2APYAal4R6CDRr X-Received: by 2002:a63:504d:: with SMTP id q13mr4129833pgl.319.1541690153489; Thu, 08 Nov 2018 07:15:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541690153; cv=none; d=google.com; s=arc-20160816; b=Be6dUb+MPgATeWctAyOWQWXjBhgFVi0B16APLVOXhOWeGstTiENCPTPEsfXYhQCrp0 UrS+CRX0QX7ygFSvFra24Nzr2+dmJF4U04C+lx/hD1DiOA3qGLfZoAOh8astnybbKaEB OW1r7uGveiqhzWinz/h8hGN+Ezl04IQgk8wSroISgTViY7ByT5Xqx9qqCRoA0ICGgSAp cc9hmMq8tOSnBIUC+541mXrTFef4DOUIH8JL1tHppkJLN2twi5gvgO4WyPrTnygYzVy5 G5gw/c0ZMgaF+HnOGERvPldr04uXkuVrQP5AA9eQPw4dwMv//5q5d6+RI7Qf7mODWOaR ZxuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=igo3OfjlWx+o/kTQ9gG0u/C8OrXUjRCdmJLAEbhyG3s=; b=a8KFgK3Gmh734M1+88BbTfTQSAflcDX98QA0eK0Rc8HuOJlrTR8MriteWow3jYFGvQ 1VFhod82V+FOHxGARe7L+w0s1D9umspJ1NT5mIgg08qHTMKP0vraw/DQmj4JDqnZ+rSN SwnJQPFbRxklB6P1nwBYnC7rL26/UVTs9DbUMg+6qurzudZ7ZmvcXFDjJyz6cz2IUg1m gjlbp8vCP/oSadB1EM7UkA9NSrNUuuFAsMf/Cpay+GnPQQkXBf43oVrQQMuHmLPpUJFC EBnAjPDbpOe1uFwuvuPkA0JNxlCmlIt4osJiI63fuFIqxXkX2BsbFS11s4N4KhN+RVe9 RPsQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r23si4083324pgu.359.2018.11.08.07.15.37; Thu, 08 Nov 2018 07:15:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726931AbeKIAvI (ORCPT + 99 others); Thu, 8 Nov 2018 19:51:08 -0500 Received: from mga01.intel.com ([192.55.52.88]:44710 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726758AbeKIAvH (ORCPT ); Thu, 8 Nov 2018 19:51:07 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Nov 2018 07:15:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,480,1534834800"; d="scan'208";a="278183687" Received: from ibanaga-mobl1.ger.corp.intel.com (HELO localhost) ([10.249.254.75]) by fmsmga005.fm.intel.com with ESMTP; 08 Nov 2018 07:15:05 -0800 Date: Thu, 8 Nov 2018 17:15:04 +0200 From: Jarkko Sakkinen To: Roberto Sassu Cc: zohar@linux.ibm.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, silviu.vlasceanu@huawei.com Subject: Re: [PATCH v4 4/6] tpm: modify tpm_pcr_read() definition to pass a TPM hash algorithm Message-ID: <20181108151504.GD14072@linux.intel.com> References: <20181106150159.1136-1-roberto.sassu@huawei.com> <20181106150159.1136-5-roberto.sassu@huawei.com> <20181108140454.GE8922@linux.intel.com> <7a43680a-a216-a191-62a3-c2fb4e72d699@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7a43680a-a216-a191-62a3-c2fb4e72d699@huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 08, 2018 at 03:16:03PM +0100, Roberto Sassu wrote: > On 11/8/2018 3:04 PM, Jarkko Sakkinen wrote: > > On Tue, Nov 06, 2018 at 04:01:57PM +0100, Roberto Sassu wrote: > > > Currently the TPM driver allows other kernel subsystems to read only the > > > SHA1 PCR bank. This patch modifies the parameters of tpm_pcr_read() and > > > tpm2_pcr_read() to pass a tpm_digest structure, which contains the desired > > > hash algorithm. Also, since commit 125a22105410 ("tpm: React correctly to > > > RC_TESTING from TPM 2.0 self tests") removed the call to tpm2_pcr_read(), > > > the new parameter is expected to be always not NULL. > > > > > > Due to the API change, IMA functions have been modified. > > > > > > Signed-off-by: Roberto Sassu > > > Acked-by: Mimi Zohar > > > > Does not apply to the current upstream (with tpm1-cmd.c). > > Unfortunately, I cannot fetch the repository as infradead.org only > supports the git protocol (I'm behind a proxy). > > Roberto I use a proxy script similar to this: https://gist.github.com/sit/49288 (random googling but gives the idea) /Jarkko