Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 8 Nov 2018 16:32:27 +0100
From:   Borislav Petkov <bp@alien8.de>
To:     Yi Wang <wang.yi59@zte.com.cn>, Michael Matz <matz@suse.de>
Cc:     tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
        x86@kernel.org, suravee.suthikulpanit@amd.com, puwen@hygon.cn,
        davidwang@zhaoxin.com, linux-kernel@vger.kernel.org,
        zhong.weidong@zte.com.cn
Subject: Re: [PATCH v2] x86/cpu: fix prototype warning
Message-ID: <20181108153226.GF7543@zn.tnic>
References: <1541639548-11149-1-git-send-email-wang.yi59@zte.com.cn>
 <20181108150318.GD7543@zn.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20181108150318.GD7543@zn.tnic>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Nov 08, 2018 at 04:03:18PM +0100, Borislav Petkov wrote:
> On Thu, Nov 08, 2018 at 09:12:28AM +0800, Yi Wang wrote:
> > This patch fix the following build warnings which because of missing
> > include file:
> > 
> > arch/x86/kernel/cpu/cacheinfo.c:647:6: warning: no previous prototype for ‘cacheinfo_amd_init_llc_id’ [-Wmissing-prototypes]
> > arch/x86/kernel/cpu/cacheinfo.c:686:6: warning: no previous prototype for ‘cacheinfo_hygon_init_llc_id’ [-Wmissing-prototypes]
> > arch/x86/kernel/cpu/scattered.c:37:6: warning: no previous prototype for ‘init_scattered_cpuid_features’ [-Wmissing-prototypes]
> > arch/x86/kernel/cpu/scattered.c:60:5: warning: no previous prototype for ‘get_scattered_cpuid_leaf’ [-Wmissing-prototypes]
> 
> That function is gone in:
> 
> https://git.kernel.org/tip/43500e6f294d175602606c77bfb0d8cd4ea88b4f
> 
> You probably should run your test against tip/master.
> 
> Also, you should say in your commit message that this is an extra
> warning - -Wmissing-prototypes - which is not enabled by default but a
> W=1 one.

And frankly, I don't see why we should be fixing all those. So what if a
global function does't have a previous prototype declaration?!

Micha, is there anything "useful" that warning bitches about or should
we disable it?

Thx.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.