Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp310194imu; Thu, 8 Nov 2018 08:38:57 -0800 (PST) X-Google-Smtp-Source: AJdET5eOaBhbUPV9NtJw9IAa+s5NUjzcvUYz9qCYPafk5uzceeU5oEvaQauqyHHtGqP7SwZaLieV X-Received: by 2002:a17:902:4827:: with SMTP id s36-v6mr5043996pld.226.1541695137225; Thu, 08 Nov 2018 08:38:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541695137; cv=none; d=google.com; s=arc-20160816; b=rs6xac9wnxt2Qr55486/u9Y97vMx2TTHBvVyNzwrW+lv6n533RlEAz7yh8zQi8djd5 EnNvFilLBQOMhD1eUOBoorojb+UzFi1PqLvPIklj3QAH8A4fDboqqZQfkvzHj71BYqXZ CGvM8F36R8Wyo5Oy9kGVhnJOeAF2TqckPVD/d6aMgHePTv4H3Yhc6igF2U3574tcWlFg qn/il5KvhcmLtbgikpr8qFEuT8Pq2OC5dkwXybaRdNc3K2p4qxtTN+pC5glNqmEww+RV nlaz3zWgAp6n06zJPZ2rilWkYXcrGbZ3cWueUWeXNh/X/ECFPG33rhpFvYxO1YVydbUW hmBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=feDH8w5vi7LWpaq5wuslTN2RSObQJfXREp6Et4UDk+Q=; b=iVmo7ptoVjxPfDwiHloZCnSCwQHNYvIgb9DD2j2QxNEnBVEXWkuB2kOHAjLzuq3SJT GA55jepNBfNDXhhIBQRje43qCMfbYmle84MTafjMs+v348qPHpl1TnIi0RXnS3mYxIXU DQqDIXt741NdLnytJth/EZ/L9B3k4pVVGqLvqUdbryXGJ4hvikeHrkPdL+Q7a+D47ixt oyANkocgb3wjnK2SF5rhtfgbGEcuuJxGtSbBIwEve6NZqjG1kFXfCW03fA09KXl0UcMZ m2XrlxdvvMHgqHeJ4myrroLEAOWDiYJLmIIKvaMlN+o/xuIZ4RWsU5ASVnatmoFzrVsX k0iw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y191si4193324pgd.4.2018.11.08.08.38.41; Thu, 08 Nov 2018 08:38:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726963AbeKICN2 (ORCPT + 99 others); Thu, 8 Nov 2018 21:13:28 -0500 Received: from mx0a-00010702.pphosted.com ([148.163.156.75]:44712 "EHLO mx0b-00010702.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726421AbeKICN2 (ORCPT ); Thu, 8 Nov 2018 21:13:28 -0500 Received: from pps.filterd (m0098781.ppops.net [127.0.0.1]) by mx0a-00010702.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id wA8GZnuw018092; Thu, 8 Nov 2018 10:37:08 -0600 Received: from ni.com (skprod3.natinst.com [130.164.80.24]) by mx0a-00010702.pphosted.com with ESMTP id 2nktgnx0xk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 08 Nov 2018 10:37:07 -0600 Received: from us-aus-exhub2.ni.corp.natinst.com (us-aus-exhub2.ni.corp.natinst.com [130.164.68.32]) by us-aus-skprod3.natinst.com (8.16.0.22/8.16.0.22) with ESMTPS id wA8Gb6L8011421 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 8 Nov 2018 10:37:06 -0600 Received: from us-aus-exch3.ni.corp.natinst.com (130.164.68.13) by us-aus-exhub2.ni.corp.natinst.com (130.164.68.32) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 8 Nov 2018 10:37:06 -0600 Received: from us-aus-exhub2.ni.corp.natinst.com (130.164.68.32) by us-aus-exch3.ni.corp.natinst.com (130.164.68.13) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 8 Nov 2018 10:37:06 -0600 Received: from senary.amer.corp.natinst.com (130.164.49.7) by us-aus-exhub2.ni.corp.natinst.com (130.164.68.32) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 8 Nov 2018 10:37:06 -0600 From: Kyle Roeschley To: Kalle Valo CC: "David S . Miller" , , , , Kyle Roeschley Subject: [PATCH 1/3] ath6kl: Only use match sets when firmware supports it Date: Thu, 8 Nov 2018 10:36:57 -0600 Message-ID: <20181108163659.19535-1-kyle.roeschley@ni.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-11-08_08:,, signatures=0 X-Proofpoint-Spam-Reason: safe Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit dd45b7598f1c ("ath6kl: Include match ssid list in scheduled scan") merged the probed and matched SSID lists before sending them to the firmware. In the process, it assumed match set support is always available in ath6kl_set_probed_ssids, which breaks scans for hidden SSIDs. Now, check that the firmware supports matching SSIDs in scheduled scans before setting MATCH_SSID_FLAG. Fixes: dd45b7598f1c ("ath6kl: Include match ssid list in scheduled scan") Signed-off-by: Kyle Roeschley --- drivers/net/wireless/ath/ath6kl/cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c index e121187f371f..6c98d7903ffb 100644 --- a/drivers/net/wireless/ath/ath6kl/cfg80211.c +++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c @@ -939,7 +939,7 @@ static int ath6kl_set_probed_ssids(struct ath6kl *ar, else ssid_list[i].flag = ANY_SSID_FLAG; - if (n_match_ssid == 0) + if (ar->wiphy->max_match_sets != 0 && n_match_ssid == 0) ssid_list[i].flag |= MATCH_SSID_FLAG; } -- 2.19.1