Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp377062imu; Thu, 8 Nov 2018 09:28:59 -0800 (PST) X-Google-Smtp-Source: AJdET5fKgJe+jHTzJ4T8W/67DdYM91j5PCNRO7w5a20N1pFNb2tDms5VxktyvT7W9SNP2ZDowJWg X-Received: by 2002:a17:902:a411:: with SMTP id p17-v6mr5518924plq.286.1541698139759; Thu, 08 Nov 2018 09:28:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541698139; cv=none; d=google.com; s=arc-20160816; b=nLjlNf+PsOx1r5EZjf4l6rfoVJMzUfoUmsAzG9Gr5aTK30YoXO5Jm0DGKz+tuVSrHN Ms+tYWIht3wCMjqbU1YqosUm6Tj3CNfK+wKsapveNnYhkSND7ZZGpbEps7TF1zBhkAWI 9CpeQSHrVInx5vClg57SfSKbRDD9201Lt6XseaZEOOh3NU+Hl7TYry4Sdp8Fnnnl1hxc JTsCtIBdkCpMWScFAD0f7pqkwKx7y3YB981llJITnrbwWktALiMuMeqNT4zPz7ty35ZB HwRtCwARpNAL0e5VIJ9jmEh3FQWtxDwB3Wz7aPQ40900u8JwmgFGp0fMHpfF67t9Vn8P OUrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=jJDio/ZJfG4rMx93kBR5KCiLDgdehFIZOJP+v5+7uWA=; b=QHtXqEq9cnuAuqPshR80UB0jMJ6hdKrStcWFXBWP4d/GcGvWhyXedsIAELCscYFANg wg7BVFUyHCGE4WhtjC3dffODikoXrW/qV9xT07Mko5G9ZtDhR6GO4LWmCoZum1bdeYEy 3ljnjntd/DY4QB3Cj8/rNNJPqtxBSr3YuTLi8eS1yfutGVFTzTWz/1P6nODd5FBjvrpq ezi0/UgGmRy2Bd6JWVVjQm5xa4U2B+jH0WCaO8x2Um2VumXD+B9Gyp10+FQhVH1k9qPa 6/3FeVk+FS+EHR6qZTVr+tjlI3KULXD5wXSAx1A6jfv/mbLepfMm2GecNzMnLvseS+Gp wlMw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h32-v6si4694447pld.437.2018.11.08.09.28.41; Thu, 08 Nov 2018 09:28:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727238AbeKIDCb (ORCPT + 99 others); Thu, 8 Nov 2018 22:02:31 -0500 Received: from muru.com ([72.249.23.125]:53590 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726583AbeKIDCb (ORCPT ); Thu, 8 Nov 2018 22:02:31 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 45078812D; Thu, 8 Nov 2018 17:26:01 +0000 (UTC) Date: Thu, 8 Nov 2018 09:25:58 -0800 From: Tony Lindgren To: Janusz Krzysztofik Cc: Aaro Koskinen , Greg Kroah-Hartman , Jiri Slaby , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] ARM: OMAP1: ams-delta: Fix possible use of uninitialized field Message-ID: <20181108172558.GO56134@atomide.com> References: <20181107213031.21650-1-jmkrzyszt@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181107213031.21650-1-jmkrzyszt@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Janusz Krzysztofik [181107 13:28]: > While playing with initialization order of modem device, it has been > discovered that under some circumstances (early console init, I > believe) its .pm() callback may be called before the > uart_port->private_data pointer is initialized from > plat_serial8250_port->private_data, resulting in NULL pointer > dereference. Fix it by checking for uninitialized pointer before using > it in modem_pm(). Applying into omap-for-v4.20/fixes thanks. Tony