Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp486814imu; Thu, 8 Nov 2018 11:05:52 -0800 (PST) X-Google-Smtp-Source: AJdET5fA/5HkZHbt/bzrHjw5KE8uqvVpPyKIZefw+khJFhSv5poUgFHQQpyW/jVLIXTV8qfkuTpY X-Received: by 2002:a17:902:2849:: with SMTP id e67-v6mr5722821plb.269.1541703952151; Thu, 08 Nov 2018 11:05:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541703952; cv=none; d=google.com; s=arc-20160816; b=wdFmNQ4mBq0G5F7rKgx5Iv5ISLGMQtoAPhwNFlMGNfQnU3TiWm/JB1vGlf8EktmFoB TeidFcijEQrbZsfR5Y+J1WeS0AJoJ29i/clHRZCx3ktZOb0p0Rg39wgbTFXlkHadzQt1 ldMa4H+4kM7jb9N6f6gkKIjI/1d2Rgy47/3GdD/nn83DAc7X0YvOac4rIkuBD7ImewUz iqCnWltEXS943clU7Uvo5InL1oawovmgZDtumAFVsjmcPLI9OK9OCN22BK+srn58X4Jr uTLjL1etn2m86mYxUy7WTETZESMDnlOKaMPPjlCLeGYHqFI3wDKkKrPP9fvarf5ahjnW z4hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=t1zL7Wn6kpNNiTbyKJ/atOPEpTfjrjnKJDBOykZTqxM=; b=vMFYmtmqyxo62ZOvUkMbHXoz/N0EKZIaOW6odHvgrKXR7pzm43Bi71qLV8Pyas6Gec MH4j2YIPbsWayOnJxP0iQUJYtARWW+vefILvk7qnWXbSnZjissz9cu4ESdp+EUfg9JWg s1QWe53aqpuxbDk9J7KTIF3KehsySdSDWXQmP/zymz0IZmTVi6+CwLdMTZEzuEV5wpSP TubkUWK2++kwitoaiudLGlCG95mAeKI3Jyd5gM9RrCoix6CBNaxf8K201wTg5zzOGsYE 177zilvcT9aYclY+DjgPoRCuSE630oAF+2HO20vNAN3cSpwSWxtVuEpWyFKWTt2RqKcx a4zA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z21-v6si4896401plo.89.2018.11.08.11.05.34; Thu, 08 Nov 2018 11:05:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727362AbeKIEmA (ORCPT + 99 others); Thu, 8 Nov 2018 23:42:00 -0500 Received: from mga03.intel.com ([134.134.136.65]:31921 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726801AbeKIEmA (ORCPT ); Thu, 8 Nov 2018 23:42:00 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Nov 2018 11:05:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,480,1534834800"; d="scan'208";a="278248093" Received: from rajneesh-desk.iind.intel.com ([10.223.86.34]) by fmsmga005.fm.intel.com with ESMTP; 08 Nov 2018 11:05:07 -0800 From: Rajneesh Bhardwaj To: platform-driver-x86@vger.kernel.org Cc: dvhart@infradead.org, andy@infradead.org, linux-kernel@vger.kernel.org, srinivas.pandruvada@linux.intel.com, Rajneesh Bhardwaj Subject: [Patch v4 3/3] platform/x86: intel_pmc_core: Decode Snoop / Non Snoop LTR Date: Fri, 9 Nov 2018 00:32:44 +0530 Message-Id: <20181108190244.19204-3-rajneesh.bhardwaj@linux.intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181108190244.19204-1-rajneesh.bhardwaj@linux.intel.com> References: <20181108190244.19204-1-rajneesh.bhardwaj@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The LTR values follow PCIE LTR encoding format and can be decoded as per https://pcisig.com/sites/default/files/specification_documents/ECN_LatencyTolnReporting_14Aug08.pdf This adds support to translate the raw LTR values as read from the PMC to meaningful values in nanosecond units of time. Signed-off-by: Rajneesh Bhardwaj --- Changes in v4: * Moved bits.h include to intel_pmc_core.h * Reordered LTR related #defines in increasing manner. drivers/platform/x86/intel_pmc_core.c | 62 ++++++++++++++++++++++++++- drivers/platform/x86/intel_pmc_core.h | 7 +++ 2 files changed, 67 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c index 0c18f328cd0d..eba6f5c27e2f 100644 --- a/drivers/platform/x86/intel_pmc_core.c +++ b/drivers/platform/x86/intel_pmc_core.c @@ -12,6 +12,7 @@ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt #include +#include #include #include #include @@ -638,15 +639,72 @@ static int pmc_core_slps0_dbg_show(struct seq_file *s, void *unused) } DEFINE_SHOW_ATTRIBUTE(pmc_core_slps0_dbg); +static u32 convert_ltr_scale(u32 val) +{ + /* + * As per PCIE specification supporting document + * ECN_LatencyTolnReporting_14Aug08.pdf the Latency + * Tolerance Reporting data payload is encoded in a + * 3 bit scale and 10 bit value fields. Values are + * multiplied by the indicated scale to yield an absolute time + * value, expressible in a range from 1 nanosecond to + * 2^25*(2^10-1) = 34,326,183,936 nanoseconds. + * + * scale encoding is as follows: + * + * ---------------------------------------------- + * |scale factor | Multiplier (ns) | + * ---------------------------------------------- + * | 0 | 1 | + * | 1 | 32 | + * | 2 | 1024 | + * | 3 | 32768 | + * | 4 | 1048576 | + * | 5 | 33554432 | + * | 6 | Invalid | + * | 7 | Invalid | + * ---------------------------------------------- + */ + if (val > 5) { + pr_warn("Invalid LTR scale factor.\n"); + return 0; + } + + return 1U << (5 * val); +} + static int pmc_core_ltr_show(struct seq_file *s, void *unused) { struct pmc_dev *pmcdev = s->private; const struct pmc_bit_map *map = pmcdev->map->ltr_show_sts; + u64 decoded_snoop_ltr, decoded_non_snoop_ltr; + u32 ltr_raw_data, scale, val; + u16 snoop_ltr, nonsnoop_ltr; int index; for (index = 0; map[index].name ; index++) { - seq_printf(s, "%-32s\tRAW LTR: 0x%x\n", map[index].name, - pmc_core_reg_read(pmcdev, map[index].bit_mask)); + decoded_snoop_ltr = decoded_non_snoop_ltr = 0; + ltr_raw_data = pmc_core_reg_read(pmcdev, + map[index].bit_mask); + snoop_ltr = ltr_raw_data & ~MTPMC_MASK; + nonsnoop_ltr = (ltr_raw_data >> 0x10) & ~MTPMC_MASK; + + if (FIELD_GET(LTR_REQ_NONSNOOP, ltr_raw_data)) { + scale = FIELD_GET(LTR_DECODED_SCALE, nonsnoop_ltr); + val = FIELD_GET(LTR_DECODED_VAL, nonsnoop_ltr); + decoded_non_snoop_ltr = val * convert_ltr_scale(scale); + } + + if (FIELD_GET(LTR_REQ_SNOOP, ltr_raw_data)) { + scale = FIELD_GET(LTR_DECODED_SCALE, snoop_ltr); + val = FIELD_GET(LTR_DECODED_VAL, snoop_ltr); + decoded_snoop_ltr = val * convert_ltr_scale(scale); + } + + seq_printf(s, "%-32s\tLTR: RAW: 0x%-16x\tNon-Snoop(ns): %-16llu\tSnoop(ns): %-16llu\n", + map[index].name, ltr_raw_data, + decoded_non_snoop_ltr, + decoded_snoop_ltr); } return 0; } diff --git a/drivers/platform/x86/intel_pmc_core.h b/drivers/platform/x86/intel_pmc_core.h index e57b26cdb442..89554cba5758 100644 --- a/drivers/platform/x86/intel_pmc_core.h +++ b/drivers/platform/x86/intel_pmc_core.h @@ -12,6 +12,8 @@ #ifndef PMC_CORE_H #define PMC_CORE_H +#include + #define PMC_BASE_ADDR_DEFAULT 0xFE000000 /* Sunrise Point Power Management Controller PCI Device ID */ @@ -169,6 +171,11 @@ enum ppfear_regs { #define CNP_PMC_LTR_EMMC 0x1BF4 #define CNP_PMC_LTR_UFSX2 0x1BF8 +#define LTR_DECODED_VAL GENMASK(9, 0) +#define LTR_DECODED_SCALE GENMASK(12, 10) +#define LTR_REQ_SNOOP BIT(15) +#define LTR_REQ_NONSNOOP BIT(31) + struct pmc_bit_map { const char *name; u32 bit_mask; -- 2.17.1