Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp520198imu; Thu, 8 Nov 2018 11:33:35 -0800 (PST) X-Google-Smtp-Source: AJdET5cyoYsiWUqhp3NIpw/NFEcOzrnNI5pF/Cd4UaG92hQ09Q39e2oui3fwNp4jNoG7UY5KcePU X-Received: by 2002:a63:c24c:: with SMTP id l12mr4836049pgg.146.1541705615114; Thu, 08 Nov 2018 11:33:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541705615; cv=none; d=google.com; s=arc-20160816; b=SfJARIo5PNsvqYBPWzFeodSu57GKaeW3xcJd3D20wdSdEU1A1AKWVT3qcObjB6xOka FX/zpj0hein4OyOtaJ+uU6S8/sQYAmLy6fOntd88vzZugb7Xlue3zTFyRsET/pgEvppj 43egfHDTcdeDOWB5nuKwd+t2irqLOqt0ByxYoYKQooBxn9V/cZq0xs1kE+paa10Q4Guy DIdWruSu+C7mft6+x1MbtCt45VY+Jdc/V+hsEHgx+UqfuACEcZpZzkQ/JO3YDre6eH9D myCdsPGcTXiWSI/l0qT9EKdjSVlm7AVrhZOd9/gp4ZTAVhmEhH7ToBBpTt1XBsAvMm7t iI4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:to:from:cc:in-reply-to:subject:date:dkim-signature; bh=TIK2R+2irgTzLBZnutnmO7Lc4vftZqOCApHzyog2wpk=; b=KGbVvxLN1d3+/9MB96HJXOzhuxlOVjV74rg4mehlv77nvr6ZRuqODYz9nzdHafbxkw sJJHGY3IbjOXO2TeJov8w4JVroXBgl/4dfx4QRCP9+9e7SWb3SBq5F0RPwu6dRh1VN5z 9gm+Yt1Ot9qE7YTzg0l3PQ96i6/Vw2W1L1oCUjiQ7AoHh5s/QotwUyoqFmvsqHNn/dru /ObAsBbL0MCcayqp16wny6k4HT2XiaVXo2K0M3Q4E4/iJtj1V24oxjB+5UkHsxonUoB8 JNqdU5xQkjNIhhpSukYRQ5Vn0I3Oc7Lpk68xxuzgyxdXxADSaUfuqb7w25koqj8OMovu Pz0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=GSeGubkS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 132si4070646pge.141.2018.11.08.11.33.18; Thu, 08 Nov 2018 11:33:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=GSeGubkS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726845AbeKIFJv (ORCPT + 99 others); Fri, 9 Nov 2018 00:09:51 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:37445 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725884AbeKIFJv (ORCPT ); Fri, 9 Nov 2018 00:09:51 -0500 Received: by mail-pf1-f193.google.com with SMTP id u13-v6so9754558pfm.4 for ; Thu, 08 Nov 2018 11:32:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=date:subject:in-reply-to:cc:from:to:message-id:mime-version :content-transfer-encoding; bh=TIK2R+2irgTzLBZnutnmO7Lc4vftZqOCApHzyog2wpk=; b=GSeGubkSB+I4iOXXfYrgyGhmdpepc2pi4ErUd+gTvHpg6iaU1Cr2zplCKZ5rhqWYGj vs0zeZcNqw6FiaIohWO/QBY1GffRWhj9seYod5IIOUcNWTku2fUkU7rDAWMMvB114k0J 99mpw2lQ7SRp0xlbP6NyN5cqQr7yhdutsk7pr3zb9AE5R/8WPYOWdlvP8CM64HTcK30W VS8SnOGSrAMtaNJdLkKjP8zGlMT686KUuWwt7SGM51tXg5RS+FdpGUqeyQYDl9Tpetj+ p5w6rGKu1WpmrUeJZY8Iy4upsBKzM+5o+FncLHxrZfbnXa9ESvMkdz3ImpNSi1iv04ko Y6PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=TIK2R+2irgTzLBZnutnmO7Lc4vftZqOCApHzyog2wpk=; b=df1xADtP9KML2zbEb8Wyfmga5EN+YI8FDzCBK+YGvzf6tuwl7/BbNnBCU2AH2gAUwV RxS2khdWe+xOq0Cd3QSUihVvR6A2fHo/pOrRRrTh0pNXBZOeySVaWiEYGb0SCkV7opSP opjqL5A5bFCjx4FHhu1zV/qX5zCJWHv43z6FlEZNyUdADI9BaH0LYrfzW2dpM5dnkReR GcvglsmrpHklbqegn1e+R/UDqGDeeLlpLPJcSsDW38Z11SBs74rZJrh6oEDAXJ55PfSK jFiD400TtnrXslkTKcjdfdD6slYFaEFYRFPgn60D19GJIOKI56+Nd2AdsB5s548S19X0 lcxQ== X-Gm-Message-State: AGRZ1gKboiE9YU2MHF1wB29TdQQcj4F1ZVMUohRD+/EgDYMQSChTbG5E 3wnrNMjjZ8Hh5p8WTJKv5lZTbA== X-Received: by 2002:a62:3241:: with SMTP id y62-v6mr5921005pfy.218.1541705576361; Thu, 08 Nov 2018 11:32:56 -0800 (PST) Received: from localhost ([12.206.222.5]) by smtp.gmail.com with ESMTPSA id f22-v6sm5046601pff.29.2018.11.08.11.32.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Nov 2018 11:32:55 -0800 (PST) Date: Thu, 08 Nov 2018 11:32:55 -0800 (PST) X-Google-Original-Date: Thu, 08 Nov 2018 11:26:45 PST (-0800) Subject: Re: [PATCH] riscv: fix warning in arch/riscv/include/asm/module.h In-Reply-To: <20181108190700.30825-1-david.abdurachmanov@gmail.com> CC: aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, david.abdurachmanov@gmail.com From: Palmer Dabbelt To: david.abdurachmanov@gmail.com Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 08 Nov 2018 11:07:00 PST (-0800), david.abdurachmanov@gmail.com wrote: > Fixes warning: 'struct module' declared inside parameter list will not be > visible outside of this definition or declaration > > Signed-off-by: David Abdurachmanov > --- > arch/riscv/include/asm/module.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/riscv/include/asm/module.h b/arch/riscv/include/asm/module.h > index 349df33808c4..cd2af4b013e3 100644 > --- a/arch/riscv/include/asm/module.h > +++ b/arch/riscv/include/asm/module.h > @@ -8,6 +8,7 @@ > > #define MODULE_ARCH_VERMAGIC "riscv" > > +struct module; > u64 module_emit_got_entry(struct module *mod, u64 val); > u64 module_emit_plt_entry(struct module *mod, u64 val); Works for me. Looks like arm64 might have exactly the same issue. I'll roll it up into the next RC. Thanks!