Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp19231imu; Thu, 8 Nov 2018 14:02:00 -0800 (PST) X-Google-Smtp-Source: AJdET5d9m06S9LN8fesj8p2RF3dmmIFJm8Z7FXfhnFSBo9RW1mkhf2mxP0zEL76j/nmk5tODiLYX X-Received: by 2002:a63:81c7:: with SMTP id t190mr5291762pgd.393.1541714520231; Thu, 08 Nov 2018 14:02:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541714520; cv=none; d=google.com; s=arc-20160816; b=VB/53fzeV7YjzTbs1pJbzIRjUPN3jeNRWmO+3MCsXqZ4G7HDoPAdRvufenaBxVTVVX V+QQMEePhs0cNShA8GkccyBPPZ4b0nHSzJ4/GNf8UuOoGAatRW6rxeZT7TDCgX9YXpxS vyaLPOOT6J0oOnoZTnN/AD2KzlD4emBJClokMTzVrK6G96BU7Z6VMOMb2lOYT4lCaOWI jCHn5kSAg4BS0LHv2BG5fPdSdRGK++5lo0ovaDO5NyzYlHN9Hbyw7kV72wBDu4O/Lqmg LSSOu8QELq9MW1kqFzklOMe4T79T5nryZ7uSqW0O6KR6y1JlR0UeS2pfboQlRk9yPPkK ylVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=CjIJh4HWKJ1/L3to8kAGUNn+VoMoRhcLvBcZmkabJVI=; b=QYsiMvAk5UJA2Iat3KEQFJWGrPt6x6XFqkgofpPznDlgGnStaBPa25IUTUfEizrCUa IXWzRee3GJIXXyLenHqDHaLBrr9YtPRpIVIJ/RujVROevyIblrbT1m4EAAYnzu0kHjoo y8vhVbqiD7/DCb6fnmKObBLGmIR55ksh8D0iK8JWBwv3vA9VULesXIH1z731R+pVhYkv 4L6+/okhS2Pv45clu0zbSQEto202fg9hJuwMMUpTQToOi2gv+kJ1ovSxwtDM3ZvxP5M8 A1QZzLAR5hk84at6a0Xi9SRt90Oy5uGzvJ8xw29k+Pbwe3magxg+yF1Mnp5lAiqS0Nfl aF9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ba7v2zVJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f11-v6si5953238pfh.33.2018.11.08.14.01.25; Thu, 08 Nov 2018 14:02:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ba7v2zVJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730470AbeKIHht (ORCPT + 99 others); Fri, 9 Nov 2018 02:37:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:56494 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730428AbeKIHhr (ORCPT ); Fri, 9 Nov 2018 02:37:47 -0500 Received: from localhost (unknown [208.72.13.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 980B520892; Thu, 8 Nov 2018 22:00:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1541714418; bh=OWl9NWPu/6LlX6K1rVi8kHLF7o06ZcHului8Bk9MezI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ba7v2zVJJaCskwH7OyDbkql4okKS9sWmi21LxOYmxq5Dpbk2MWN/Q75mTm1BeMIX0 9hlagzrmhOyfOVprcqhj0qR6Y5Pz8vPxgMaDh9dmTeo4lwidT6aaDk3miwxrBykWeZ OK1lpGk0LbfsdyOCLwidTs+FzxCSyOKEHTnIvCY4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Geert Uytterhoeven , Mark Brown , Sasha Levin Subject: [PATCH 4.4 042/114] ASoC: ak4613: Enable cache usage to fix crashes on resume Date: Thu, 8 Nov 2018 13:50:57 -0800 Message-Id: <20181108215104.935906051@linuxfoundation.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181108215059.051093652@linuxfoundation.org> References: <20181108215059.051093652@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit dcd2d1f78664fdc75eadaaf65257834e24383d01 ] During system resume: kernel BUG at drivers/base/regmap/regcache.c:347! ... PC is at regcache_sync+0x1c/0x128 LR is at ak4613_resume+0x28/0x34 The ak4613 driver is using a regmap cache sync to restore the configuration of the chip on resume but does not actually define a register cache which means that the resume is never going to work and we trigger asserts in regmap. Fix this by enabling caching. Based on commit d3030d11961a8c10 ("ASoC: ak4642: Enable cache usage to fix crashes on resume") by Mark Brown . Signed-off-by: Geert Uytterhoeven Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/ak4613.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/ak4613.c b/sound/soc/codecs/ak4613.c index 07a266460ec3..b4b36cc92ffe 100644 --- a/sound/soc/codecs/ak4613.c +++ b/sound/soc/codecs/ak4613.c @@ -143,6 +143,7 @@ static const struct regmap_config ak4613_regmap_cfg = { .max_register = 0x16, .reg_defaults = ak4613_reg, .num_reg_defaults = ARRAY_SIZE(ak4613_reg), + .cache_type = REGCACHE_RBTREE, }; static const struct of_device_id ak4613_of_match[] = { -- 2.17.1