Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp279000imu; Thu, 8 Nov 2018 19:41:51 -0800 (PST) X-Google-Smtp-Source: AJdET5eA7YK175MMsHuVMfeHtrzRyyQgc6wI/hmZFWtmTp3ERiieMvsfB8Xcq58xc4ouPULlSDOl X-Received: by 2002:a63:3204:: with SMTP id y4mr6070554pgy.41.1541734911162; Thu, 08 Nov 2018 19:41:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541734911; cv=none; d=google.com; s=arc-20160816; b=JZUYo/KiRg4m08dkPXo67EXACQU/ApIRNLuDZwk34FJUIPy3Z63XN4le+sCiLZph15 wzRiOuqdslQ8BdDTNu7vY5O+g7JYgaEizCifeMXtkr/WIV6YlI9JqXgCywrlHzGHs4E2 uN4HI+Qp9XUzfZQ4GxBn/ykYHj1m17Beh1QKer8EypzCKW8FJ80JaTfaySxgyneFZUH4 0+q6IJiuCsC56NI+m8LxZmLyZtcD7dYjwGeGoPVgt1JQL0QIsuv7hsGO1rbZmUIT7sy+ zJCD9yFcsZMnYXZ4mY1r/pBhkrust3//85ElqG8DrIF+gglctgtIDQMPtNtHWnWv3nIW BJEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=2kbi1OVswm8nkse44KxCtsY6h8D9yrbC4824Iy9Rzt0=; b=dUBRjzKyUtOluv2oKJMQ86GC9Oyo3uJYl/ayta2MlPcUChmNMN5iQI4g2RajQAsrW8 Ij1El1yQHzJWmnS2kZn/oZMACio8HpVMVSlIVFBogqoQcF+9E+ygc4/kFPV/5tc0+hrR yrRqD+yygIDJyQtD8hew0t6QBOOvF6bCGK2BCBWxviqVo5/DAjngbY5Lg3dtVrf5Me+k UHQk6ODGveb0nGIr2DPCs4tkeNL7WxIjtOLkIVM2TVh+2HK2ruvrH0/EVphpEzlMJGF0 RP5HwImKmEF/ofNyx2jAQhSOZaduwXyKOmdlPiPUfnoTiSbX29mupz2ggrm24YIpCHku 5AfQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r7-v6si6123083plo.100.2018.11.08.19.41.35; Thu, 08 Nov 2018 19:41:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727693AbeKINTx (ORCPT + 99 others); Fri, 9 Nov 2018 08:19:53 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:42316 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727391AbeKINTx (ORCPT ); Fri, 9 Nov 2018 08:19:53 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::cf9]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 2BFCF14B3D599; Thu, 8 Nov 2018 19:41:13 -0800 (PST) Date: Thu, 08 Nov 2018 19:41:12 -0800 (PST) Message-Id: <20181108.194112.1819328948681907759.davem@davemloft.net> To: stefan.wahren@i2se.com Cc: michael.heimpold@i2se.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: qca_spi: Add available buffer space verification From: David Miller In-Reply-To: <1541684301-15824-1-git-send-email-stefan.wahren@i2se.com> References: <1541684301-15824-1-git-send-email-stefan.wahren@i2se.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 08 Nov 2018 19:41:13 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stefan Wahren Date: Thu, 8 Nov 2018 14:38:21 +0100 > Interferences on the SPI line could distort the response of > available buffer space. So at least we should check that the > response doesn't exceed the maximum available buffer space. > In error case increase a new error counter and retry it later. > This behavior avoids buffer errors in the QCA7000, which > results in an unnecessary chip reset including packet loss. > > Signed-off-by: Stefan Wahren Applied.