Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp407630imu; Thu, 8 Nov 2018 22:55:19 -0800 (PST) X-Google-Smtp-Source: AJdET5fdJADKt4TcQ+qe2R38Ndf77SlnsbySvROlKfx2tnnoRelIXzYC0dmhhgZFbtZZol5U3bcj X-Received: by 2002:a17:902:6f16:: with SMTP id w22-v6mr1636612plk.235.1541746519464; Thu, 08 Nov 2018 22:55:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541746519; cv=none; d=google.com; s=arc-20160816; b=F73QpwUyEycgyjgOPEuiNJ7V11TOKVfX+QdOQ/70TVi/mFQywpJmsDYZn/8K5Iwb6r 93HMseZlTwnO/rcRDHqxG/lgHgVA6RKeWDYZ1rshjcJggWIfIMfghT3HEYVEkKnUkuie N3hZTcF7yRNv3pGkG4xVdI6MlhzmgZv/GUFV5gEKSSqDpYzVtbKXY6Yu15CAPmQrEPmP ZCy4rfGOU6OJW3Z1ddvBOB1qngE+OvO/A95Du/1550CRwNsADAN/F4JhXoKN1iVUY5Z5 U+FKPvSq/4sG8SB4LrvN18CR6T++gvm/pzF5TX56SVbTfgX+QzgckuhnRye7GgE9NvhR 3HjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=YaUMgYVEE8rGGmtrAJZKLM0JQVY9Xo9K5T9WoSnTHdA=; b=aFYv58PHizZ1XZ4MqAaOMpQbfA2Ek2RXpTKnZchcvFElHFWhVkKluMkWz9/j9ioPnP fVbh4rbsn4HExvy2+FFkRVVFWdKFZ0lGeGAZhWsmfn6jNnRGbOr7FNRrIj/AhH6Nau0K VvT1sI/Wgxgz21LQ9trr2AZgceWeugjHksLECPQhvjFMPNVeHsXx9yTlYWA6lr/5KXel p1wnWepyBYPv+ZUVfW64V8WfCBsNGWqk7Jh9Mt+e+SDHN8awQMwk7qfVa1mp1aMMrJ4P YDrfqUrhQPYKDx/SkK4Q+v/r8P8VltBpRJel7Gkxld1ZNWZsqKg1YarOWH+get6JVoNx aRew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=Xw74aCLE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y73si5870487pgd.478.2018.11.08.22.55.04; Thu, 08 Nov 2018 22:55:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=Xw74aCLE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727984AbeKIQdx (ORCPT + 99 others); Fri, 9 Nov 2018 11:33:53 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:55092 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727693AbeKIQdx (ORCPT ); Fri, 9 Nov 2018 11:33:53 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wA96oUTI019476; Fri, 9 Nov 2018 06:54:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id; s=corp-2018-07-02; bh=YaUMgYVEE8rGGmtrAJZKLM0JQVY9Xo9K5T9WoSnTHdA=; b=Xw74aCLEifecwEJTOScNQPf/CP6EEa47l52riKUmdMCzG2wlk5hfw6W34KiLo1pO1oXF SSecrEAE2SNo0/x/TZIKKiGw4bMNDukMqkq6k1U1s/44dGo1+q+jSypAHTPGq8zs2u+n 1ojwo56AFcCb0Sx9VwqpSDmiW0KcoSqPCFJWr1sspbZ3pHA+m9ObNeBSucFIjVEq4Jvi 1E/u8PPWhI+2XTe5Wi86j9eUyELrhbdZJEDLiy3dD2Qx+kOOIVCpXS/84GRjTAnV3FB/ Nr5aVGVNyTXMd40dWo0Cj0NdKwqyPuLtHDQLAfQdL9h+kdGX05uvAoSlrXFLyl5jRSbN qQ== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2130.oracle.com with ESMTP id 2nh33udegq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 09 Nov 2018 06:54:37 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id wA96sbNP027440 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 9 Nov 2018 06:54:37 GMT Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wA96sa3x004578; Fri, 9 Nov 2018 06:54:36 GMT Received: from jw-M900.cn.oracle.com (/10.182.70.161) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 08 Nov 2018 22:54:36 -0800 From: Jacob Wen To: netdev@vger.kernel.org Cc: jgross@suse.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: [PATCH] xen/netfront: remove unnecessary wmb Date: Fri, 9 Nov 2018 14:53:59 +0800 Message-Id: <20181109065359.14900-1-jian.w.wen@oracle.com> X-Mailer: git-send-email 2.17.1 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9071 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=760 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1811090064 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org RING_PUSH_REQUESTS_AND_CHECK_NOTIFY is already able to make sure backend sees requests before req_prod is updated. Signed-off-by: Jacob Wen --- drivers/net/xen-netfront.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index f17f602e6171..a8303afa15f1 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -337,8 +337,6 @@ static void xennet_alloc_rx_buffers(struct netfront_queue *queue) return; } - wmb(); /* barrier so backend seens requests */ - RING_PUSH_REQUESTS_AND_CHECK_NOTIFY(&queue->rx, notify); if (notify) notify_remote_via_irq(queue->rx_irq); -- 2.17.1