Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp497116imu; Fri, 9 Nov 2018 00:58:15 -0800 (PST) X-Google-Smtp-Source: AJdET5cx6nPazioC22laY57gs2fO+y4aDouAtHzYSJ10C6i9e74MHzdrdJ1BLQgl26ohx5ifzad+ X-Received: by 2002:a63:eb0e:: with SMTP id t14mr6760129pgh.445.1541753895301; Fri, 09 Nov 2018 00:58:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541753895; cv=none; d=google.com; s=arc-20160816; b=WDubKjMp7pfKB4D8QBYWPXr4n5Z92MDGq0NeXroYkczbuIkSVp/MIPZo6Js38Y++gx bBPYAqr+vHzQw8Rt/uGmz6XH3AxXU4aoniAtWGFZMd+purgnPzW/kVnB20z27PPc15ca bpnfYr5a5CUoS9VJyfYpFBbb+6V19YEQL1OQ/Ya2GlSvytvwiJoS5iVw271po5a+cG9d ihumoVOR223uFrdpLu/BufdkJ6wDdhPSz1TUp8OFBHExEUxktuSub/ma4ywJurSOeB4C 8z4tAUrf7DA3jRHyvdIFHXUdXutbWzNvqE+YWJov86JtE7qACaZv26aUy99nCOkenMLn R68g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=qYKootPcIB4r8J6KSprtoc4R+LBMZo96WYHAZXPL+38=; b=V8c3V2jNVKOwTuY7fWP9oc7/PwVbeowzdmPlRDd8DWGCuntP4W5V+UT6/t1YXEUzi9 N5MIinmYQtF7KRTvngX3Slr4ExKmJOMtGmJmtDJ2y4JJ7IMkkdY//o0QjEA0CmY3aSGj xbiOPYp/gqSFVJTs6ostg94t/Cd/FbxkfNiYKxdglMTOcNgv5oZS+NsU4KrGs4u9Omvu e1XCdi1l+WwbtXVYTVwgkq+PTK7BMDH+OWwgOl0znks6zk5xG1FT/m1kmqqq28Jw0ZlC t0zIAFRGGprRI9W5pgVGgV+2tboBQWI7TQlIgkjfzKLGTjHa4lXFx7jF7pM/4rwUyFlT +O1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=efWXMrUC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x5-v6si6770980plv.256.2018.11.09.00.57.59; Fri, 09 Nov 2018 00:58:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=efWXMrUC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727942AbeKISgy (ORCPT + 99 others); Fri, 9 Nov 2018 13:36:54 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:55954 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727735AbeKISgy (ORCPT ); Fri, 9 Nov 2018 13:36:54 -0500 Received: by mail-wm1-f67.google.com with SMTP id s10-v6so1228687wmc.5 for ; Fri, 09 Nov 2018 00:57:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=qYKootPcIB4r8J6KSprtoc4R+LBMZo96WYHAZXPL+38=; b=efWXMrUCkJ9fz8c/mSEpZ+Rt2LUdVaHuJyPrySeIRifl/+adC5g2iFJYigRnnCZg9O 4NCdyhapUIDLelIRBo/T0w3QC1qsvQ2ye5GCBc1hZ8LSOnR/6fMc+u4PVLFpxQnyKYPW 9UN2oNsGBwQrNaFl9XY8BToX4vQds/Adl+xxg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qYKootPcIB4r8J6KSprtoc4R+LBMZo96WYHAZXPL+38=; b=Uo/lOht8kQNVh7m8oy0/8EXDPcJYrETmhj+Lx9UECyqpO5sSeWArvgMSA5KLjFKVWf okR5JQ9/1mM/PNm6m/Kk57itoF6oHyXFJ5IqbqKxfLCgE4hTeh5O45Vkn1R6RzM7Q/nu qBz1933xvbZvszQQ0g6Vo1Jyw9LJZ49+5sCTanpBc86KGrz7ayu8KSnmKQ0tFVql27n+ suOleBLK1QcGytQWrWvw+SnDYEJR/0AMtC8TN/Paq4GvKFXhkIyMVDOnaY14BlSnDsYV AFzrWYy/mJPwyj7wnDW0NxW0tLMmxVU+nW2tgZtuxTgI2kO55Le5bJcFo/i6o6W04iuz NrNw== X-Gm-Message-State: AGRZ1gJFgCFAG/Ff6IDBHD5I+/lTxFCiMcNXTq3cmUUe1fmOnChMJuXp we6fgbuLmyH9x+sMAKR0YL6AbG5DITE= X-Received: by 2002:a1c:1605:: with SMTP id 5-v6mr3900754wmw.126.1541753835449; Fri, 09 Nov 2018 00:57:15 -0800 (PST) Received: from [192.168.27.197] ([37.157.136.206]) by smtp.gmail.com with ESMTPSA id m69-v6sm894155wmb.8.2018.11.09.00.57.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Nov 2018 00:57:14 -0800 (PST) Subject: Re: [PATCH] dt-bindings: media: i2c: Fix i2c address for OV5645 camera sensor To: Manivannan Sadhasivam , mchehab@kernel.org, robh+dt@kernel.org, hansverk@cisco.com Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20181109075643.17575-1-manivannan.sadhasivam@linaro.org> From: Todor Tomov Message-ID: Date: Fri, 9 Nov 2018 10:57:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20181109075643.17575-1-manivannan.sadhasivam@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mani, On 9.11.2018 09:56, Manivannan Sadhasivam wrote: > The i2c address for the Omnivision OV5645 camera sensor is 0x3c. It is > incorrectly mentioned as 0x78 in binding. Hence fix that. The seven bit i2c address of ov5645 is really 0x3c. Thank you for finding this and sending the fix! Best regards, Todor > > Fixes: 09c716af36e6 [media] media: i2c/ov5645: add the device tree binding document > Signed-off-by: Manivannan Sadhasivam > --- > Documentation/devicetree/bindings/media/i2c/ov5645.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov5645.txt b/Documentation/devicetree/bindings/media/i2c/ov5645.txt > index fd7aec9f8e24..1a68ca5eb9a3 100644 > --- a/Documentation/devicetree/bindings/media/i2c/ov5645.txt > +++ b/Documentation/devicetree/bindings/media/i2c/ov5645.txt > @@ -26,9 +26,9 @@ Example: > &i2c1 { > ... > > - ov5645: ov5645@78 { > + ov5645: ov5645@3c { > compatible = "ovti,ov5645"; > - reg = <0x78>; > + reg = <0x3c>; > > enable-gpios = <&gpio1 6 GPIO_ACTIVE_HIGH>; > reset-gpios = <&gpio5 20 GPIO_ACTIVE_LOW>; >