Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp732490imu; Fri, 9 Nov 2018 05:17:23 -0800 (PST) X-Google-Smtp-Source: AJdET5cISFoIybDBHe2CvXsfejICdhm1tlmKSqqIj0hYPcQOXWvK1t53JMfsiCGnQupDi2Xgcq64 X-Received: by 2002:a62:3687:: with SMTP id d129-v6mr9074295pfa.56.1541769443261; Fri, 09 Nov 2018 05:17:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541769443; cv=none; d=google.com; s=arc-20160816; b=hOSd/9mXK5KqlHN/gq8qLStTNOrO8Zc5H1IEN3rqri8EOm7HCYjpw1Ajcj7ISypHlO 5s1mysgZSCUyteuxEc3XV+T94c3r4Kr9iiSHg2f2aS7IEqhazPtzJakdZWf2cpiwPW2a hp8+YXOX2tddSNiwEmbgwRHuS4Ga90W7SG3NxP5KQsc/Uo60r5RBQEt4xaKnWQMDMaFp e5eufrlo0gQXoQmMSR0Ng2vv/q+tv3T8TaRCOh+Pd6ZvWjlhg9txxa2iKxNQrqyvFzz9 sz3kN0LiQIyU62NeCc3JP+t9XXq9XRvCwAt6Itvk9RWEua4eP+dPXK1lLgkfKclLqchk DcJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=1vsrHPF0i32laW0hDwp5/dt37q797it8Bef0vgYQh9o=; b=ltSfagmJtSMY4RUEP693oWRPPsU/nLeqANlK23Jqd2gLV/B9Wb9E0A9erDN/5o528s JEVfu6KTs9ct8kW/djK0C2+Wm6b+qIiQ/PeLtytX80Jx9eCH8SsD+3VnDL3XXLG9w3NS IxjNvXXM2Mclhe2uDjd0CbrT+O28Fbnz5VcsON53/AHXSROzckkYgHSH4gSsT7C+qeC4 ICPKq/5iwYrF9Oxi0XFI6ot5VmxU175wdqt6Iki5SkELPlw6OLFHrfcxHX6ByLFtWiPF JbXgYc60telDwE86/XeDs/p+XgcCGap3rxYYBuNPKeFPRD0DZwNb/ub4t/N4HW/EXYaV 37wQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b="X/m1KbZU"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i33-v6si7368859pld.433.2018.11.09.05.17.07; Fri, 09 Nov 2018 05:17:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b="X/m1KbZU"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727962AbeKIW5N (ORCPT + 99 others); Fri, 9 Nov 2018 17:57:13 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:39178 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727725AbeKIW5N (ORCPT ); Fri, 9 Nov 2018 17:57:13 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wA9D4TpI126442; Fri, 9 Nov 2018 13:11:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=1vsrHPF0i32laW0hDwp5/dt37q797it8Bef0vgYQh9o=; b=X/m1KbZUJobRrWSTcTywhZ8iC3xMRwNEd0Y7KOz1qfUOSNSJ3DqThO8YmoM8MbkYzknn 0pSY2aDHZhkBGtX450T46M9ytgBLkK3JiKkJWCkyksR9WtfotL4Cx5uUK0eWF6ZDdHXM n0fbrXaubcNGvFP6/iCReXNpmNb54+FJ0vGB7cmsjH0Gz4/QJaSJPgHl1xtZPGBlS1Xg H7tYT45DFzhmEMuXhHz3xg7O2tUQqrUU/4KqzEZnepfj7Kwr7aqizy49BqedGuk7LY9b 8E33ypFt8S2kC1Sqig1hVJTwgMaa3SR/vJTMFxzyJ9fn8/IdXzXaJmdojkB1EtHeTF0r zA== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2120.oracle.com with ESMTP id 2nh3mq6yhc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 09 Nov 2018 13:11:17 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id wA9DBGKB000416 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 9 Nov 2018 13:11:16 GMT Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id wA9DBED7003994; Fri, 9 Nov 2018 13:11:15 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 09 Nov 2018 05:11:14 -0800 To: John Garry Cc: "Martin K. Petersen" , Janek Kotas , "vinholikatti\@gmail.com" , "jejb\@linux.vnet.ibm.com" , "robh+dt\@kernel.org" , "mark.rutland\@arm.com" , "devicetree\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" , "linux-scsi\@vger.kernel.org" Subject: Re: [PATCH v4 2/2] scsi: ufs: Add UFS platform driver for Cadence UFS From: "Martin K. Petersen" Organization: Oracle Corporation References: <1A428C77-982A-4EB8-8FDD-A33979753660@global.cadence.com> <38D3DEAD-C318-4BE2-8605-102FF572AD45@global.cadence.com> Date: Fri, 09 Nov 2018 08:11:11 -0500 In-Reply-To: (John Garry's message of "Fri, 9 Nov 2018 11:51:59 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9071 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=469 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1811090122 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org John, > I am building your 4.21 queue today, and it seems to be broken from > this patch: > > https://kernel.googlesource.com/pub/scm/linux/kernel/git/mkp/scsi/+/b3874a425510d1164fd3428ab99273c07d210d82 > > You seemed to miss adding the c-file: > make[3]: *** No rule to make target `drivers/scsi/ufs/cdns-pltfrm.o', > needed by `drivers/scsi/ufs/built-in.a'. Stop > > Or am I missing something? A corner case wrt. handling of new files in my pre-commit hook prevented the .c file from getting properly committed. Fixed up, thanks! -- Martin K. Petersen Oracle Linux Engineering