Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp945787imu; Fri, 9 Nov 2018 08:30:24 -0800 (PST) X-Google-Smtp-Source: AJdET5f+9CX+WPWQhtIWQsefd9TkO8VCXA5ar/vE/LudNUAnZWDs5cdQt7+2rj6t9EkoEpeQFGtz X-Received: by 2002:a17:902:9f91:: with SMTP id g17-v6mr9685921plq.27.1541781024887; Fri, 09 Nov 2018 08:30:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541781024; cv=none; d=google.com; s=arc-20160816; b=Iy7SE566D/DABwJCF4lqeRo1ExJt1sRIfp/SGd7BD1QVZLO9Q+VxWS94khXecYMVgd PSJV3OE+8tqQ74UBqdtgWyDkoU4t4qbIDWbi2Ial7k7NbA9Ct7CiBj4pORWDL5W+bZ1j FQuk93XB+bIttpOzC8SaIqG7vW6BL2PDrOYLxgx3ZyLvj4J+RLqbqDCP0b+IGqb8Vd5k 6w2mn3wBdj6CQoMeqgP8CZ7rVTB9GFyHKh+Tbj44cfZSa3XjSpxWebcFF+DpqKSvqBge YeMajJbCmu1RuCZ5HfBtY+e0fd1/HDR1s57AUvYuVQnIh6dRaXQQ8L1jM5a3YlL/QdwX wuEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=X7wtDsjRBYpgh6jIVnlWvsitJi3k3eDONGbl33iu6/0=; b=hVoorUvNkWuxExbgZJKBqeYV9UQZlu++opSbSJ+spQXErDtqsbxp7gL9LfzWiywuhP MgbBACW9tfGm/Kh9IYKt1+lNM+piVgYDntBnMDAuAZXJ+DsP/Sljq/bWRaoLmyapKNnV VMgZ2mOAdMD+axN8dA/t61xVTllg0jQwu0hH4Pcho8GQQ317OgZfs120UJZEM2F3zgYm 0RFhkzulLSNHCfup7Fb3jezW8TYZZIGxAFENdLU6ou7P+wiLNxWId4Q5cqmYZXErYdc0 WihibgsmUA3393NI39zkxSo4dAzDSTsOh4ZCZ8+pYoo6rIqDfPTozfuUOLijQFqmH1Cn vACg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UEE7Wzym; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s3-v6si1238038pfm.85.2018.11.09.08.30.00; Fri, 09 Nov 2018 08:30:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UEE7Wzym; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728507AbeKJCKO (ORCPT + 99 others); Fri, 9 Nov 2018 21:10:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:50052 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727955AbeKJCKO (ORCPT ); Fri, 9 Nov 2018 21:10:14 -0500 Received: from localhost (71-6-98-120.static-ip.telepacific.net [71.6.98.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 20A6E20825; Fri, 9 Nov 2018 16:28:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1541780937; bh=X8oSKXWD88o7ViU80aO6xOshsClFN7D2qZncz2qfpEc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UEE7WzymIiP5xPs9nQDkPNQUg0WhOJuJ/Fm8DjH8YVPs3/MlWGPeSlHbayR684YWQ 375odOwrBFrmvXIKW4BzRqKhoxiiBsEv8qWzz6jQIwboZPnNNDdd3v7A8ysEEulSVW xocV1PLn5iByDeHqb68JfyNJ6MMOZBx+UVGtKeHA= Date: Fri, 9 Nov 2018 08:28:56 -0800 From: Greg Kroah-Hartman To: Guillaume Nault Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, "David S. Miller" , Sasha Levin Subject: Re: [PATCH 4.4 063/114] l2tp: hold socket before dropping lock in l2tp_ip{, 6}_recv() Message-ID: <20181109162856.GA2407@kroah.com> References: <20181108215059.051093652@linuxfoundation.org> <20181108215106.791041209@linuxfoundation.org> <20181109153332.GD1415@alphalink.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181109153332.GD1415@alphalink.fr> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 09, 2018 at 04:33:32PM +0100, Guillaume Nault wrote: > On Thu, Nov 08, 2018 at 01:51:18PM -0800, Greg Kroah-Hartman wrote: > > 4.4-stable review patch. If anyone has any objections, please let me know. > > > This patch was partly wrong. Here is the followup fix: > 94d7ee0baa8b ("l2tp: hold tunnel socket when handling control frames in l2tp_ip and l2tp_ip6") > > Both a3c18422a4 ("l2tp: hold socket before dropping lock in l2tp_ip{, 6}_recv()") > and 94d7ee0baa8b ("l2tp: hold tunnel socket when handling control frames in l2tp_ip and l2tp_ip6") > should be applied/backported together. Thanks for letting me know, I've now backported this as well. greg k-h