Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp947753imu; Fri, 9 Nov 2018 08:31:57 -0800 (PST) X-Google-Smtp-Source: AJdET5e1y8wdrQF5fkWhrwnT1bhYuku7wQYZheA0qcWVo4UV+uAMkvERQaZcAq+boDbGU/BO6dMI X-Received: by 2002:a63:334a:: with SMTP id z71mr8150722pgz.400.1541781117353; Fri, 09 Nov 2018 08:31:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541781117; cv=none; d=google.com; s=arc-20160816; b=ek84aHBMd7Qm2suGZXDTzcKNQl5F74Hu2Hhp4Yyhi1SSkZZFaYTZTPUDP9vGlT1h2D R3JAoAdAX4t+jTTuUwHZBIsFgdbxUhOfOzEEWpmy+KRqGzmoaFavaqev3NTgDbphuGzc uvNPzYJqYQxyjWhtPglokO42ti830MsBpsSp+d1FlB+6M21IBO1rRYRBmBiElaUuUhGs NjLC/yBSe9yKafr3wo5XHV+z6GfnD75YGthmVIg0RX2TIjsQbU+SS8LNuXQQjBjWpuhI k5pxlXn8cNJLBR21kHbr/yKkezJ9MjcZBtGsZOtHuCdGbeCcdPlEito0zghpEqjFlHcr IjMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=5h7U3slduPBK5n/6+7/XgBkLWoT8uPR6vNmmaWmTI5I=; b=Dd/o3cdH8BwPm5CNapeykcBbHuLPAjuaoihWmX4zD8kRCG7N9N+QBZCv1fLFt2PdsT p1tyq83g2My1Tl9swM533t+M6LNXjsu/k2cYdGkTBv9DPGdv9OhW4Qg4k3b76XyctS4m ELBREyTi92VPF+i8qsNg6Bnw+gZpLj6GxjQLe19ONsTkw7VKSAAmiAkxi1FBfDbqOqAe DJ3apvC1ruJrt3/cBwzoHJnTYZNuKFdPAxiIXtaKbyppOoBRNK0PSJwsSqMSgqXJdOio 6rMghXpsSXVbof8F8es1OBHQQfhYJJO77jwo3xWKMbaf6IFEk1liaodp48ZZRo/aXeXH CZjg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l11-v6si8264919plt.5.2018.11.09.08.31.26; Fri, 09 Nov 2018 08:31:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728556AbeKJCMS (ORCPT + 99 others); Fri, 9 Nov 2018 21:12:18 -0500 Received: from zimbra.alphalink.fr ([217.15.80.77]:52341 "EHLO zimbra.alphalink.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727845AbeKJCMS (ORCPT ); Fri, 9 Nov 2018 21:12:18 -0500 Received: from localhost (localhost [127.0.0.1]) by mail-2-cbv2.admin.alphalink.fr (Postfix) with ESMTP id 051A22B52055; Fri, 9 Nov 2018 17:30:58 +0100 (CET) Received: from zimbra.alphalink.fr ([127.0.0.1]) by localhost (mail-2-cbv2.admin.alphalink.fr [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id uGi4Sc2yRSTW; Fri, 9 Nov 2018 17:30:56 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail-2-cbv2.admin.alphalink.fr (Postfix) with ESMTP id BC36E2B52140; Fri, 9 Nov 2018 17:30:56 +0100 (CET) X-Virus-Scanned: amavisd-new at mail-2-cbv2.admin.alphalink.fr Received: from zimbra.alphalink.fr ([127.0.0.1]) by localhost (mail-2-cbv2.admin.alphalink.fr [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id fAeFFVqGgJSB; Fri, 9 Nov 2018 17:30:56 +0100 (CET) Received: from c-dev-0.admin.alphalink.fr (94-84-15-217.reverse.alphalink.fr [217.15.84.94]) by mail-2-cbv2.admin.alphalink.fr (Postfix) with ESMTP id 8FBE22B52055; Fri, 9 Nov 2018 17:30:56 +0100 (CET) Received: by c-dev-0.admin.alphalink.fr (Postfix, from userid 1000) id 713EC60188; Fri, 9 Nov 2018 17:30:56 +0100 (CET) Date: Fri, 9 Nov 2018 17:30:56 +0100 From: Guillaume Nault To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, "David S. Miller" , Sasha Levin Subject: Re: [PATCH 4.4 063/114] l2tp: hold socket before dropping lock in l2tp_ip{, 6}_recv() Message-ID: <20181109163056.GE1415@alphalink.fr> References: <20181108215059.051093652@linuxfoundation.org> <20181108215106.791041209@linuxfoundation.org> <20181109153332.GD1415@alphalink.fr> <20181109162856.GA2407@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181109162856.GA2407@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 09, 2018 at 08:28:56AM -0800, Greg Kroah-Hartman wrote: > On Fri, Nov 09, 2018 at 04:33:32PM +0100, Guillaume Nault wrote: > > On Thu, Nov 08, 2018 at 01:51:18PM -0800, Greg Kroah-Hartman wrote: > > > 4.4-stable review patch. If anyone has any objections, please let me know. > > > > > This patch was partly wrong. Here is the followup fix: > > 94d7ee0baa8b ("l2tp: hold tunnel socket when handling control frames in l2tp_ip and l2tp_ip6") > > > > Both a3c18422a4 ("l2tp: hold socket before dropping lock in l2tp_ip{, 6}_recv()") > > and 94d7ee0baa8b ("l2tp: hold tunnel socket when handling control frames in l2tp_ip and l2tp_ip6") > > should be applied/backported together. > > Thanks for letting me know, I've now backported this as well. > Great, it should all be fine now. Thanks.