Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Vineet Gupta <vineet.gupta1@synopsys.com>
To:     "Dmitry V. Levin" <ldv@altlinux.org>,
        Andy Lutomirski <luto@kernel.org>,
        Paul Moore <paul@paul-moore.com>,
        Eric Paris <eparis@redhat.com>
CC:     Elvira Khabirova <lineprinter@altlinux.org>,
        "linux-snps-arc@lists.infradead.org" 
        <linux-snps-arc@lists.infradead.org>,
        "linux-audit@redhat.com" <linux-audit@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 06/13] arc: define syscall_get_arch()
Thread-Topic: [PATCH 06/13] arc: define syscall_get_arch()
Thread-Index: AQHUd9qPWfzlAeDkY06iwsmGassPrQ==
Date:   Fri, 9 Nov 2018 16:50:09 +0000
Message-ID: <C2D7FE5348E1B147BCA15975FBA23075013A59239B@us01wembx1.internal.synopsys.com>
References: <20181109031605.GF21511@altlinux.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 11/8/18 7:16 PM, Dmitry V. Levin wrote:=0A=
> syscall_get_arch() is required to be implemented on all architectures=0A=
> that use tracehook_report_syscall_entry() in order to extend=0A=
> the generic ptrace API with PTRACE_GET_SYSCALL_INFO request.=0A=
>=0A=
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>=0A=
> ---=0A=
>  arch/arc/include/asm/syscall.h | 6 ++++++=0A=
>  include/uapi/linux/audit.h     | 1 +=0A=
>  2 files changed, 7 insertions(+)=0A=
>=0A=
> diff --git a/arch/arc/include/asm/syscall.h b/arch/arc/include/asm/syscal=
l.h=0A=
> index 29de09804306..5662778a7411 100644=0A=
> --- a/arch/arc/include/asm/syscall.h=0A=
> +++ b/arch/arc/include/asm/syscall.h=0A=
> @@ -9,6 +9,7 @@=0A=
>  #ifndef _ASM_ARC_SYSCALL_H=0A=
>  #define _ASM_ARC_SYSCALL_H  1=0A=
>  =0A=
> +#include <uapi/linux/audit.h>=0A=
>  #include <linux/err.h>=0A=
>  #include <linux/sched.h>=0A=
>  #include <asm/unistd.h>=0A=
> @@ -68,4 +69,9 @@ syscall_get_arguments(struct task_struct *task, struct =
pt_regs *regs,=0A=
>  	}=0A=
>  }=0A=
>  =0A=
> +static inline int syscall_get_arch(void)=0A=
> +{=0A=
> +	return AUDIT_ARCH_ARC;=0A=
> +}=0A=
> +=0A=
=0A=
Does ptrace (or user of this API) need a unique value per arch. Otherwise i=
nstead=0A=
of adding the boilerplate code to all arches, they could simply define AUDI=
T_ARCH=0A=
and common code could return it. Also the EM_xxx are not there in=0A=
include/uapi/linux/elf.h to begin with since libc elf.h already defines the=
m.=0A=
=0A=
>  #endif=0A=
> diff --git a/include/uapi/linux/audit.h b/include/uapi/linux/audit.h=0A=
> index 818ae690ab79..a7149ceb5b98 100644=0A=
> --- a/include/uapi/linux/audit.h=0A=
> +++ b/include/uapi/linux/audit.h=0A=
> @@ -375,6 +375,7 @@ enum {=0A=
>  =0A=
>  #define AUDIT_ARCH_AARCH64	(EM_AARCH64|__AUDIT_ARCH_64BIT|__AUDIT_ARCH_L=
E)=0A=
>  #define AUDIT_ARCH_ALPHA	(EM_ALPHA|__AUDIT_ARCH_64BIT|__AUDIT_ARCH_LE)=
=0A=
> +#define AUDIT_ARCH_ARC		(EM_ARC)=0A=
>  #define AUDIT_ARCH_ARM		(EM_ARM|__AUDIT_ARCH_LE)=0A=
>  #define AUDIT_ARCH_ARMEB	(EM_ARM)=0A=
>  #define AUDIT_ARCH_CRIS		(EM_CRIS|__AUDIT_ARCH_LE)=0A=
=0A=
So I don't have the context of this patch (or coverletter) but what exactly=
 are we=0A=
trying to do with this (adding LE to audit)  - what happens when an arch is=
=0A=
capable of either and is say built for BE ?=0A=