Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v4 3/4] drm/virtio: add in/out fence support for explicit
 synchronization
To:     Gerd Hoffmann <kraxel@redhat.com>,
        Emil Velikov <emil.l.velikov@gmail.com>
Cc:     Gustavo Padovan <gustavo.padovan@collabora.com>,
        "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
        ML dri-devel <dri-devel@lists.freedesktop.org>,
        "open list:VIRTIO GPU DRIVER" 
        <virtualization@lists.linux-foundation.org>,
        David Airlie <airlied@linux.ie>,
        Emil Velikov <emil.velikov@collabora.com>
References: <20181105114152.2088-1-robert.foss@collabora.com>
 <20181105114152.2088-4-robert.foss@collabora.com>
 <CACvgo53vCBbgmu4OV4e0WeOYQSXNk=3qwyRBtPx+XAcCSZO8aQ@mail.gmail.com>
 <20181109101354.dc7cv4i4etu3bkhh@sirius.home.kraxel.org>
From:   Robert Foss <robert.foss@collabora.com>
Message-ID: <f5143d56-3e11-51f7-a07a-9106aa8bda49@collabora.com>
Date:   Fri, 9 Nov 2018 18:13:52 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <20181109101354.dc7cv4i4etu3bkhh@sirius.home.kraxel.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hey Gerd,

On 2018-11-09 11:13, Gerd Hoffmann wrote:
> On Mon, Nov 05, 2018 at 05:25:05PM +0000, Emil Velikov wrote:
>> On Mon, 5 Nov 2018 at 11:42, Robert Foss <robert.foss@collabora.com> wrote:
>>>
>>> When the execbuf call receives an in-fence it will get the dma_fence
>>> related to that fence fd and wait on it before submitting the draw call.
>>>
>>> On the out-fence side we get fence returned by the submitted draw call
>>> and attach it to a sync_file and send the sync_file fd to userspace. On
>>> error -1 is returned to userspace.
>>>
>>> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
>>> Signed-off-by: Robert Foss <robert.foss@collabora.com>
>>> Suggested-by: Rob Herring <robh@kernel.org>
>>> Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
>>> ---
>>>
>>> Changes since v3:
>>>   - Move all in_fence handling to the same VIRTGPU_EXECBUF_FENCE_FD_IN block
>> Fwiw my suggestion was to explicitly document whether the IOCTL can
>> support, simultaneously, IN and OUT fence.
> 
> Yes, that would be good.  Code looks like it is supposed to work, but
> explicitly saying so in the commit message would be nice.

On it! Will send out a v5.

> 
> Also: should we use separate fields for in/out fds?

I'm not sure I understand which fields you're referring to.

> 
> cheers,
>    Gerd
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>