To: phil@fifi.org
Cc: trond.myklebust@fys.uio.no, theonetruekenny@yahoo.com,
       linux-kernel@vger.kernel.org, nfs@lists.sourceforge.net
Subject: Re: [NFS client] NFS locks not released on abnormal process
 termination
In-Reply-To: Your message of "09 Dec 2003 00:15:24 -0800"
	<87llpms8yr.fsf@ceramic.fifi.org>
References: <87llpms8yr.fsf@ceramic.fifi.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Date: Thu, 08 Jan 2004 19:47:24 +0900
Message-Id: <1073558844.242410.4086.nullmailer@yamt.dyndns.org>
From: YAMAMOTO Takashi <yamamoto@valinux.co.jp>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 865
Lines: 25

hi,

> +	status = nlmclnt_proc(inode, cmd, fl);
> +	/* If we were signalled we still need to ensure that
> +	 * we clean up any state on the server. We therefore
> +	 * record the lock call as having succeeded in order to
> +	 * ensure that locks_remove_posix() cleans it out when
> +	 * the process exits.
> +	 */
> +	if (status == -EINTR || status == -ERESTARTSYS)
> +		posix_lock_file(filp, fl, 0);
> +	unlock_kernel();
> +	if (status < 0)
> +		return status;

i think it's problematic because you can't assume the lock was
granted on the server and the signaled process might not exit immediately.

YAMAMOTO Takashi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/