Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1122643imu; Fri, 9 Nov 2018 11:17:30 -0800 (PST) X-Google-Smtp-Source: AJdET5eocjZMWilMWeAXAVsRdyCgeZbPRenVKP2AjKXfLzPKU3vwCHW+HnlLN0OEYg7zFAhFIuMi X-Received: by 2002:a63:db02:: with SMTP id e2mr8606451pgg.419.1541791050050; Fri, 09 Nov 2018 11:17:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541791050; cv=none; d=google.com; s=arc-20160816; b=Ub+m+ZVL1neMkWmXjRPzhdMw1aN5UjxSoAKa6I2hSXt/o6DpIgOTlDf6yPX+NWVIYS UPdSk8gHHMirXeg/jCD74VqKTVnFKUa5NQZ8YcRYhbIH4CaIR/uDbwbrj86Df6LnsIWN TCr4fjD6+nZHJgv0CgNCIWxHJEiURriJ6mfv9XKplINmZqESFzdy1nTtXFzwk/hiJoLI JNCwN8f8JeQ5Zq5ab3d0qLDwVHaVWYfqhSm7emMFzdTjwiCJ5c3NDCWuj84wB4td9I4F nII1Y2Myyao7NYcAhh3biak1lWnuH83ZQMZTXIIKa376/rfTXhbP8PwSffw+xsb5Dips XW8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=gMNJMmr6lOSwGBSbXCijcQot18luynoIgohsIvz3D7g=; b=MSUPIQ2t5Re2sHoZ3ZuD4br1S6Fiv9cGRzoBc4Bs8SXvuAoM1dGy79WWyDyfhQymfS r+uonNsyRx2amcnTFgAtC8lNTiV5HhtK1HcVwSv9t+K0JZtUbFXxyD6yWoNY9jbjpzSv i6bjvUwWMKF6yGmsjMJhFqDpGfAo6J4dZYu8z4vqy6mcz7RSbCAGarYfP2acFKUqHEt2 50H/lvsFPq567ud09hydKlCYLsyvW/0oGujZHyahxjg2sFGMaUKQMliGmVXpByMs0Iqr xRnnI42BtRV9qG0ZmHJC84sxLsqV8iox4vMPvrY0r2uAmK3wfE4mKRcTYzkgf7qKbAph cahQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w1-v6si9239965plk.317.2018.11.09.11.17.13; Fri, 09 Nov 2018 11:17:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728795AbeKJE6b (ORCPT + 99 others); Fri, 9 Nov 2018 23:58:31 -0500 Received: from mx2.suse.de ([195.135.220.15]:51824 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727961AbeKJE6b (ORCPT ); Fri, 9 Nov 2018 23:58:31 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 79DCFAF12; Fri, 9 Nov 2018 19:16:33 +0000 (UTC) Date: Fri, 9 Nov 2018 11:16:22 -0800 From: Davidlohr Bueso To: Todd Kjos Cc: chouryzhou@tencent.com, Greg Kroah-Hartman , Arve Hj?nnev?g , Todd Kjos , akpm@linux-foundation.org, "open list:ANDROID DRIVERS" , LKML Subject: Re: [PATCH V3] binder: ipc namespace support for android binder Message-ID: <20181109191622.t4usetsmidtyt7oa@linux-r8p5> References: <5FBCBE569E134E4CA167B91C0A77FD610198F851AC@EXMBX-SZMAIL022.tencent.com> <20181109182654.ojzc7wae3jcivlup@linux-r8p5> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180323 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 09 Nov 2018, Todd Kjos wrote: > >print_binder_proc() drops proc->inner_lock and calls >binder_alloc_print_allocated() which acquires proc->alloc->mutex. >Likewise, print_binder_stats() calls print_binder_proc_stats() which >drops its locks to call binder_alloc_print_pages() which also acquires >proc->alloc->mutex. So binder_procs_lock needs to be a mutex since it >can block on proc->alloc->mutex. Ah, very good then. Thanks, Davidlohr