Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Vineet Gupta <vineet.gupta1@synopsys.com>
To:     "Dmitry V. Levin" <ldv@altlinux.org>,
        Andy Lutomirski <luto@kernel.org>
CC:     Elvira Khabirova <lineprinter@altlinux.org>,
        Alexey Brodkin <alexey.brodkin@synopsys.com>,
        "linux-snps-arc@lists.infradead.org" 
        <linux-snps-arc@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 02/13 v2] Move EM_ARCOMPACT and EM_ARCV2 to
 uapi/linux/elf-em.h
Thread-Topic: [PATCH 02/13 v2] Move EM_ARCOMPACT and EM_ARCV2 to
 uapi/linux/elf-em.h
Thread-Index: AQHUeISdB9NL+B8fI0iDrdKf7mBIdg==
Date:   Fri, 9 Nov 2018 23:42:41 +0000
Message-ID: <C2D7FE5348E1B147BCA15975FBA23075013A592551@us01wembx1.internal.synopsys.com>
References: <20181109031536.GB21511@altlinux.org>
 <C2D7FE5348E1B147BCA15975FBA23075013A59237C@us01wembx1.internal.synopsys.com>
 <20181109214422.GB1907@altlinux.org> <20181109233323.GB2710@altlinux.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 11/9/18 3:33 PM, Dmitry V. Levin wrote:=0A=
> These should never have been defined in the arch tree to begin with, and=
=0A=
> now uapi/linux/audit.h header is going to use EM_ARCOMPACT and EM_ARCV2 i=
n=0A=
> order to define AUDIT_ARCH_ARCOMPACT and AUDIT_ARCH_ARCV2 which are neede=
d=0A=
> to implement syscall_get_arch() which in turn is required to extend the=
=0A=
> generic ptrace API with PTRACE_GET_SYSCALL_INFO request.=0A=
>=0A=
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>=0A=
> ---=0A=
> v2: do not add EM_ARC, move EM_ARCOMPACT and EM_ARCV2 instead.=0A=
>=0A=
>  arch/arc/include/asm/elf.h  | 6 +-----=0A=
>  include/uapi/linux/elf-em.h | 2 ++=0A=
>  2 files changed, 3 insertions(+), 5 deletions(-)=0A=
>=0A=
> diff --git a/arch/arc/include/asm/elf.h b/arch/arc/include/asm/elf.h=0A=
> index aa2d6da9d187..2b80c184c9c8 100644=0A=
> --- a/arch/arc/include/asm/elf.h=0A=
> +++ b/arch/arc/include/asm/elf.h=0A=
> @@ -10,13 +10,9 @@=0A=
>  #define __ASM_ARC_ELF_H=0A=
>  =0A=
>  #include <linux/types.h>=0A=
> +#include <linux/elf-em.h>=0A=
>  #include <uapi/asm/elf.h>=0A=
>  =0A=
> -/* These ELF defines belong to uapi but libc elf.h already defines them =
*/=0A=
> -#define EM_ARCOMPACT		93=0A=
> -=0A=
> -#define EM_ARCV2		195	/* ARCv2 Cores */=0A=
> -=0A=
>  #define EM_ARC_INUSE		(IS_ENABLED(CONFIG_ISA_ARCOMPACT) ? \=0A=
>  					EM_ARCOMPACT : EM_ARCV2)=0A=
>  =0A=
> diff --git a/include/uapi/linux/elf-em.h b/include/uapi/linux/elf-em.h=0A=
> index ba3696e3d694..91b33833630b 100644=0A=
> --- a/include/uapi/linux/elf-em.h=0A=
> +++ b/include/uapi/linux/elf-em.h=0A=
> @@ -34,6 +34,7 @@=0A=
>  #define EM_M32R		88	/* Renesas M32R */=0A=
>  #define EM_MN10300	89	/* Panasonic/MEI MN10300, AM33 */=0A=
>  #define EM_OPENRISC     92     /* OpenRISC 32-bit embedded processor */=
=0A=
> +#define EM_ARCOMPACT	93	/* ARCompact processor */=0A=
>  #define EM_BLACKFIN     106     /* ADI Blackfin Processor */=0A=
>  #define EM_ALTERA_NIOS2	113	/* Altera Nios II soft-core processor */=0A=
>  #define EM_TI_C6000	140	/* TI C6X DSPs */=0A=
> @@ -42,6 +43,7 @@=0A=
>  #define EM_TILEPRO	188	/* Tilera TILEPro */=0A=
>  #define EM_MICROBLAZE	189	/* Xilinx MicroBlaze */=0A=
>  #define EM_TILEGX	191	/* Tilera TILE-Gx */=0A=
> +#define EM_ARCV2	195	/* ARCv2 Cores */=0A=
>  #define EM_RISCV	243	/* RISC-V */=0A=
>  #define EM_BPF		247	/* Linux BPF - in-kernel virtual machine */=0A=
>  #define EM_FRV		0x5441	/* Fujitsu FR-V */=0A=
=0A=
Seems OK in theory - but now we are exporting these to uapi and per my orig=
inal=0A=
comment there were redef errors with libc elf.h atleast. Perhaps this being=
 a=0A=
different header might be OK !=0A=
=0A=
Acked-by: Vineet Gupta <vgupta@synopsys.com>=0A=
=0A=
=0A=
=0A=