Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2903308imu; Sun, 11 Nov 2018 03:36:10 -0800 (PST) X-Google-Smtp-Source: AJdET5dX6k1Bqo/fC7rYkw93pOkrHkNFORlCs1HicurxgarpnZInD9C+ETm76JlnmBifG16/Y+bt X-Received: by 2002:a62:be18:: with SMTP id l24-v6mr15631923pff.51.1541936170319; Sun, 11 Nov 2018 03:36:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541936170; cv=none; d=google.com; s=arc-20160816; b=yb9MgYpxoUi8ZiWiOmc19bcwa7T2vTq42hUgfbeiPK4TK398J5nLzxedcwEDYlEJzH 60V9uTbL/jAn/cIh4JYvQjwVAsE+yI8mlFBNZpAtZgCwVjrGWotb/ZDLH/oKVlm7YLbY RjqKEMufpGu+cXgq9f+drB22Nz13BmvajwRWl9+UX/fl9m59ohSzy4CNGJbGu5mxMh5i o80itQGXllBjPoKHwHyPT2hNoYPx40aIh7oZnpNsvZfWHzs/sWFlx/lQk9QMRIBmBLdR dlDnhF8MjoIv0bx8scjBrzCUN/vSfdu3WHqAfuKi84My/lJUxS2fy6aO9vVIh6iSUc6y n8pQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=UgzPb56qCMnh1KnJPS+3qw8EKS8OHdU7b5dgCpdjW+k=; b=wbFQlRILWZkA5tV0Y1mBxw1EvU9F14DOq1fgiZ50g56u+8kAF9Mjuq3kmzN7qUL/3P Unj0oGsDPf+8L+rjoN2eTrjgk7eAkHkCgBLP4e48TBuv74IgiQvj/RIp4eze4b+AE2/w gFXJgJPK5J36ypjjqyhsd1z7IFohtjBPgMkLANhH9awoWmWL1KmgIY0OL1F50FG0zn6k adS2lhgwt2SlZzA3JsofFR+rleLSWUZbeeOMzkI18b4rkt8z9IAUI6rLhTfSnQtmQlrB oYA3YSwf+VKwUntPPfZUnGPXebPNIi7sK970uu4H9TSdxXoCFOI1MWOGTXSCZLBmeRx1 iIIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=D2Ra6CWa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x6-v6si14456497plo.164.2018.11.11.03.35.54; Sun, 11 Nov 2018 03:36:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=D2Ra6CWa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727727AbeKKVWi (ORCPT + 99 others); Sun, 11 Nov 2018 16:22:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:45754 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727492AbeKKVWi (ORCPT ); Sun, 11 Nov 2018 16:22:38 -0500 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 56917208A3; Sun, 11 Nov 2018 11:34:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1541936059; bh=X77+7lgy5nZlaPnz/VldXKUfEbmr8FiqJv5GcM+fh40=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=D2Ra6CWaejPBqTPw5tVjReREdnxDHdp0x08OT7UrvR9gH6e8u3HEeuk7FGL+8Vyec Sg33EMmgZzuLJeRsJ+MLrjzJKJugb1CYKoaXMErSxxeojjbNgIZ6Wpmiiv2O4bbKeD U3N7ipekLTQiYwOPcBYGnAtGGXCHQ/H1Xpj/g3T0= Date: Sun, 11 Nov 2018 11:34:13 +0000 From: Jonathan Cameron To: Matheus Tavares Cc: Lars-Peter Clausen , Michael Hennerich , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman , Rob Herring , Mark Rutland , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandru Ardelean , kernel-usp@googlegroups.com, victorcolombo@gmail.com Subject: Re: [PATCH 0/6] staging:iio:ad2s90: Add dt support and move out of staging Message-ID: <20181111113413.46e1070f@archlinux> In-Reply-To: <20181109220044.24843-1-matheus.bernardino@usp.br> References: <20181109220044.24843-1-matheus.bernardino@usp.br> X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 9 Nov 2018 20:00:38 -0200 Matheus Tavares wrote: > This patch set adds device tree support to ad2s90, with standard > device tree id table, adds the respective dt-binding documentation, > solves a codestyle warning and move the driver out of staging. > > This patch set completes all the remaining itens listed to be done > before moving the driver out of staging, enumerated in this mail thread: > https://marc.info/?l=linux-iio&m=154028966111330&w=2, except by one > codestyle problem: "CHECK: struct mutex definition without comment". It > seems to be a commonly ignored check for mutexes of device states. If I > am wrong, please, let me know and I will be happy to send a patch to > tackle it. It should be commented. Device state is not actually all that well defined and means different things in different drivers. Here it is very straight forward as it's role is to protect the buffer. There is no other state maintained. Jonathan > > Matheus Tavares (6): > staging:iio:ad2s90: Add device tree support > staging:iio:ad2s90: Remove spi setup that should be done via dt > staging:iio:ad2s90: Add max frequency check at probe > dt-bindings:iio:resolver: Add docs for ad2s90 > staging:iio:ad2s90: Add SPDX license identifier > staging:iio:ad2s90: Move out of staging > > .../bindings/iio/resolver/ad2s90.txt | 26 ++++++++++++++++ > drivers/iio/resolver/Kconfig | 10 ++++++ > drivers/iio/resolver/Makefile | 1 + > drivers/{staging => }/iio/resolver/ad2s90.c | 31 ++++++++++++------- > drivers/staging/iio/resolver/Kconfig | 10 ------ > drivers/staging/iio/resolver/Makefile | 1 - > 6 files changed, 57 insertions(+), 22 deletions(-) > create mode 100644 Documentation/devicetree/bindings/iio/resolver/ad2s90.txt > rename drivers/{staging => }/iio/resolver/ad2s90.c (81%) >