Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3074290imu; Sun, 11 Nov 2018 07:07:18 -0800 (PST) X-Google-Smtp-Source: AJdET5f6nQj49OdKsQFBec8hAWvfj20d1TSva5AJGFx6O9BfAh4+NmFfcQbktgHPcTUJuEghohAc X-Received: by 2002:a63:5153:: with SMTP id r19mr14184675pgl.281.1541948838149; Sun, 11 Nov 2018 07:07:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541948838; cv=none; d=google.com; s=arc-20160816; b=qH8EaU+mwVvQJtrgzNvhQJjDPaNM0K+GsGzmwYA8jqs2eE/nk2NzMsiiPXPwd7nypH qe32oawYJjWHCxqW4LDfX8zShFO6bbs8RhRbE1xJ6p7NHjMb/G4rTY6/8Gu9FbWLl1zZ mZ3/ftSpHvaOFrGRAPXBx8aGHhS7HARe4XDPqvzRnYZeow0R09UD9KsJaRsfEt9xXXMB uE1E8aDRva5jCFBVOber7neaXdAA+oqL3GqS0hrXsnLbJSXiA+jZWrurlTQDOKN/B+y5 JjwY2zEYmw0Z45ki3mbRMlYzDfZi31hzLnizqV9bRThWJe3WRK3h/sWzHSL6xOTRW0OV sEZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=0ovwV35Xn0e0qGMt+qUC2132b33I1s8tGmrH3ihBEv8=; b=PkRCZM8QQlMOdxStnd+A+R12B3ETaFSQWr8VtsQxbNsOrnf3xEW7jehB8HYOyn8nkO wNpPwboD1kRGrAG52HT4H7izigSqJEss2DbMjlJul8hd+KO4xbDON2K8ELugkCTgWSSd bz2OUhXyeb3aOqsZ8FDSlwS16aiuCjQ5Lnl3f09L3Xjg8F36rHmZbJQQzzdBwJ2o7DnF KaULGhKziheHEHJ1pbAsGVv7UjVplwyEmOdfA0V9sUWPEIUMQHAjs3rOKEbtikDPB842 n6DyfCiUPKB/Ab3W3u8xeliOi6mZV4hIZrgGDrHv7l8FbAOYEhz2x7vDKfUGOx+Rke1o o3iQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=CmY0bn7q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k83-v6si15407486pfj.115.2018.11.11.07.07.02; Sun, 11 Nov 2018 07:07:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=CmY0bn7q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728668AbeKLAyq (ORCPT + 99 others); Sun, 11 Nov 2018 19:54:46 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:33650 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728440AbeKLAyq (ORCPT ); Sun, 11 Nov 2018 19:54:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=0ovwV35Xn0e0qGMt+qUC2132b33I1s8tGmrH3ihBEv8=; b=CmY0bn7qzTsuSq+yYNo/A0Uck CFdb3Ux7TU2WaRjCk5UiLI00RvzqvSwQsb6japUhYGLGmtln4DWKQEaaARM6F+/DXbNT/7W27ugaY 9xg4UdXREN4Xj3XwYkxbW3SxTFcWSognXzIhiu0yb/WRlUsvQgIybl/EXsePSWPMaDY/AwZSMhCtS EEWk9EV1QRuNetlrLWIr3yxge3B5Hnj5ZV6gaZbaDU6jIBI7XkfB/kyrLHK7N40WNwjDRAkeBjZU2 Tg4jIMmNcr7kWC8/oacdJgWln+SUBQkiFcMPkU4hFlvgtkNu6mTBTa8mEoL+Nu5vCJRdRFiZgJujV J0LX18KSw==; Received: from [64.114.255.97] (helo=worktop) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gLrJC-0003Rl-Mn; Sun, 11 Nov 2018 15:05:54 +0000 Received: by worktop (Postfix, from userid 1000) id F09876E03B0; Sun, 11 Nov 2018 16:05:53 +0100 (CET) Date: Sun, 11 Nov 2018 16:05:53 +0100 From: Peter Zijlstra To: Nadav Amit Cc: Ingo Molnar , linux-kernel@vger.kernel.org, x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Borislav Petkov , Dave Hansen , Andy Lutomirski , Kees Cook , Dave Hansen , Masami Hiramatsu Subject: Re: [PATCH v4 09/10] x86/jump-label: remove support for custom poker Message-ID: <20181111150553.GB3021@worktop> References: <20181110231732.15060-1-namit@vmware.com> <20181110231732.15060-10-namit@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181110231732.15060-10-namit@vmware.com> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 10, 2018 at 03:17:31PM -0800, Nadav Amit wrote: > There are only two types of poking: early and breakpoint based. The use > of a function pointer to perform poking complicates the code and is > probably inefficient due to the use of indirect branches. Right; we used to have a 3rd way, but that is long gone. Nice cleanup!