Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3238026imu; Sun, 11 Nov 2018 10:25:58 -0800 (PST) X-Google-Smtp-Source: AJdET5ftfxYSaoWeyi91RCfUg7iafSg+niRU/R4F8Jny390dOhnYHzbDX9Y3qu2yllvLokUOdf0f X-Received: by 2002:a17:902:9a9:: with SMTP id 38-v6mr13796576pln.180.1541960758912; Sun, 11 Nov 2018 10:25:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541960758; cv=none; d=google.com; s=arc-20160816; b=kv/3QwhJW1gH8u/eTTy8U73O0VFPWer0zBw7gciDscqiRrcZE3ZpFH4mCX11AjwL6/ f+Zwy550bxq5BDOolbtPDdgSU660tnbwF9SH05PAxvPy2WVZCJ+NTVrtKo0meJaA9fdg JDbXltqTAjqaaMclSiyjuEYjUqswoDHJSyuhGVkNDK5dFMD9fdsEDIaiZgA33WGNbtXC 2w/Jn/4nlv/tbb2C03B1mvBmhVunyKK6dOZFQQIyl1K85Lu/VxEFP7O0qjGcz2jyEtdM RmDH776mBNLrU6Jw3fAquQz2E3G/vUMb8fNLCYCG8mBQzHMlo4cg49ukE5u0386iBppZ sYBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:to:from:subject:message-id :dkim-signature; bh=Y9xs5y37yvZss6JwvUprH08as3g/l7HLkU4gRR+hKLU=; b=ENumKwNXfS3JDhBn3nzwyUqd+rfIc+avsdUVr01SVOVIdLEKp1+r3g2OXrKq2Sar+4 vynZzo47erAqDxM7vKCZGMuUkYca9oGxaAZsok7vca2B4FZTuRPJ8W9IdnDE7mfXplnH SohZ0WC4envPXPXI1DTDsGcLqvJA/V9TOevafXrgQ/VdlOSM68syGvYavlcony4aPpOq B71o2wtgkwzLeFwYAw2KpdFPdF2+U8BlvW5p8giFei9eYfyP/1RyFOOoFCdNixAPCsMH GionJ0uiGw0dFf5kefFxoQ35PSlalXJVzHW8GwHT1lJuNVgcedYRY8E2ZpndeOjaoEw7 aWVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@hansenpartnership.com header.s=20151216 header.b=iX52asNx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=hansenpartnership.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s123-v6si15912084pfb.178.2018.11.11.10.25.43; Sun, 11 Nov 2018 10:25:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@hansenpartnership.com header.s=20151216 header.b=iX52asNx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=hansenpartnership.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729451AbeKLEOH (ORCPT + 99 others); Sun, 11 Nov 2018 23:14:07 -0500 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:48998 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726827AbeKLEOG (ORCPT ); Sun, 11 Nov 2018 23:14:06 -0500 Received: from localhost (localhost [127.0.0.1]) by bedivere.hansenpartnership.com (Postfix) with ESMTP id 9D8128EE12F; Sun, 11 Nov 2018 10:24:51 -0800 (PST) Received: from bedivere.hansenpartnership.com ([127.0.0.1]) by localhost (bedivere.hansenpartnership.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sRHXc2ooIewI; Sun, 11 Nov 2018 10:24:51 -0800 (PST) Received: from [153.66.254.194] (unknown [50.35.68.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bedivere.hansenpartnership.com (Postfix) with ESMTPSA id DD3948EE0A4; Sun, 11 Nov 2018 10:24:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=hansenpartnership.com; s=20151216; t=1541960691; bh=I9/BiyczoT2XcDSKy15gvgIRtzA296LJokk7X+nT730=; h=Subject:From:To:Date:In-Reply-To:References:From; b=iX52asNxW650W3KAbqErOBSrInpdXVuFKgmy2sZq+wP+EkUx0Zh3bBRQAviu6FGo8 7PQpXgMMMbyRaWYFIFfSdRhHY0VzRvqi65EgtXuTiiCmhV7nA5gP/26fg4MuPvj32z 6oXe3292xHof2noByQBntIUBbZX3pAiTakCQCjCE= Message-ID: <1541960689.3190.4.camel@HansenPartnership.com> Subject: Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working From: James Bottomley To: Michael =?ISO-8859-1?Q?Niew=F6hner?= , peterhuewe@gmx.de, jarkko.sakkinen@linux.intel.com, jgg@ziepe.ca, arnd@arndb.de, linux-integrity@vger.kernel.org, linux-kernel Date: Sun, 11 Nov 2018 10:24:49 -0800 In-Reply-To: <776f384a81466642472beb4a34b10f26f1de88e9.camel@mniewoehner.de> References: <776f384a81466642472beb4a34b10f26f1de88e9.camel@mniewoehner.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.6 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2018-11-11 at 18:55 +0100, Michael Niewöhner wrote: > Hi all, > > Nuvoton NCPT650 does not work in TPM 2.0 mode with tpm_tis / > tpm_i2c_nuvoton while it works in TPM 1.2 mode (I can reflash it via > UEFI setup). Kernel version is 4.19.1 Not that this helps you, but mine definitely works. I've got an older Dell XPS-13 with a Nuvoton 650 which is software switchable between 1.2 and 2.0. This is what mine says jejb@jarvis:~> dmesg|egrep -i tis\|tpm\|crb [ 0.000000] efi: ACPI=0x79419000 ACPI 2.0=0x79419000 SMBIOS=0xf0000 TPMEventLog=0x69db3018 [ 0.012797] ACPI: TPM2 0x0000000079446CC0 000034 (v03 Tpm2Tabl 00000001 AMI 00000000) [ 2.035242] tpm_tis MSFT0101:00: 2.0 TPM (device-id 0xFE, rev-id 2) However, this makes me wonder about yours: > [ 0.003517] ACPI: TPM2 0x000000009E490ED8 000034 (v03 LENOVO TC- > S06 00001300 AMI 00000000) I thought the Lenovo "upgrade to 2.0" in fact disabled the external TPM in favour of the Intel PTT (software TPM in the management engine). Since you apparently have the tpm_crb driver that should find the PTT TPM, this might be one of the attachment bugs in the CRB driver ... from your ACPI output it looks to be not specifying the Tpm2Tabl. James