Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3238944imu; Sun, 11 Nov 2018 10:27:18 -0800 (PST) X-Google-Smtp-Source: AJdET5dpF5lUTQXgI7cWwXT/a2pr8h7E22+1KbYiIzHlExF7IBbgEKHfZBIYpvxCeEe32KW1XKXl X-Received: by 2002:a17:902:67:: with SMTP id 94-v6mr16528694pla.225.1541960838355; Sun, 11 Nov 2018 10:27:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541960838; cv=none; d=google.com; s=arc-20160816; b=eTd/WVUmQH8gOvcjrui8dXTB8VXw7ncRTaVsHoPwG/4Pss4QcLcUMajOtmogo3X9vn Gx+miIVQxNycauY1lQw1K7e3/wwU9Ik7ca8ZOsqvulvdrSuCEevjEfGmCOLv+htSVnQL mWkYyiNJqVB4fhbitmm6zEVz3dwzeouWRjOqOzD4CesQMrmE31KkqyyzOKnG5GfZiTeq OD9OsUfG29/tnM+VnjybfQtxM6VE/Uyuy6PSkFIQ4kUZzzeR4ZYKvJAkjG95u4jVjzWC uANfKaX7zbMhyFJaSsoKmmmhhxbr6G4EE7lVBUbe/i0oqEhg1J8F3L71HIficsBrMwGN pF7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=EU/PJxd8Lz+lFF3MwSSuUdrNGxbaqqOENjnyO8aa5Fg=; b=YG1K8dQ0FhVTv+WfwCG7o+ySPJNRft9hdyeNZON6ZGdD8uB2z1l2I5R7Ywhm16c0Tl 9fVM79qUiO2rIn72Iui+gj27J1b5zjZJYS6aCYSD7bN2Ifs4HykR74/OHqSOWuY9gJpV +Tj8M2nArGmQzHhH3kV6gSqWJ4hh2nuOX8MESS5SaD3DCAcQchsbX7cxoEmoZ6Lt43+l Z2o92EHhBRVKwt8VAzgXHTsiXoje3F12hPGGDkehOIC/vqlzLWnsoc/y9V78bN2BlU8c rxNn/avNEbGkF3/17T6wcFGIh4n1sqf62z3eR7HruN33eoXe4oVDZgcRGWblbk+A4tFp XByQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b1-v6si11057747plc.292.2018.11.11.10.27.02; Sun, 11 Nov 2018 10:27:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729464AbeKLEPr (ORCPT + 99 others); Sun, 11 Nov 2018 23:15:47 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:37978 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726283AbeKLEPr (ORCPT ); Sun, 11 Nov 2018 23:15:47 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::cf9]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id DBB81141E1411; Sun, 11 Nov 2018 10:26:31 -0800 (PST) Date: Sun, 11 Nov 2018 10:26:31 -0800 (PST) Message-Id: <20181111.102631.2180605944722637653.davem@davemloft.net> To: laoar.shao@gmail.com Cc: edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, joe@perches.com Subject: Re: [PATCH net-next v2] tcp: minor optimization in tcp ack fast path processing From: David Miller In-Reply-To: <1541938210-11797-1-git-send-email-laoar.shao@gmail.com> References: <1541938210-11797-1-git-send-email-laoar.shao@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 11 Nov 2018 10:26:32 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yafang Shao Date: Sun, 11 Nov 2018 20:10:10 +0800 > Bitwise operation is a little faster. > So I replace after() with using the flag FLAG_SND_UNA_ADVANCED as it is > already set before. > > In addtion, there's another similar improvement in tcp_cwnd_reduction(). > > Cc: Joe Perches > Suggested-by: Eric Dumazet > Signed-off-by: Yafang Shao Applied.