Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3293859imu; Sun, 11 Nov 2018 11:45:01 -0800 (PST) X-Google-Smtp-Source: AJdET5cFqMPXALxFJMTHoIIPLMp5yFBIefkEzKoHtlzlu+YAT2gksiPNqbtepDMH1JJ9yqyFf6ty X-Received: by 2002:a63:61c8:: with SMTP id v191mr15116712pgb.242.1541965501516; Sun, 11 Nov 2018 11:45:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541965501; cv=none; d=google.com; s=arc-20160816; b=iCzfpt51LLuQe4d9tUzDB2MxgZPcCuuFi4B96FAld9hn40DKi8VJGYWOeXXS8jxUrv 8+5F9Z+mLzeZGFyPcgsNBwBOrVASOy/42Bq6gMokenF86aiFMHltL/q8uGr5rj/+Z+nM wKZ8l6i2KoJvAPalPCpM2AaGwhxYMSrKNkz5sV4vSfYSp27sPwMY4oyDOIku9MzRVvBG ovIxCQoDAPDPqjqBl+C8QMGPKyhj6/gtqKwg/7/2H2qnO58UNIVtATi8REQffWm8zOfj 82IzAd0s8T14c5DIviDjGdPRn7u0I1UhwbHB5C/KP0fNQZaV4LgFpqFG3QkuPri3MHva CDHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:references:in-reply-to:date :subject:cc:to:from; bh=1R9Gmpk5kTEQXGvwUD2gJc4NjFeR5Jxp0q0dCCMuBvk=; b=QkGSJ7cEb3uZq6unbhyoEom9bdzWk0S45SF5/Wca4m1kJgThBpdhbr7ZsVLMvCb0IK KHp7Nn95gVJr8s0FX5hIkGmlJq3MWUuey63n7E0zlR9ZBCUlC1YUiWx4/tWGZFwf1GTy hYsxmmxyz0w5wBJT1LGXhCxscwawjpVTT1yUXeXT9eJ03ITvR9ctEreivFQvGVDOtDfe r2ztf93D9OcFjpHEmsuM1oiNEbKh7nOKxV/XyyUth7HlmhFCLLK5WgwzpxrxOufSu26M lJH0cUxCq+A8xh5fiA6x5bRBZGy7iV1d9RdQhnxhGgPy2qu6IZDO0/vgNEIILD/UMnOf pWgQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n185-v6si15191137pfn.83.2018.11.11.11.44.46; Sun, 11 Nov 2018 11:45:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729603AbeKLFdv (ORCPT + 99 others); Mon, 12 Nov 2018 00:33:51 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:53976 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727226AbeKLFds (ORCPT ); Mon, 12 Nov 2018 00:33:48 -0500 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id wABJi9pi010024 for ; Sun, 11 Nov 2018 14:44:21 -0500 Received: from e17.ny.us.ibm.com (e17.ny.us.ibm.com [129.33.205.207]) by mx0a-001b2d01.pphosted.com with ESMTP id 2npde81u9g-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 11 Nov 2018 14:44:21 -0500 Received: from localhost by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 11 Nov 2018 19:44:20 -0000 Received: from b01cxnp22034.gho.pok.ibm.com (9.57.198.24) by e17.ny.us.ibm.com (146.89.104.204) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Sun, 11 Nov 2018 19:44:15 -0000 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id wABJiDSJ1180128 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 11 Nov 2018 19:44:14 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C204FB2066; Sun, 11 Nov 2018 19:44:13 +0000 (GMT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8C4ADB2064; Sun, 11 Nov 2018 19:44:13 +0000 (GMT) Received: from paulmck-ThinkPad-W541 (unknown [9.85.207.24]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Sun, 11 Nov 2018 19:44:13 +0000 (GMT) Received: by paulmck-ThinkPad-W541 (Postfix, from userid 1000) id 4CC4D16C5DB7; Sun, 11 Nov 2018 11:44:13 -0800 (PST) From: "Paul E. McKenney" To: linux-kernel@vger.kernel.org Cc: mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com, joel@joelfernandes.org, "Paul E. McKenney" , Tejun Heo , Jens Axboe , Dennis Zhou , Johannes Weiner , "Dennis Zhou (Facebook)" Subject: [PATCH tip/core/rcu 36/41] cgroups: Replace synchronize_sched() with synchronize_rcu() Date: Sun, 11 Nov 2018 11:44:05 -0800 X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181111194104.GA4787@linux.ibm.com> References: <20181111194104.GA4787@linux.ibm.com> X-TM-AS-GCONF: 00 x-cbid: 18111119-0040-0000-0000-0000049088D5 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00010028; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000270; SDB=6.01116019; UDB=6.00577119; IPR=6.00896119; MB=3.00024114; MTD=3.00000008; XFM=3.00000015; UTC=2018-11-11 19:44:19 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18111119-0041-0000-0000-000008999183 Message-Id: <20181111194410.6368-36-paulmck@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-11-11_13:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=625 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1811110188 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Now that synchronize_rcu() waits for preempt-disable regions of code as well as RCU read-side critical sections, synchronize_sched() can be replaced by synchronize_rcu(). This commit therefore makes this change, even though it is but a comment. Signed-off-by: Paul E. McKenney Cc: Tejun Heo Cc: Jens Axboe Cc: Dennis Zhou Cc: Johannes Weiner Cc: "Dennis Zhou (Facebook)" --- kernel/cgroup/cgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index 6aaf5dd5383b..7a8429f8e280 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -5343,7 +5343,7 @@ int __init cgroup_init(void) cgroup_rstat_boot(); /* - * The latency of the synchronize_sched() is too high for cgroups, + * The latency of the synchronize_rcu() is too high for cgroups, * avoid it at the cost of forcing all readers into the slow path. */ rcu_sync_enter_start(&cgroup_threadgroup_rwsem.rss); -- 2.17.1