Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3295488imu; Sun, 11 Nov 2018 11:47:14 -0800 (PST) X-Google-Smtp-Source: AJdET5ftn5WMnqaFzxT1imzR4Es4/01PXJz1BMCV/QhhmtCJf8tVC4Zv93AIgJi8tgCBEBOvweuH X-Received: by 2002:a65:5c81:: with SMTP id a1-v6mr14728985pgt.390.1541965634356; Sun, 11 Nov 2018 11:47:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541965634; cv=none; d=google.com; s=arc-20160816; b=WckbaT6kL8zLwn+JUddXdWnZIgCqqAbkyLYAG9A3mHORU50xKwZ/opobM8liHMZ/uV jNinFRkAZ3zGxIYYN1SgnMFOLX+gUxXAXYeUddWqIQ5BYq4GykBDtl1cs5+XB8npNqqp YTEhayHmE3X6BBA3SpVzRd98lY19oOK9v278nBAmyLiCu9kc8q1Q/E4CVzlHb3qzFQkI +yKnsPNxwsJoH8uvzh5DwCOkFSb5IjRHftNB2QoyKoMkeZmn7om8BaMX6G03Ya77HuOs JYbzmUobaT898DK5rWPADbDh+QN7/+FoyJ/mH0rsNaRd6PfZLrrc1AwfRKTY/3snpE0F /nTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:references:in-reply-to:date :subject:cc:to:from; bh=8fN+J6IQ/rOKEn4q+s1uAazELsJ86XprLTo04MglkFs=; b=KCFizfSn8cRDQov+HiZVkBMCnNHx7B2M0UjGSaH4rhK1tEuZMSFIsrAMXTorqPRLvx BHkXDPwab2oyNHob3QxfbtCst93lqrn0qWR925EfEacgodTTabn44w2LZHFJe8vcl4rq HEfh+//J/zmtwY0iCZ/JmuGlck9Fd/j9W4R8aWhPIqhl1jVljfOSTiM5oFQKZrRIuO2h zNCmmOnafzQ35b4GsFKhBdutHNOHLTjkX+j2YS9znRe6GCIA8piFKcmb9A7SC6Z9hjv2 OyL2gayA36Sz8Z04twPSNYvQ7zKcZLY9cpkgVBPp30ZEsSBiB5XlGjTLtTyeS4ci/lS6 x77Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k11si10032403pgh.132.2018.11.11.11.46.59; Sun, 11 Nov 2018 11:47:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729705AbeKLFfc (ORCPT + 99 others); Mon, 12 Nov 2018 00:35:32 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:56580 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727278AbeKLFdr (ORCPT ); Mon, 12 Nov 2018 00:33:47 -0500 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id wABJiKu6116573 for ; Sun, 11 Nov 2018 14:44:22 -0500 Received: from e11.ny.us.ibm.com (e11.ny.us.ibm.com [129.33.205.201]) by mx0a-001b2d01.pphosted.com with ESMTP id 2npdv7rvuf-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 11 Nov 2018 14:44:21 -0500 Received: from localhost by e11.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 11 Nov 2018 19:44:20 -0000 Received: from b01cxnp23032.gho.pok.ibm.com (9.57.198.27) by e11.ny.us.ibm.com (146.89.104.198) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Sun, 11 Nov 2018 19:44:14 -0000 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id wABJiDMF26935432 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 11 Nov 2018 19:44:13 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CEC3EB2072; Sun, 11 Nov 2018 19:44:13 +0000 (GMT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 97C62B2067; Sun, 11 Nov 2018 19:44:13 +0000 (GMT) Received: from paulmck-ThinkPad-W541 (unknown [9.85.207.24]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Sun, 11 Nov 2018 19:44:13 +0000 (GMT) Received: by paulmck-ThinkPad-W541 (Postfix, from userid 1000) id 59E9016C5DBA; Sun, 11 Nov 2018 11:44:13 -0800 (PST) From: "Paul E. McKenney" To: linux-kernel@vger.kernel.org Cc: mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com, joel@joelfernandes.org, "Paul E. McKenney" , John Fastabend , Daniel Borkmann , "David S. Miller" , netdev@vger.kernel.org Subject: [PATCH tip/core/rcu 38/41] net/core/skmsg: Replace call_rcu_sched() with call_rcu() Date: Sun, 11 Nov 2018 11:44:07 -0800 X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181111194104.GA4787@linux.ibm.com> References: <20181111194104.GA4787@linux.ibm.com> X-TM-AS-GCONF: 00 x-cbid: 18111119-2213-0000-0000-00000315A7EB X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00010028; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000270; SDB=6.01116019; UDB=6.00578733; IPR=6.00896120; MB=3.00024114; MTD=3.00000008; XFM=3.00000015; UTC=2018-11-11 19:44:19 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18111119-2214-0000-0000-00005C386BBE Message-Id: <20181111194410.6368-38-paulmck@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-11-11_13:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1811110188 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Now that call_rcu()'s callback is not invoked until after all preempt-disable regions of code have completed (in addition to explicitly marked RCU read-side critical sections), call_rcu() can be used in place of call_rcu_sched(). This commit therefore makes that change. Signed-off-by: Paul E. McKenney Cc: John Fastabend Cc: Daniel Borkmann Cc: "David S. Miller" Cc: --- net/core/skmsg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/skmsg.c b/net/core/skmsg.c index 56a99d0c9aa0..c92d6ccce610 100644 --- a/net/core/skmsg.c +++ b/net/core/skmsg.c @@ -580,7 +580,7 @@ void sk_psock_drop(struct sock *sk, struct sk_psock *psock) write_unlock_bh(&sk->sk_callback_lock); sk_psock_clear_state(psock, SK_PSOCK_TX_ENABLED); - call_rcu_sched(&psock->rcu, sk_psock_destroy); + call_rcu(&psock->rcu, sk_psock_destroy); } EXPORT_SYMBOL_GPL(sk_psock_drop); -- 2.17.1