Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 05/24] dt-bindings: sc27xx-blt: Add function and color
 properties
To:     Pavel Machek <pavel@ucw.cz>
Cc:     linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, robh@kernel.org,
        Xiaotong Lu <xiaotong.lu@spreadtrum.com>,
        Baolin Wang <baolin.wang@linaro.org>
References: <1541542052-10081-1-git-send-email-jacek.anaszewski@gmail.com>
 <1541542052-10081-6-git-send-email-jacek.anaszewski@gmail.com>
 <20181111142941.GA5215@amd>
From:   Jacek Anaszewski <jacek.anaszewski@gmail.com>
Message-ID: <c6e09153-eb16-640f-3ebe-81b533408a73@gmail.com>
Date:   Sun, 11 Nov 2018 21:03:28 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20181111142941.GA5215@amd>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Pavel.

On 11/11/2018 03:29 PM, Pavel Machek wrote:
> On Tue 2018-11-06 23:07:13, Jacek Anaszewski wrote:
>> Refer to new "function" and "color" properties and mark "label"
>> as deprecated.
>>
>> Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
>> Cc: Xiaotong Lu <xiaotong.lu@spreadtrum.com>
>> Cc: Baolin Wang <baolin.wang@linaro.org>
> 
> Don't you want to keep both color and label? New dts on old kernel
> should still work...?
> 
> Ok, I see these are only examples....

Right, this is only an example, and we'd rather want to encourage
people to switch to using new LED naming.

>> @@ -25,17 +27,17 @@ led-controller@200 {
>>  	reg = <0x200>;
>>  
>>  	led@0 {
>> -		label = "red";
>> +		color = "red";
>>  		reg = <0x0>;
>>  	};
>>  
>>  	led@1 {
>> -		label = "green";
>> +		color = "green";
>>  		reg = <0x1>;
>>  	};
>>  
>>  	led@2 {
>> -		label = "blue";
>> +		color = "blue";
>>  		reg = <0x2>;
>>  	};
>>  };
> 

-- 
Best regards,
Jacek Anaszewski