Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3309593imu; Sun, 11 Nov 2018 12:05:47 -0800 (PST) X-Google-Smtp-Source: AJdET5eirycRxuPrwD4dPHzJM1mA2NpEv/TAqoeC/6ORmk9rKECk3JZTcak7eI8RyeYRh7LOaMET X-Received: by 2002:a63:3287:: with SMTP id y129mr15175355pgy.337.1541966747142; Sun, 11 Nov 2018 12:05:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541966747; cv=none; d=google.com; s=arc-20160816; b=TvsDSeRVun1GqM8yTPmLpM10e7KSywr1rGtTMu0RE2AbpxCK5u/XRQX9lK0C/4pk4f FI24RjY59oiMET4yw6N5lNMESxcirE2ktjnHaTcsI0wlfxd2FxzHph8MXwqktUZY55XZ IxOGtD/wLjWyeOiOuhUfu9vd8ZirbAX9YSHtD0y2q7G9EW1GtZz0vMvdX9nLj/NhmY3Z 4mib+mB7+JyXVo+fAvAbBHbLWuuyutfHZo/VJfh4vwuozhLdABnk6XJ1o+V4FrinFov3 CSzPEC6B0ejQhyB5nv+aapp1ThQnvrxvqHmBG6jMWn2OQTDBS3UyHTQS1poBTrE4F9Yh kV3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:references:in-reply-to:date :subject:cc:to:from; bh=HL7Z5LtekBrx8v8lJbRug+VP2UiusauG9EHERmMNb4s=; b=Xn04DlAHAsY70USMk9KImwGG9V4ZrzWjn9dqDhZBy3oVZ/hTyBOWyvY6zHHa9ZeBu2 as6Nl61k4kLuGuiFWDYTc5Ir+AL8V81WxZgUN8/vCmVsFav3dmmbjWosSwFGL06dpXf5 GinHzCRairX79FJlUIUYt/sGJbgkf4bMp+/QtxYziUsjDhiBUliMk+RGox7JAtLku+3f 9EP1pCTvv+3F2b1Y4u2j3Pnx6vXN8C02/eWVlF0vTRYFPab3evUV3uCRerLP2y9l3ETN nO63IvuvxTSXRHiWhEjUbn65BswJnd+9o6cKc7S+3uAaF179q32AL8AaPQ6xmO1xPS7h 0g1g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l11-v6si14176444pgm.102.2018.11.11.12.05.32; Sun, 11 Nov 2018 12:05:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731208AbeKLFyY (ORCPT + 99 others); Mon, 12 Nov 2018 00:54:24 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:33702 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731166AbeKLFyV (ORCPT ); Mon, 12 Nov 2018 00:54:21 -0500 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id wABJwxAg079008 for ; Sun, 11 Nov 2018 15:04:52 -0500 Received: from e14.ny.us.ibm.com (e14.ny.us.ibm.com [129.33.205.204]) by mx0a-001b2d01.pphosted.com with ESMTP id 2npdjvj3yv-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 11 Nov 2018 15:04:52 -0500 Received: from localhost by e14.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 11 Nov 2018 20:04:51 -0000 Received: from b01cxnp23033.gho.pok.ibm.com (9.57.198.28) by e14.ny.us.ibm.com (146.89.104.201) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Sun, 11 Nov 2018 20:04:44 -0000 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id wABK4h9H25165976 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 11 Nov 2018 20:04:43 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ACD9BB2068; Sun, 11 Nov 2018 20:04:43 +0000 (GMT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6BE3DB2066; Sun, 11 Nov 2018 20:04:43 +0000 (GMT) Received: from paulmck-ThinkPad-W541 (unknown [9.85.207.24]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Sun, 11 Nov 2018 20:04:43 +0000 (GMT) Received: by paulmck-ThinkPad-W541 (Postfix, from userid 1000) id 9F83516C5D59; Sun, 11 Nov 2018 12:04:44 -0800 (PST) From: "Paul E. McKenney" To: linux-kernel@vger.kernel.org Cc: mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com, joel@joelfernandes.org, Lance Roy , Solarflare linux maintainers , Edward Cree , Bert Kenward , "David S. Miller" , netdev@vger.kernel.org, "Paul E . McKenney" Subject: [PATCH tip/core/rcu 2/7] sfc: Replace spin_is_locked() with lockdep Date: Sun, 11 Nov 2018 12:04:38 -0800 X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181111200421.GA10551@linux.ibm.com> References: <20181111200421.GA10551@linux.ibm.com> X-TM-AS-GCONF: 00 x-cbid: 18111120-0052-0000-0000-0000035423A2 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00010028; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000270; SDB=6.01116026; UDB=6.00578736; IPR=6.00896126; MB=3.00024114; MTD=3.00000008; XFM=3.00000015; UTC=2018-11-11 20:04:49 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18111120-0053-0000-0000-00005EBB29E1 Message-Id: <20181111200443.10772-2-paulmck@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-11-11_13:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=853 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1811110191 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lance Roy lockdep_assert_held() is better suited to checking locking requirements, since it only checks if the current thread holds the lock regardless of whether someone else does. This is also a step towards possibly removing spin_is_locked(). Signed-off-by: Lance Roy Cc: Solarflare linux maintainers Cc: Edward Cree Cc: Bert Kenward Cc: "David S. Miller" Cc: Signed-off-by: Paul E. McKenney --- drivers/net/ethernet/sfc/efx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c index 98fe7e762e17..3643015a55cf 100644 --- a/drivers/net/ethernet/sfc/efx.c +++ b/drivers/net/ethernet/sfc/efx.c @@ -3167,7 +3167,7 @@ struct hlist_head *efx_rps_hash_bucket(struct efx_nic *efx, { u32 hash = efx_filter_spec_hash(spec); - WARN_ON(!spin_is_locked(&efx->rps_hash_lock)); + lockdep_assert_held(&efx->rps_hash_lock); if (!efx->rps_hash_table) return NULL; return &efx->rps_hash_table[hash % EFX_ARFS_HASH_TABLE_SIZE]; -- 2.17.1