Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3309823imu; Sun, 11 Nov 2018 12:05:58 -0800 (PST) X-Google-Smtp-Source: AJdET5fdMMOUo13CqByruwiPcXet6CSEFu7DxATlb182urrWUpl65kiRdVCy5zry7bXfIyNi/+u9 X-Received: by 2002:a17:902:110a:: with SMTP id d10-v6mr17374716pla.85.1541966758710; Sun, 11 Nov 2018 12:05:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541966758; cv=none; d=google.com; s=arc-20160816; b=n9F7+LEys6SIjDIbcfTF0Hs2K3m5qj16kzuo4Nk6Z7lIg5PvHP+dawMha7t8e3jSM0 bZOyXrdNRih7CCiMitolO+8ThF25UWjtUM3AfAQOls25D30COE2W9cXzzd2XDJTxkkor tOvZBx4aXz8MtOy2K930/wUb9Lw3GH9gJwb2+kopVMY61rgmT1NAC4zWmhTyo2dRwPm2 ZiRlsOFww0XHJNuP0EKZ9deodlr4KV/Er6Z8BHOhk5NwT2hDGXKlPsLvKUzWleL8Oiic /brI73XzfonrfhDJwRh1tYVEn1kPih0p87R3YNSdkDD/k7rGGr0vOwNvY/Q3/jK176oQ BiEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:references:in-reply-to:date :subject:cc:to:from; bh=GbBUrtYy7MZ5ktF43g4ov+6sQvxNcLDpS2Hmwn593Kk=; b=H4DZrM8LiKSvR/4442lsrVT21UZYVuAGyijziUMoWmyqp0qg2HRl68UXGDo2ybhWE+ XyEc17tpwditFHibSEgCKQcPHSeZJ+Lx4qfsvw6Cnhakk7+mVM09dtgllimHdA3M7V/9 yO1Tv471P0ajs/Mih5YCDuCHvlWTlhm7XQWk3tFCjb32XNP8L86qhFA/FndUzB865Ymw ML0/ovygw3gSHBgzA075tNGp7ZI5bAxB1B6DQe4uB/zAwKILVSimYVRxqo35je0U6MjQ hracqCldujvVWNt7OU4Z+iOxYHVzuk9tTx6jTYFvyO7dZ/GQSvIWvZMgJmeUh6sy3ii9 e6iQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 63-v6si16849381pfg.234.2018.11.11.12.05.43; Sun, 11 Nov 2018 12:05:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730996AbeKLFyZ (ORCPT + 99 others); Mon, 12 Nov 2018 00:54:25 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:50834 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731184AbeKLFyV (ORCPT ); Mon, 12 Nov 2018 00:54:21 -0500 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id wABJwuwG106460 for ; Sun, 11 Nov 2018 15:04:53 -0500 Received: from e17.ny.us.ibm.com (e17.ny.us.ibm.com [129.33.205.207]) by mx0a-001b2d01.pphosted.com with ESMTP id 2npd762gj0-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 11 Nov 2018 15:04:52 -0500 Received: from localhost by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 11 Nov 2018 20:04:51 -0000 Received: from b01cxnp22035.gho.pok.ibm.com (9.57.198.25) by e17.ny.us.ibm.com (146.89.104.204) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Sun, 11 Nov 2018 20:04:44 -0000 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id wABK4hhi44368014 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 11 Nov 2018 20:04:43 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A78FCB2070; Sun, 11 Nov 2018 20:04:43 +0000 (GMT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 65F7EB2065; Sun, 11 Nov 2018 20:04:43 +0000 (GMT) Received: from paulmck-ThinkPad-W541 (unknown [9.85.207.24]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Sun, 11 Nov 2018 20:04:43 +0000 (GMT) Received: by paulmck-ThinkPad-W541 (Postfix, from userid 1000) id 99A9716C5D38; Sun, 11 Nov 2018 12:04:44 -0800 (PST) From: "Paul E. McKenney" To: linux-kernel@vger.kernel.org Cc: mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com, joel@joelfernandes.org, Lance Roy , Bjorn Helgaas , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, linux-pci@vger.kernel.org, "Paul E . McKenney" Subject: [PATCH tip/core/rcu 1/7] x86/PCI: Replace spin_is_locked() with lockdep Date: Sun, 11 Nov 2018 12:04:37 -0800 X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181111200421.GA10551@linux.ibm.com> References: <20181111200421.GA10551@linux.ibm.com> X-TM-AS-GCONF: 00 x-cbid: 18111120-0040-0000-0000-000004908A31 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00010028; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000270; SDB=6.01116025; UDB=6.00577119; IPR=6.00896126; MB=3.00024114; MTD=3.00000008; XFM=3.00000015; UTC=2018-11-11 20:04:49 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18111120-0041-0000-0000-0000089992E2 Message-Id: <20181111200443.10772-1-paulmck@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-11-11_13:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=566 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1811110191 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lance Roy lockdep_assert_held() is better suited to checking locking requirements, since it only checks if the current thread holds the lock regardless of whether someone else does. This is also a step towards possibly removing spin_is_locked(). Signed-off-by: Lance Roy Cc: Bjorn Helgaas Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: "H. Peter Anvin" Cc: Cc: Signed-off-by: Paul E. McKenney --- arch/x86/pci/i386.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/pci/i386.c b/arch/x86/pci/i386.c index 8cd66152cdb0..9df652d3d927 100644 --- a/arch/x86/pci/i386.c +++ b/arch/x86/pci/i386.c @@ -59,7 +59,7 @@ static struct pcibios_fwaddrmap *pcibios_fwaddrmap_lookup(struct pci_dev *dev) { struct pcibios_fwaddrmap *map; - WARN_ON_SMP(!spin_is_locked(&pcibios_fwaddrmap_lock)); + lockdep_assert_held(&pcibios_fwaddrmap_lock); list_for_each_entry(map, &pcibios_fwaddrmappings, list) if (map->dev == dev) -- 2.17.1