Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3315102imu; Sun, 11 Nov 2018 12:11:38 -0800 (PST) X-Google-Smtp-Source: AJdET5f+l5eQYlwzNvc4jytlPCUvsVssYcDK5j6NNJ2wAi7GhrMXQ1d57Xh3uuMJVRzoZRLvPSvy X-Received: by 2002:a63:4187:: with SMTP id o129mr3584148pga.370.1541967098156; Sun, 11 Nov 2018 12:11:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541967098; cv=none; d=google.com; s=arc-20160816; b=efhps4HsvVsmhHB05M4wZMfHUVIW7P+8SnSZxGwlinGZe7bWqnq54RZpIk41aCybPI jcNoZPbQa00xtOlN7qZZ3ZSSSYCVqPYqsx3/kno0SKqR6MpzfMwRLtlnGT/hBRdxUBHM AOfzK3ot38PGaMYULOy9G6jylxHgXuq0CWpxgldXE7wli7uiyRKMn1WAEGbHl9CBUycK cgKYmsLIPf88HtDczVTxqtF5SPTFtcmZH/ZJgXqZDlfW3tUCd/m0ch3ozMJdGwgsGlWA b9M8XJQhB6DkicQK0JQBabDGVYjUNIc5BAPrsrcS01d7qvKiRP8uIGZJ20kH4vRD4VmX Zh7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:subject:message-id:date:cc:to :from:mime-version:content-transfer-encoding:content-disposition; bh=UMC9GmFSAihW3ofqdNJLGv2ZPG2dD2gzk6sF9B4xwEQ=; b=fF4AJ2gqre8vJl7uQbeRZyoKIYsTGUgBIY75H9cKAN1La4FKneZpWY3takLt0Yscwt 8Fhnboez8LxS4N5lD1dp7HcgZyhKy5r5ly/SWVsp48ykJtmiUACCT+0DFOeFTc0wzZD7 k0wj3FCyjFP+TT8QcncaqOsO27FI1qhyI+9ag7OPpaGb5FC/1LPfCYi7xNLfYgKXFFBM 9z/DZyGb4mgI8IdQ+XtRdd4bGgt6UnO3gNiLJ6pGCjenk9gzzX3pX2qE6LqXeacyGpZC SyUfaqa5Efz2mnviuojmYZ6fQ9+oa0iH1Pp9FaXnbnpXUFhh+9TIJWLbM29L4gAKmDLO oRTQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n17-v6si13760372pgk.501.2018.11.11.12.11.23; Sun, 11 Nov 2018 12:11:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731426AbeKLGAF (ORCPT + 99 others); Mon, 12 Nov 2018 01:00:05 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:52368 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727357AbeKLGAF (ORCPT ); Mon, 12 Nov 2018 01:00:05 -0500 Received: from [192.168.4.242] (helo=deadeye) by shadbolt.decadent.org.uk with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1gLvsq-0000lM-JL; Sun, 11 Nov 2018 19:59:00 +0000 Received: from ben by deadeye with local (Exim 4.91) (envelope-from ) id 1gLvsX-0001kB-2v; Sun, 11 Nov 2018 19:58:41 +0000 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: Ben Hutchings To: linux-kernel@vger.kernel.org, stable@vger.kernel.org CC: akpm@linux-foundation.org, "Dewet Thibaut" , "Tony Luck" , "Thomas Gleixner" , "linux-edac" , "Alexander Sverdlin" , "Borislav Petkov" Date: Sun, 11 Nov 2018 19:49:05 +0000 Message-ID: X-Mailer: LinuxStableQueue (scripts by bwh) Subject: [PATCH 3.16 265/366] x86/MCE: Remove min interval polling limitation In-Reply-To: X-SA-Exim-Connect-IP: 192.168.4.242 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.16.61-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Dewet Thibaut commit fbdb328c6bae0a7c78d75734a738b66b86dffc96 upstream. commit b3b7c4795c ("x86/MCE: Serialize sysfs changes") introduced a min interval limitation when setting the check interval for polled MCEs. However, the logic is that 0 disables polling for corrected MCEs, see Documentation/x86/x86_64/machinecheck. The limitation prevents disabling. Remove this limitation and allow the value 0 to disable polling again. Fixes: b3b7c4795c ("x86/MCE: Serialize sysfs changes") Signed-off-by: Dewet Thibaut Signed-off-by: Alexander Sverdlin [ Massage commit message. ] Signed-off-by: Borislav Petkov Signed-off-by: Thomas Gleixner Cc: Tony Luck Cc: linux-edac Link: http://lkml.kernel.org/r/20180716084927.24869-1-alexander.sverdlin@nokia.com Signed-off-by: Ben Hutchings --- arch/x86/kernel/cpu/mcheck/mce.c | 3 --- 1 file changed, 3 deletions(-) --- a/arch/x86/kernel/cpu/mcheck/mce.c +++ b/arch/x86/kernel/cpu/mcheck/mce.c @@ -2260,9 +2260,6 @@ static ssize_t store_int_with_restart(st if (check_interval == old_check_interval) return ret; - if (check_interval < 1) - check_interval = 1; - mutex_lock(&mce_sysfs_mutex); mce_restart(); mutex_unlock(&mce_sysfs_mutex);