Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3329754imu; Sun, 11 Nov 2018 12:30:44 -0800 (PST) X-Google-Smtp-Source: AJdET5falgB1bYhv5c749kLTGElnpEg6PRv7NQD2CNAbTvldtTE5wzg/ULTsBQnaTGpKMfxpxR4o X-Received: by 2002:a17:902:3041:: with SMTP id u59-v6mr17785808plb.265.1541968244240; Sun, 11 Nov 2018 12:30:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541968244; cv=none; d=google.com; s=arc-20160816; b=CLKd12qvQUngsR+i3z5FTDvK4SQ1rFr2hmmku/4zjLywt44K3xn0MMgmYX3mHquQMq uUYJuwpNxHgQbFV9ngO0V8ah3m6NISJYrZ4d7uIdssqGDKlmvEaahceCy7O50tXOVSEX bGYyV7cV3kBAfRlAUQV5husI/OEGj0a1d9hcEtwaxwv/D1Us+4LDD0ewjndaf1/Gsp4T JzjvJQdRnP6vKX2GF2xsJbN7kzXsCbotwOeFwTAW+8TnZEZpWkjyAnP2+xfl/NTZV4qx cotlOVK5O7rb9LTVmFJQz1TBghLa0M1e6X10DjbkWlBjFvEOs3qfaMdxymYrjGktjNOm LG3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:to:from:subject:message-id :dkim-signature; bh=+8WsQZ6q8OmVX4Dz4iZ+yQWY4wrACTkbYxHc1pFjk2c=; b=cxlGkfQu9oENvDwxRv1fPLKhbEi20CUbOQEGN/BrMfIaxdmXxo1/tbvox4G2/5eJyu N794B4bTvt/1fsKP3Ac1v8scXxS5ZD8fgM+3FXadHNfB2xof9U6Um8xaY8CLEnlr9kli PtUpekLvqjQDR9xL1uET5og4okI4RzXlKAROM20IeLrlL1gk7vVp+7fPlBJj1h8d3TJx i8NwEeqnzNb6O7Gm8lvqohgLeHbSsELrbxs1VkFrQClvvZ2cx2heZbcVEEcd3fM13Bw4 wNSyD4wwABpJnzxwHC8iR9J+JifyIosNkHFRwXqhUS5xD/o6KGXgfwWS1waEBkItU8/+ ctmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@hansenpartnership.com header.s=20151216 header.b=po48kL6A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=hansenpartnership.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e63si13899251pgc.239.2018.11.11.12.30.28; Sun, 11 Nov 2018 12:30:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@hansenpartnership.com header.s=20151216 header.b=po48kL6A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=hansenpartnership.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730561AbeKLGTZ (ORCPT + 99 others); Mon, 12 Nov 2018 01:19:25 -0500 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:49796 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730488AbeKLGTY (ORCPT ); Mon, 12 Nov 2018 01:19:24 -0500 Received: from localhost (localhost [127.0.0.1]) by bedivere.hansenpartnership.com (Postfix) with ESMTP id 883FC8EE12F; Sun, 11 Nov 2018 12:29:53 -0800 (PST) Received: from bedivere.hansenpartnership.com ([127.0.0.1]) by localhost (bedivere.hansenpartnership.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id g5doqlLg7xH9; Sun, 11 Nov 2018 12:29:53 -0800 (PST) Received: from [153.66.254.194] (unknown [50.35.68.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bedivere.hansenpartnership.com (Postfix) with ESMTPSA id E59588EE0A4; Sun, 11 Nov 2018 12:29:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=hansenpartnership.com; s=20151216; t=1541968193; bh=IVT55bWKe6cGhRi9r8LJpxNd5rWYnmikRfGRFITafPE=; h=Subject:From:To:Date:In-Reply-To:References:From; b=po48kL6ALD4PTcSJvx+6DkMnxvScD16zZSzzGmfs61SAqnimlm6Ur4Yud5zktaXxY Jb5+qEOWJPFw5BcdBOfsh/khIrM4dlaSaGHM7/q1pv3eGJWiSsCwK/s/D7wPLUdAXI fCOgUjmcLRxCi2Qf5Q01j8HGgPohzobj0ustONos= Message-ID: <1541968191.3190.12.camel@HansenPartnership.com> Subject: Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working From: James Bottomley To: Michael =?ISO-8859-1?Q?Niew=F6hner?= , peterhuewe@gmx.de, jarkko.sakkinen@linux.intel.com, jgg@ziepe.ca, arnd@arndb.de, linux-integrity@vger.kernel.org, linux-kernel Date: Sun, 11 Nov 2018 12:29:51 -0800 In-Reply-To: <7d8cc5ad4bb7548d283f363de6f24c90d5d0a2b2.camel@mniewoehner.de> References: <776f384a81466642472beb4a34b10f26f1de88e9.camel@mniewoehner.de> <1541960689.3190.4.camel@HansenPartnership.com> <1541962653.3190.7.camel@HansenPartnership.com> <7d8cc5ad4bb7548d283f363de6f24c90d5d0a2b2.camel@mniewoehner.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.6 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2018-11-11 at 21:09 +0100, Michael Niewöhner wrote: > On Sun, 2018-11-11 at 10:57 -0800, James Bottomley wrote: [...] > > Well, I still think the ACPI setup is incorrect. What's in > > /sys/class/platform (should be directories of ACPI devices)? The > > TPM is supposed to show up as MSFT0101. If it doesn't is there any > > other device string in there that might be a TPM? > > Nope. I'm not sure if it should show up in ACPI... isn't TPM 2.0 I2C? Your ACPI parser identifies it here: > [ 0.003517] ACPI: TPM2 0x000000009E490ED8 000034 (v03 LENOVO TC-S06 00001300 AMI 00000000) So it has to be a device in the platform directory. What is in this directory? To find the TPM it probably has something TPM like in the firmware_node description: /sys/devices/platform//firmware_node/description Mine says jejb@jarvis:~/git/linux/drivers> cat /sys/devices/platform/MSFT0101\:00/firmware_node/description TPM 2.0 Device James