Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3349850imu; Sun, 11 Nov 2018 12:59:41 -0800 (PST) X-Google-Smtp-Source: AJdET5flnjgYxF+7j/QhNjwOltK8UsMRnz8fcE6SdHDTahnG5OQCIW+eKr7/r1xbRyCrSo+r9pwP X-Received: by 2002:a65:6148:: with SMTP id o8mr4504830pgv.451.1541969981281; Sun, 11 Nov 2018 12:59:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541969981; cv=none; d=google.com; s=arc-20160816; b=KBv4pzexdouoRuoJUBk2OghjLc81q69OW4TilYdc36+4atSCVE9eqy2BT7I16NYueC nEFFGs7L/V8N9N/FG8HTZmFEzLNeKVQWmeZqdh5pHODVv8cNgbEBD6rYatVyDXDXewVa qoXjf6shfogRCk11DyajgpTXrQKuQqR545N8Cqb6IzMgnSC2WzTsWicvE6xFu/yqJ6ka b5uUknf9Hnm0iICBuZWkk+EK7ER71AubaZN2v1dsUSIChvjrkoJ45jxpwbhklVjMg31t QlmR9+au2K0/RfxPiMCXXbvZyzhszWfQxeScKf8qntC0M+pTLBcEECCo/2ghH71fmpQh /ZnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=rWhhovAhSraTHlXWWp/grUvbiH8sByfulb9eb/GVF5Q=; b=Cyy+TA0//lcnnJxfBBuC/pI+0wqR99B0sgeGmTlZchf226GaHQd1iu+A6Y3wVsf8H9 eX86ThXkoLCq+lrYRQWe4vDSGW4DgF30FBuRgcmwAZDln/B39nWqgE0++bs2Pm9R+Ugs /JcGUocJFX/q5xXJ0Xp/M+E7WqAOe4ZLFYQ42qrev/NN7qDmFUk2WmDV0nVY/YSTUA5A qC1YCVJ5tnhxB4RT6LsijjyPli/zjIN5Dg/USshnPGeOsFMJ6LR9n8fIYV4i9DGDafvv dx5IKHqPZbb9cIk0gS4z/7wdU+09D5bh6TuItp5DmDjqKNsIB73h05NIGEeUgysWm503 XfPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="E7HaPuC/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b23-v6si11784013pls.367.2018.11.11.12.59.26; Sun, 11 Nov 2018 12:59:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="E7HaPuC/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729758AbeKLGsm (ORCPT + 99 others); Mon, 12 Nov 2018 01:48:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:36158 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726497AbeKLGsm (ORCPT ); Mon, 12 Nov 2018 01:48:42 -0500 Received: from localhost (unknown [206.108.79.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9CA7B20881; Sun, 11 Nov 2018 20:59:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1541969942; bh=WVUxGJ0XIUMFMkXSxU/E0QcjwQ1T4sAi/VDUtkX4Zb0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E7HaPuC/Z9vhNkQU4k0NrdtNd4pYx8uVHdxKHgXwZcxsatv58nPG6W41B8wlDaU5H /spPsUSn0CqyHxQoCNCMjOXGOIvfD6UxnE7Oe36BcjrgILyw8OLfR13E1lbwJ4cMCM HmcyteKl4hlkJ+nWwYv+oilBhPOIhYBq6l03UE90= Date: Sun, 11 Nov 2018 12:59:02 -0800 From: Greg Kroah-Hartman To: Boris Brezillon Cc: Wolfram Sang , linux-i2c@vger.kernel.org, Jonathan Corbet , linux-doc@vger.kernel.org, Arnd Bergmann , Przemyslaw Sroka , Arkadiusz Golec , Alan Douglas , Bartosz Folta , Damian Kos , Alicja Jurasik-Urbaniak , Cyprian Wronka , Suresh Punnoose , Rafal Ciepiela , Thomas Petazzoni , Nishanth Menon , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vitor Soares , Geert Uytterhoeven , Linus Walleij , Xiang Lin , linux-gpio@vger.kernel.org, Sekhar Nori , Przemyslaw Gaj , Peter Rosin , Mike Shettel , Stephen Boyd , Stephen Rothwell Subject: Re: [PATCH v10 0/9] Add the I3C subsystem Message-ID: <20181111205902.GA21546@kroah.com> References: <20181026144333.12276-1-boris.brezillon@bootlin.com> <20181111173932.GA12254@kroah.com> <20181111191017.7b2efdf1@bbrezillon> <20181111191020.GA21003@kroah.com> <20181111210818.08af6731@bbrezillon> <20181111205718.GA16288@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181111205718.GA16288@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 11, 2018 at 12:57:18PM -0800, Greg Kroah-Hartman wrote: > On Sun, Nov 11, 2018 at 09:08:18PM +0100, Boris Brezillon wrote: > > On Sun, 11 Nov 2018 11:10:20 -0800 > > Greg Kroah-Hartman wrote: > > > > > On Sun, Nov 11, 2018 at 07:10:17PM +0100, Boris Brezillon wrote: > > > > Hi Greg, > > > > > > > > On Sun, 11 Nov 2018 09:39:32 -0800 > > > > Greg Kroah-Hartman wrote: > > > > > > > > > On Fri, Oct 26, 2018 at 04:43:24PM +0200, Boris Brezillon wrote: > > > > > > Hi Greg, > > > > > > > > > > > > I think we've reached a point where we can eventually consider the I3C > > > > > > framework for inclusion in 4.20 (5.0?). A few more issues were reported > > > > > > on v9 and fixed in v10. I can't guarantee that the implementation is > > > > > > free of bugs but I still think it's worth merging it in v4.20: it's a > > > > > > new subsystem, so we don't risk regressions, and the only way we can > > > > > > detect other issues is by having other people experiment with this > > > > > > implementation. > > > > > > > > > > > > The only remaining concern raised by Arnd is the fact that both hosts > > > > > > and slaves share the same bus type and are differentiated thanks to > > > > > > their device_type, which IMHO is fine since this is what other > > > > > > subsystems do (plus I don't see other solutions to have both I3C > > > > > > devices and I3C buses represented under /sys/bus/i3c/). > > > > > > > > > > Yeah, it's not the nicest, but it will work, we did it also for USB and > > > > > greybus and it solves the issue. > > > > > > > > > > This all looks good to me, so I've queued it up. Let's see if > > > > > linux-next has any problems with it. > > > > > > > > I recently asked Stephen to add the linux-i3c tree to linux-next, so > > > > I'm expecting conflicts :-/. Sorry, I didn't know you were planning to > > > > take these patches through your tree. > > > > > > > > BTW, I also fixed a couple of things when rebasing on top of 4.20-rc1: > > > > > > > > - KernelVersion in the sysfs ABI doc has been updated to 5.0 > > > > > > There is no 5.0 yet :) > > > > Actually I had a hard time choosing between 4.21 and 5.0, and then I > > saw Linus' email announcing 4.20-rc1 ;-). But I can change it back to > > 4.21 if you prefer. > > > > > > > > > - Fixed i3c_master_getmxds_locked() (bug reported/fixed by Colin here > > > > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1799850.html) > > > > - Removed a blank line at the end of master-driver-api.rst > > > > One extra thing I didn't mention (and didn't fix yet) is the I3C > > mailing list. I asked Dave Miller if he'd be okay to create the > > linux-i3c ML on vger.kernel.org, and he suggested that we use the > > linux-i2c ML instead which I know Wolfram is not fond of. I might > > decide to just put linux-kernel@vger.kernel.org as the ML to Cc for > > I3C patches until we settle on something. > > > > > > > > > > For the record, the i3c/next branch pulled by Stephen is available here > > > > [1]. > > > > > > > > > Thanks for sticking with it, nice work! > > > > > > > > Thanks for reviewing it! Greg, Stephen, let me know if you want me to > > > > reset i3c/next to v4.20-rc1 to avoid conflicts in linux-next. > > > > > > So do you want me to just drop these patches from my tree? If so, I > > > can, but i have no problem sending these to Linus for the next -rc1 > > > merge window through my tree if that is easier. > > > > > > It's up to you. > > > > I think that's easier for me and for you if I take them in the i3c tree > > and then send a PR to Linus myself. This way I won't bother you if > > fixes are needed or if I decide to apply patches adding support for > > other I3C controllers (I see you commented on the Synopsys driver > > already, and I might indeed decide to queue this patchset for this > > release). > > > > Doing that also allows me to get everything in place since I'll anyway > > have to send PRs to Linus at some point. > > > > Regards, > > > > Boris > > > > PS: If you're fine with me taking the I3C patches, I'll need your > > Acked-by. > > Sure, feel free to do it all yourself, I do not object to that! :) > > Acked-by: Greg Kroah-Hartman And I've now dropped all of these patches from my tree, so no need to worry about any conflicts. thanks, greg k-h