Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3432186imu; Sun, 11 Nov 2018 14:59:41 -0800 (PST) X-Google-Smtp-Source: AJdET5ebiA2rf6+uHm60m3PkdElREVYyTF+HyNowhBN14XyBBUChbwppH5cjAqH3DeDVdqJO/UcU X-Received: by 2002:a63:6150:: with SMTP id v77mr15138010pgb.266.1541977181307; Sun, 11 Nov 2018 14:59:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541977181; cv=none; d=google.com; s=arc-20160816; b=Qg/haF8cLZ7wMbdA+GflSCgOfq0fnK/Oj3u1crTM7sErcHPOwi5ZHpsd0z33vS5c/z 3/kCrwvjo1BsYDf1VEW69X+C2w5O2dfRLkBugVqKoB5WT5yZ8lcKh0MKbXxqvYShzfAs X6Cv3CdHJvA7AAVflPwc5+nGk8UUlKmCJfg92v+hju1LXGE5zYQnzn8SpLe7H39HX+x1 JQSlqjnnUYTcAyyML5QBvW7cwhqkKUk2batOqw+QAFmYaeKaw2PPpRopRyxmo+D+9pvl qqyWxxJlTGa/AoPVIOPTuITa3/GMSyPnogTiayQQLSZ4DI/uYhP78jOjJhcbGfJYlWke N8ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=AwvdCCShSnnLEv83g/dvQqVx5l3uD6lfQqq9Bq9CarQ=; b=P222LHPGSFUqkLAtYNGK+VbskNSBp+ElNw36QbbA9I1pnWq/zwU+aBOIXIe9tndjey W4S2eqc3mCOp25Peez2rBOYXubVHWW/KmXaHZhXpn9iFfkSP+YnuvavWwLtSRJ6cItEe R8J+Uc5HT7wYzh4qU1TDBvCF/De8e0EP3hBjDeOjhj3OsM6e6pc/LUi+oqJFBa8e7Tt9 eSLk4KY/nvhS+AYpDbI+Y30zE6xIjWTIPZ7ACYU4Wl+/4wBwt8lQ4U7ZN3Kw29JJ0UJy S9K9IL/WMDNjCgIDRACjVKUbsfLYz7FUuSvewjX4l93nlcRVvoum6tmuDiI2mHHDBaEe sK9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ugFFpxSP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h20si14250805pgm.366.2018.11.11.14.59.26; Sun, 11 Nov 2018 14:59:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ugFFpxSP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390832AbeKLItE (ORCPT + 99 others); Mon, 12 Nov 2018 03:49:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:53878 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390740AbeKLIWj (ORCPT ); Mon, 12 Nov 2018 03:22:39 -0500 Received: from localhost (unknown [206.108.79.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D603321582; Sun, 11 Nov 2018 22:32:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1541975561; bh=+qPNtKttuNkuOF5O6BnIq+Ev6+B2uWGiO4OdNrSwl1k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ugFFpxSPs1O3fXe3NqI6G9FAJfXznoatPofcCoKi/WVDXtmr1+yJbxbead/XyBfcr sIX8U0zkRDz1zhQ8pB438VGmkpMNEUCUuBa6M96HjImPCzGpaZI/cqgSlmLMifmI7n 9p4tTfeMW1jZl9uZ+Q3GLfH7phsnzE8fdqVi70kM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Randy Dunlap , "Shuah Khan (Samsung OSG)" Subject: [PATCH 4.14 125/222] usbip:vudc: BUG kmalloc-2048 (Not tainted): Poison overwritten Date: Sun, 11 Nov 2018 14:23:42 -0800 Message-Id: <20181111221658.851713251@linuxfoundation.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181111221647.665769131@linuxfoundation.org> References: <20181111221647.665769131@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shuah Khan (Samsung OSG) commit e28fd56ad5273be67d0fae5bedc7e1680e729952 upstream. In rmmod path, usbip_vudc does platform_device_put() twice once from platform_device_unregister() and then from put_vudc_device(). The second put results in: BUG kmalloc-2048 (Not tainted): Poison overwritten error or BUG: KASAN: use-after-free in kobject_put+0x1e/0x230 if KASAN is enabled. [ 169.042156] calling init+0x0/0x1000 [usbip_vudc] @ 1697 [ 169.042396] ============================================================================= [ 169.043678] probe of usbip-vudc.0 returned 1 after 350 usecs [ 169.044508] BUG kmalloc-2048 (Not tainted): Poison overwritten [ 169.044509] ----------------------------------------------------------------------------- ... [ 169.057849] INFO: Freed in device_release+0x2b/0x80 age=4223 cpu=3 pid=1693 [ 169.057852] kobject_put+0x86/0x1b0 [ 169.057853] 0xffffffffc0c30a96 [ 169.057855] __x64_sys_delete_module+0x157/0x240 Fix it to call platform_device_del() instead and let put_vudc_device() do the platform_device_put(). Reported-by: Randy Dunlap Signed-off-by: Shuah Khan (Samsung OSG) Cc: Signed-off-by: Greg Kroah-Hartman --- drivers/usb/usbip/vudc_main.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) --- a/drivers/usb/usbip/vudc_main.c +++ b/drivers/usb/usbip/vudc_main.c @@ -85,6 +85,10 @@ static int __init init(void) cleanup: list_for_each_entry_safe(udc_dev, udc_dev2, &vudc_devices, dev_entry) { list_del(&udc_dev->dev_entry); + /* + * Just do platform_device_del() here, put_vudc_device() + * calls the platform_device_put() + */ platform_device_del(udc_dev->pdev); put_vudc_device(udc_dev); } @@ -101,7 +105,11 @@ static void __exit cleanup(void) list_for_each_entry_safe(udc_dev, udc_dev2, &vudc_devices, dev_entry) { list_del(&udc_dev->dev_entry); - platform_device_unregister(udc_dev->pdev); + /* + * Just do platform_device_del() here, put_vudc_device() + * calls the platform_device_put() + */ + platform_device_del(udc_dev->pdev); put_vudc_device(udc_dev); } platform_driver_unregister(&vudc_driver);