Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3434299imu; Sun, 11 Nov 2018 15:02:03 -0800 (PST) X-Google-Smtp-Source: AJdET5fhQRuMwLdN3IhHRHqOfpxpv2Hdepct+Jh6ZDto0LC6DNDIYvUwrTrG0zRrpM/+x7NCKmcL X-Received: by 2002:a63:441e:: with SMTP id r30mr15619300pga.128.1541977323184; Sun, 11 Nov 2018 15:02:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541977323; cv=none; d=google.com; s=arc-20160816; b=VGGpoi2mcE121ybO6+8qMQFMZOH9QPUXNAi8ypXlgcYfkkt5eT5uUu/YDAG9LBtVPU kgpOxiSH7T7aIdJbSe0w8cxyz3zsZ/fUico5b9kfd1rPhLQpt4oFvboinNm0tuesdKW3 E6BPIGSPdHlzhaTkFe20i+ZGq7KYJdH83odC/uJTTpglnEK4nS8JUyFo2ISiv+9GUfGQ E/H7sLw4BnK2WrvmyhBtkc55ONIu9NTBCc4PRc3MWKKYih6lEj6/gZKmxWBurOwQP+F8 Igyn0EkNC/cYq1Zl1RM71g3FFPzbjb8CDoer7q5pSUuNvTCkz0eUHGu3VAkOx2Adz07R SaMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=I+EH7OIvxeI8wnQgkR+qp3rtcOyQ1wDDv64tdtuVHZo=; b=hLUTloyOiB7NgoH0nBg7W0aGlrzGucGrs/FH5TG8fWE/p6WRqRPJC+8qRlrXvrzwd0 amhci6M5bK4IK4Ug7ofZCpFgU4VBJe5QUHjr16yP3KrhFhtD9CTKB0muboaftaJAzIQ+ 5KIWx017yjn3+OypEN5rv9EasvK/j9pQ/BVv99b1VOeCgYiLsOta0R7PeDMlzfrLhPfA 8KgHc5HPIp3ioFkLFEgkZuiqFRyFIQhpcRf+Fw0lDSXSoGiwPrZbmJjOz8wxNhg3DzgY IMWNAn1eSuSm+gsDVmyohmlLhwGnfN6Cq9h5oOxYeIIMqjhHD9VQ5e/3NBH2dZ3Zgv7K lWDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=IJ2qjJax; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w187si13977576pgb.552.2018.11.11.15.01.47; Sun, 11 Nov 2018 15:02:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=IJ2qjJax; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391140AbeKLIuK (ORCPT + 99 others); Mon, 12 Nov 2018 03:50:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:52394 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390723AbeKLIWf (ORCPT ); Mon, 12 Nov 2018 03:22:35 -0500 Received: from localhost (unknown [206.108.79.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C1C7922419; Sun, 11 Nov 2018 22:32:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1541975557; bh=M/pwGDRsqAlHjwSzbWB00BkjVJvy45Px4C1lqnsjAqk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IJ2qjJax+uhQdGaRSPppssg1amr2naxUsKgXAVSzote+Ai7mzPcSSjNJUrKTby8GI Yh1JkJQ0Cbu9NyIxd1gTrRc3hrSZi63pFY4twMmlioef/KOVkhAqeAHguo/TG5w6ti sPAFV7cBLb5ELB/Zem5M1SE7aLcKJVxyVPs0B1D8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Viresh Kumar , Krzysztof Kozlowski Subject: [PATCH 4.14 113/222] arm: dts: exynos: Add missing cooling device properties for CPUs Date: Sun, 11 Nov 2018 14:23:30 -0800 Message-Id: <20181111221657.888958300@linuxfoundation.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181111221647.665769131@linuxfoundation.org> References: <20181111221647.665769131@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Viresh Kumar commit 672f33198bee21ee91e6af2cb8f67cfc8bc97ec1 upstream. The cooling device properties, like "#cooling-cells" and "dynamic-power-coefficient", should either be present for all the CPUs of a cluster or none. If these are present only for a subset of CPUs of a cluster then things will start falling apart as soon as the CPUs are brought online in a different order. For example, this will happen because the operating system looks for such properties in the CPU node it is trying to bring up, so that it can register a cooling device. Add such missing properties. Fix other missing properties (clocks, OPP, clock latency) as well to make it all work. Signed-off-by: Viresh Kumar Signed-off-by: Krzysztof Kozlowski Signed-off-by: Greg Kroah-Hartman --- arch/arm/boot/dts/exynos3250.dtsi | 16 ++++++++++++++++ arch/arm/boot/dts/exynos4210.dtsi | 13 +++++++++++++ arch/arm/boot/dts/exynos5250.dtsi | 23 +++++++++++++++++++++++ 3 files changed, 52 insertions(+) --- a/arch/arm/boot/dts/exynos3250.dtsi +++ b/arch/arm/boot/dts/exynos3250.dtsi @@ -82,6 +82,22 @@ compatible = "arm,cortex-a7"; reg = <1>; clock-frequency = <1000000000>; + clocks = <&cmu CLK_ARM_CLK>; + clock-names = "cpu"; + #cooling-cells = <2>; + + operating-points = < + 1000000 1150000 + 900000 1112500 + 800000 1075000 + 700000 1037500 + 600000 1000000 + 500000 962500 + 400000 925000 + 300000 887500 + 200000 850000 + 100000 850000 + >; }; }; --- a/arch/arm/boot/dts/exynos4210.dtsi +++ b/arch/arm/boot/dts/exynos4210.dtsi @@ -59,6 +59,19 @@ device_type = "cpu"; compatible = "arm,cortex-a9"; reg = <0x901>; + clocks = <&clock CLK_ARM_CLK>; + clock-names = "cpu"; + clock-latency = <160000>; + + operating-points = < + 1200000 1250000 + 1000000 1150000 + 800000 1075000 + 500000 975000 + 400000 975000 + 200000 950000 + >; + #cooling-cells = <2>; /* min followed by max */ }; }; --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -87,6 +87,29 @@ compatible = "arm,cortex-a15"; reg = <1>; clock-frequency = <1700000000>; + clocks = <&clock CLK_ARM_CLK>; + clock-names = "cpu"; + clock-latency = <140000>; + + operating-points = < + 1700000 1300000 + 1600000 1250000 + 1500000 1225000 + 1400000 1200000 + 1300000 1150000 + 1200000 1125000 + 1100000 1100000 + 1000000 1075000 + 900000 1050000 + 800000 1025000 + 700000 1012500 + 600000 1000000 + 500000 975000 + 400000 950000 + 300000 937500 + 200000 925000 + >; + #cooling-cells = <2>; /* min followed by max */ }; };