Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3435073imu; Sun, 11 Nov 2018 15:02:51 -0800 (PST) X-Google-Smtp-Source: AJdET5cmzh6BbIVB16qVkNjF1X5YJmg93mcKLXAOsd6RlDGSn3jC1P1He7DqEqNYXoWQxbKdxzQb X-Received: by 2002:a63:5664:: with SMTP id g36mr15225014pgm.313.1541977371371; Sun, 11 Nov 2018 15:02:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541977371; cv=none; d=google.com; s=arc-20160816; b=UXyfCCq+T8oJzjllPXMU6IENmophBmF/p55fsT4QtfSTDE0enPzWK/RjX7DFCy9tuP GJWaZVGNNxsfYXuG2lNpKPBaBAiBRUj5UjiM3rpio6fdbOsd8Ak99eyI4j7v3ZSvefx3 X63hwqLI3jC1DJiHZz9PmwICBkS+L4A6sy+W9O4IeU+lbjyAtZ6szSmaz31MFS0Eo7QH KTM9lhjHp2JOI/FTcYvNm3463UKr9BgDHdzQvVduZE261YmdFr9XkC9IDSkx4VE2H6v5 aE/ADt4k259FATSqPWJaBVCNQ0iQl+MlwA7Slc8ZdWwDgwa5AwVb7TtLZ+gqbjM9YhMr QM2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=7prNlEqQrewPQNBnuVnYVHTnjf66so/eknOX7nEaOeY=; b=fOxct/as7t7aXXCMGIpHHVgnPA4t20FVFRnhDj43JMUf+yW6LJOfAnWR3944h8hjMr rLBV7SU8259JkyxQW+kB2HDhVwn6Fc3s3ofzId/GfrN3ttfKBzsTwHJ/jp0aS6B/PJCn O96P+8jiV7dJfcdvExf2uTFPc6KAvKv3fRmykz9F1nQACyAxiVL9n1WjeULkJl7dW8Fm eZo2qahJxnkEqWK0WXfl9GPE6XqvqFQw5iBnYkr45CmLReNS42EgiDaTkSTf9U6gh2+z /d15DGnS3sxF76oZqr3sb7oWTsQyIfWbD6xvEFyFXZTFWw7MOY5yGrsHqDbgOIsNBdg9 j1Sw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=u6VkEmUE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 20si13769323pgg.271.2018.11.11.15.02.36; Sun, 11 Nov 2018 15:02:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=u6VkEmUE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390784AbeKLIvI (ORCPT + 99 others); Mon, 12 Nov 2018 03:51:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:53192 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390666AbeKLIWc (ORCPT ); Mon, 12 Nov 2018 03:22:32 -0500 Received: from localhost (unknown [206.108.79.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 575B92154B; Sun, 11 Nov 2018 22:32:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1541975555; bh=lA9o59XAIbiRPSSTwTeCFIoKQb0yJfPpQr2uKMRt/DY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=u6VkEmUE0LQ3pAntoUmJ7Nhjy9i79YXqwGt1dbA+YSQ2o1X1/98PnDKdknQsRWyJI IieBKtfIP2tT2c4TaRi5s1JVFQrAb74akAeloQXvjcxp+D8d7EVnJ3+OQSVpiRpXOL VodG1KMoV1MCB/QiGV4FPgRPvO7Yk1SO1ZNR+1OU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andrew Lunn , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 071/222] net: dsa: mv88e6xxx: Fix writing to a PHY page. Date: Sun, 11 Nov 2018 14:22:48 -0800 Message-Id: <20181111221654.491589444@linuxfoundation.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181111221647.665769131@linuxfoundation.org> References: <20181111221647.665769131@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Andrew Lunn [ Upstream commit c309b158090d788e96ee597444965cb79b040484 ] After changing to the needed page, actually write the value to the register! Fixes: 09cb7dfd3f14 ("net: dsa: mv88e6xxx: describe PHY page and SerDes") Signed-off-by: Andrew Lunn Signed-off-by: David S. Miller Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/net/dsa/mv88e6xxx/phy.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/net/dsa/mv88e6xxx/phy.c +++ b/drivers/net/dsa/mv88e6xxx/phy.c @@ -110,6 +110,9 @@ int mv88e6xxx_phy_page_write(struct mv88 err = mv88e6xxx_phy_page_get(chip, phy, page); if (!err) { err = mv88e6xxx_phy_write(chip, phy, MV88E6XXX_PHY_PAGE, page); + if (!err) + err = mv88e6xxx_phy_write(chip, phy, reg, val); + mv88e6xxx_phy_page_put(chip, phy); }